From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACCBFC433FC for ; Wed, 15 Jul 2020 15:27:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8532D20720 for ; Wed, 15 Jul 2020 15:27:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594826865; bh=pd1KRNwdr6dNRTt+fz8M+If2IOA/euVVDP3NJec0v2Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=FU5av9BBaqpdqIMFh1chTaUox1GNttivojr3RLylj7jja3SB4crJHGoDQ35NmAFUN qkYw2YCL8pMDD2rqzrOLhwuy1ayKUiGzX06JsUHHrNMD0W3qYRrqYjpFtOO18fnr1Q HPIBqtiOiP9dWeyjm/kMn5E4CcTi+EOrUQSytxrM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727058AbgGOP1h (ORCPT ); Wed, 15 Jul 2020 11:27:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:33164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726335AbgGOP1g (ORCPT ); Wed, 15 Jul 2020 11:27:36 -0400 Received: from localhost (unknown [122.171.202.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 494E8206D5; Wed, 15 Jul 2020 15:27:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594826856; bh=pd1KRNwdr6dNRTt+fz8M+If2IOA/euVVDP3NJec0v2Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mrLic7g1CDBl7et7jqZXJ7pVzRWFyU0Ngir56bA7NSqYDWZvNwLYalATxabHrQ9g/ /zWFBdV6j56drzy+KQAxybFkkB7cwW/EwclG0QkT+lvwbqlr0O+Byp27fLkAKoHOcq W6yHfnruoDB+11StWz6aqiJ0N7gWJcoaRvN8+KR0= Date: Wed, 15 Jul 2020 20:57:32 +0530 From: Vinod Koul To: Fabio Estevam Cc: dmaengine@vger.kernel.org, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , linux-kernel Subject: Re: [PATCH] dmaengine: imx-sdma: remove always true comparisons Message-ID: <20200715152732.GA52592@vkoul-mobl> References: <20200715130122.39873-1-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hi Fabio, On 15-07-20, 10:16, Fabio Estevam wrote: > Hi Vinod, > > On Wed, Jul 15, 2020 at 10:01 AM Vinod Koul wrote: > > > > sdmac->event_id0 is of type unsigned int and hence can never be less > > than zero. Driver compares this at couple of places with greater than or > > equal to zero, these are always true so should be dropped > > > > drivers/dma/imx-sdma.c:1336:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] > > drivers/dma/imx-sdma.c:1637:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] > > > > Signed-off-by: Vinod Koul > > I have already fixed this problem and you have already applied my patch: > https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git/commit/?h=next&id=2f57b8d57673af2c2caf8c2c7bef01be940a5c2c My bad that I didnt run this on -next :-) -- ~Vinod