From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org, Michal Simek <michal.simek@xilinx.com>,
Hyun Kwon <hyun.kwon@xilinx.com>,
Tejas Upadhyay <tejasu@xilinx.com>,
Satish Kumar Nagireddy <SATISHNA@xilinx.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: [PATCH v7 4/5] dmaengine: xilinx: dpdma: Add debugfs support
Date: Sat, 18 Jul 2020 03:23:52 +0300 [thread overview]
Message-ID: <20200718002352.GB5962@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200717060515.GD82923@vkoul-mobl>
Hi Vinod,
On Fri, Jul 17, 2020 at 11:35:15AM +0530, Vinod Koul wrote:
> On 17-07-20, 04:33, Laurent Pinchart wrote:
>
> > +static void xilinx_dpdma_debugfs_cleanup(struct xilinx_dpdma_device *xdev)
> > +{
> > + debugfs_remove_recursive(xdev->debugfs_dir);
>
> you can skip this step as core will do so when you call
> dma_async_device_unregister()
>
> > + xdev->debugfs_dir = NULL;
> > +}
> > +
> > +static int xilinx_dpdma_debugfs_init(struct xilinx_dpdma_device *xdev)
> > +{
> > + struct dentry *dent;
> > +
> > + dpdma_debugfs.testcase = DPDMA_TC_NONE;
> > +
> > + dent = debugfs_create_dir("dpdma", xdev->common.dbg_dev_root);
> > + if (IS_ERR(dent)) {
> > + dev_err(xdev->dev, "Failed to create debugfs directory\n");
> > + return -ENODEV;
> > + }
>
> Do you really need another dir in your device root. You should already
> have .../dmaengine/<dpdma-dev-name>/ adding dpdma dir seems overkill
It's indeed overkill. I'll remove it. Thanks for catching the issue.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-07-18 0:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 1:33 [PATCH v7 0/5] dma: Add Xilinx ZynqMP DPDMA driver Laurent Pinchart
2020-07-17 1:33 ` [PATCH v7 1/5] dt: bindings: dma: xilinx: dpdma: DT bindings for Xilinx DPDMA Laurent Pinchart
2020-07-17 1:33 ` [PATCH v7 2/5] dmaengine: Add support for repeating transactions Laurent Pinchart
2020-07-17 1:33 ` [PATCH v7 3/5] dmaengine: xilinx: dpdma: Add the Xilinx DisplayPort DMA engine driver Laurent Pinchart
2020-07-17 1:33 ` [PATCH v7 4/5] dmaengine: xilinx: dpdma: Add debugfs support Laurent Pinchart
2020-07-17 6:05 ` Vinod Koul
2020-07-18 0:23 ` Laurent Pinchart [this message]
2020-07-17 1:33 ` [PATCH v7 5/5] arm64: dts: zynqmp: Add DPDMA node Laurent Pinchart
2020-07-17 6:11 ` [PATCH v7 0/5] dma: Add Xilinx ZynqMP DPDMA driver Vinod Koul
2020-07-18 0:24 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200718002352.GB5962@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=SATISHNA@xilinx.com \
--cc=dmaengine@vger.kernel.org \
--cc=hyun.kwon@xilinx.com \
--cc=michal.simek@xilinx.com \
--cc=peter.ujfalusi@ti.com \
--cc=tejasu@xilinx.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).