From: Vinod Koul <vkoul@kernel.org>
To: Rajesh Gumasta <rgumasta@nvidia.com>
Cc: ldewangan@nvidia.com, jonathanh@nvidia.com,
dan.j.williams@intel.com, thierry.reding@gmail.com,
p.zabel@pengutronix.de, dmaengine@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
kyarlagadda@nvidia.com, Pavan Kunapuli <pkunapuli@nvidia.com>
Subject: Re: [Patch v1 2/4] dma: tegra: Adding Tegra GPC DMA controller driver
Date: Mon, 27 Jul 2020 14:37:11 +0530 [thread overview]
Message-ID: <20200727090711.GN12965@vkoul-mobl> (raw)
In-Reply-To: <1595226856-19241-3-git-send-email-rgumasta@nvidia.com>
On 20-07-20, 12:04, Rajesh Gumasta wrote:
> v4 changes: Removed pending dma desc list and other unused
> data structures
>
> v3 changes: Removed free list for dma_desc and sg
This is v1 patch and we have v3/v4 stuff! Anyway this can go after the
marker succeeding sob line or cover!
>
> Adding GPC DMA controller driver for Tegra186 and Tegra194. The driver
> supports dma transfers between memory to memory, IO to memory and
> memory to IO.
This is dmaengine subsystem, so please tag to appropriately
> +/* MMIO sequence register */
> +#define TEGRA_GPCDMA_CHAN_MMIOSEQ 0x01c
> +#define TEGRA_GPCDMA_MMIOSEQ_DBL_BUF BIT(31)
> +#define TEGRA_GPCDMA_MMIOSEQ_BUS_WIDTH_8 (0 << 28)
> +#define TEGRA_GPCDMA_MMIOSEQ_BUS_WIDTH_16 (1 << 28)
> +#define TEGRA_GPCDMA_MMIOSEQ_BUS_WIDTH_32 (2 << 28)
> +#define TEGRA_GPCDMA_MMIOSEQ_BUS_WIDTH_64 (3 << 28)
> +#define TEGRA_GPCDMA_MMIOSEQ_BUS_WIDTH_128 (4 << 28)
GENMASK for these please
> +static int tegra_dma_slave_config(struct dma_chan *dc,
> + struct dma_slave_config *sconfig)
> +{
> + struct tegra_dma_channel *tdc = to_tegra_dma_chan(dc);
> +
> + if (!list_empty(&tdc->pending_sg_req)) {
> + dev_err(tdc2dev(tdc), "Configuration not allowed\n");
why is that?
Also run checkpatch --strict on this before sending.
Thanks
--
~Vinod
next prev parent reply other threads:[~2020-07-27 9:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 6:34 [Patch v1 0/4] Add Nvidia Tegra GPC-DMA driver Rajesh Gumasta
2020-07-20 6:34 ` [Patch v1 1/4] dt-bindings: dma: Add DT binding document Rajesh Gumasta
2020-07-20 6:34 ` [Patch v1 2/4] dma: tegra: Adding Tegra GPC DMA controller driver Rajesh Gumasta
2020-07-20 9:37 ` Philipp Zabel
2020-07-20 11:58 ` kernel test robot
2020-07-20 15:12 ` Dmitry Osipenko
2020-07-20 15:42 ` Randy Dunlap
2020-07-27 9:07 ` Vinod Koul [this message]
2020-07-20 6:34 ` [Patch v1 3/4] arm64: configs: enable tegra gpc dma Rajesh Gumasta
2020-07-20 6:34 ` [Patch v1 4/4] arm64: tegra: Add GPCDMA node in dt Rajesh Gumasta
2020-07-20 9:25 ` [Patch v1 0/4] Add Nvidia Tegra GPC-DMA driver Thierry Reding
2020-07-20 10:00 ` Rajesh Gumasta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727090711.GN12965@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pkunapuli@nvidia.com \
--cc=rgumasta@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).