* [PATCH] dmaengine: ti: omap-dma: Drop of_match_ptr to fix -Wunused-const-variable
@ 2020-07-28 17:09 Krzysztof Kozlowski
2020-07-28 19:55 ` Laurent Pinchart
2020-08-17 5:13 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2020-07-28 17:09 UTC (permalink / raw)
To: Vinod Koul, Dan Williams, Laurent Pinchart, dmaengine, linux-kernel
Cc: Krzysztof Kozlowski
The of_device_id is included unconditionally by of.h header and used
in the driver as well. Remove of_match_ptr to fix W=1 compile test
warning with !CONFIG_OF:
drivers/dma/ti/omap-dma.c:1892:34: warning: 'omap_dma_match' defined but not used [-Wunused-const-variable=]
1892 | static const struct of_device_id omap_dma_match[] = {
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/dma/ti/omap-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c
index 918301e17552..c9fe5e3a6b55 100644
--- a/drivers/dma/ti/omap-dma.c
+++ b/drivers/dma/ti/omap-dma.c
@@ -1904,7 +1904,7 @@ static struct platform_driver omap_dma_driver = {
.remove = omap_dma_remove,
.driver = {
.name = "omap-dma-engine",
- .of_match_table = of_match_ptr(omap_dma_match),
+ .of_match_table = omap_dma_match,
},
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: ti: omap-dma: Drop of_match_ptr to fix -Wunused-const-variable
2020-07-28 17:09 [PATCH] dmaengine: ti: omap-dma: Drop of_match_ptr to fix -Wunused-const-variable Krzysztof Kozlowski
@ 2020-07-28 19:55 ` Laurent Pinchart
2020-08-17 5:13 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2020-07-28 19:55 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: Vinod Koul, Dan Williams, dmaengine, linux-kernel
Hi Krzysztof,
Thank you for the patch.
On Tue, Jul 28, 2020 at 07:09:39PM +0200, Krzysztof Kozlowski wrote:
> The of_device_id is included unconditionally by of.h header and used
> in the driver as well. Remove of_match_ptr to fix W=1 compile test
> warning with !CONFIG_OF:
>
> drivers/dma/ti/omap-dma.c:1892:34: warning: 'omap_dma_match' defined but not used [-Wunused-const-variable=]
> 1892 | static const struct of_device_id omap_dma_match[] = {
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/dma/ti/omap-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c
> index 918301e17552..c9fe5e3a6b55 100644
> --- a/drivers/dma/ti/omap-dma.c
> +++ b/drivers/dma/ti/omap-dma.c
> @@ -1904,7 +1904,7 @@ static struct platform_driver omap_dma_driver = {
> .remove = omap_dma_remove,
> .driver = {
> .name = "omap-dma-engine",
> - .of_match_table = of_match_ptr(omap_dma_match),
> + .of_match_table = omap_dma_match,
> },
> };
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: ti: omap-dma: Drop of_match_ptr to fix -Wunused-const-variable
2020-07-28 17:09 [PATCH] dmaengine: ti: omap-dma: Drop of_match_ptr to fix -Wunused-const-variable Krzysztof Kozlowski
2020-07-28 19:55 ` Laurent Pinchart
@ 2020-08-17 5:13 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2020-08-17 5:13 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Dan Williams, Laurent Pinchart, dmaengine, linux-kernel
On 28-07-20, 19:09, Krzysztof Kozlowski wrote:
> The of_device_id is included unconditionally by of.h header and used
> in the driver as well. Remove of_match_ptr to fix W=1 compile test
> warning with !CONFIG_OF:
>
> drivers/dma/ti/omap-dma.c:1892:34: warning: 'omap_dma_match' defined but not used [-Wunused-const-variable=]
> 1892 | static const struct of_device_id omap_dma_match[] = {
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-17 5:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 17:09 [PATCH] dmaengine: ti: omap-dma: Drop of_match_ptr to fix -Wunused-const-variable Krzysztof Kozlowski
2020-07-28 19:55 ` Laurent Pinchart
2020-08-17 5:13 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).