From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A8BEC433E0 for ; Wed, 29 Jul 2020 16:43:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1662020838 for ; Wed, 29 Jul 2020 16:43:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726502AbgG2Qnd (ORCPT ); Wed, 29 Jul 2020 12:43:33 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:46616 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726496AbgG2Qnd (ORCPT ); Wed, 29 Jul 2020 12:43:33 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 3B0162004A; Wed, 29 Jul 2020 18:43:28 +0200 (CEST) Date: Wed, 29 Jul 2020 18:43:26 +0200 From: Sam Ravnborg To: Laurent Pinchart Cc: dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org, Hyun Kwon , Randy Dunlap , Liam Girdwood , Michal Simek , Alexandre Bounine , Vinod Koul , Mark Brown , Matt Porter Subject: Re: [PATCH 1/3] rapidio: Replace 'select' DMAENGINES 'with depends on' Message-ID: <20200729164326.GA1371039@ravnborg.org> References: <20200729162910.13196-1-laurent.pinchart@ideasonboard.com> <20200729162910.13196-2-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200729162910.13196-2-laurent.pinchart@ideasonboard.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=P1BnusSwAAAA:8 a=JfrnYn6hAAAA:8 a=e5mUnYsNAAAA:8 a=6Oqx4sNpb8nSHwTV4vAA:9 a=7Zwj6sZBwVKJAoWSPKxL6X1jA+E=:19 a=CjuIK1q_8ugA:10 a=D0XLA9XvdZm18NrgonBM:22 a=1CNFftbPRP8L7MoqJWF3:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hi Laurent. On Wed, Jul 29, 2020 at 07:29:08PM +0300, Laurent Pinchart wrote: > Enabling a whole subsystem from a single driver 'select' is frowned > upon and won't be accepted in new drivers, that need to use 'depends on' > instead. Existing selection of DMAENGINES will then cause circular > dependencies. Replace them with a dependency. > > Signed-off-by: Laurent Pinchart > Acked-by: Randy Dunlap > --- > drivers/rapidio/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig > index e4c422d806be..b9f8514909bf 100644 > --- a/drivers/rapidio/Kconfig > +++ b/drivers/rapidio/Kconfig > @@ -37,7 +37,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS > config RAPIDIO_DMA_ENGINE > bool "DMA Engine support for RapidIO" > depends on RAPIDIO > - select DMADEVICES > + depends on DMADEVICES $subject and changlog talks about DMAENGINES but the patch touches DMADEVICES?? Sam > select DMA_ENGINE > help > Say Y here if you want to use DMA Engine frameork for RapidIO data > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel