dmaengine.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hyun Kwon <hyun.kwon@xilinx.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Hulk Robot <hulkci@huawei.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Vinod Koul <vkoul@kernel.org>, Michal Simek <michals@xilinx.com>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static
Date: Tue, 18 Aug 2020 12:32:32 -0700	[thread overview]
Message-ID: <20200818193231.GA13699@xilinx.com> (raw)
In-Reply-To: <20200818112217.43816-1-weiyongjun1@huawei.com>

Hi Wei,

Thanks for the patch.

On Tue, Aug 18, 2020 at 04:22:17AM -0700, Wei Yongjun wrote:
> The sparse tool complains as follows:
> 
> drivers/dma/xilinx/xilinx_dpdma.c:349:37: warning:
>  symbol 'dpdma_debugfs_reqs' was not declared. Should it be static?
> 
> This variable is not used outside of xilinx_dpdma.c, so this commit
> marks it static.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 1d220435cab3 ("dmaengine: xilinx: dpdma: Add debugfs support")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Reviewed-by: Hyun Kwon <hyun.kwon@xilinx.com>

Thanks,
-hyun

> ---
>  drivers/dma/xilinx/xilinx_dpdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
> index 7db70d226e89..81ed1e482878 100644
> --- a/drivers/dma/xilinx/xilinx_dpdma.c
> +++ b/drivers/dma/xilinx/xilinx_dpdma.c
> @@ -346,7 +346,7 @@ static int xilinx_dpdma_debugfs_desc_done_irq_write(char *args)
>  }
>  
>  /* Match xilinx_dpdma_testcases vs dpdma_debugfs_reqs[] entry */
> -struct xilinx_dpdma_debugfs_request dpdma_debugfs_reqs[] = {
> +static struct xilinx_dpdma_debugfs_request dpdma_debugfs_reqs[] = {
>  	{
>  		.name = "DESCRIPTOR_DONE_INTR",
>  		.tc = DPDMA_TC_INTR_DONE,
> 

  reply	other threads:[~2020-08-18 19:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 11:22 [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static Wei Yongjun
2020-08-18 19:32 ` Hyun Kwon [this message]
2020-08-18 23:41 ` Laurent Pinchart
2020-08-19  4:26   ` Vinod Koul
2020-08-19  4:24 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200818193231.GA13699@xilinx.com \
    --to=hyun.kwon@xilinx.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=hulkci@huawei.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=michals@xilinx.com \
    --cc=vkoul@kernel.org \
    --cc=weiyongjun1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).