From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71B5DC433E1 for ; Tue, 18 Aug 2020 23:41:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52F7F20786 for ; Tue, 18 Aug 2020 23:41:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="XCdRDquM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726870AbgHRXl3 (ORCPT ); Tue, 18 Aug 2020 19:41:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726444AbgHRXl3 (ORCPT ); Tue, 18 Aug 2020 19:41:29 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2616DC061389 for ; Tue, 18 Aug 2020 16:41:28 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2B0A529E; Wed, 19 Aug 2020 01:41:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1597794085; bh=FL8lTdjHtNTiufyBf6aXCHIrsCwhOgHhz0pNGh2e54s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XCdRDquMGv+gJsaSyEoULngie1MWFCogUObH2TduN68bXUx3CbYVqgvWW3ihvEdn2 yekt8RuVzSktM+UmrKjZF9Byn6WgoiSnzxFNdQx+I38UZIVcvivXin6nYuvCRYSJn7 9VvEbVvl3tBn5vZqvr1BM5ovN1I/GXhB9OA5Ioss= Date: Wed, 19 Aug 2020 02:41:07 +0300 From: Laurent Pinchart To: Wei Yongjun Cc: Hulk Robot , Hyun Kwon , Vinod Koul , Michal Simek , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static Message-ID: <20200818234107.GC2360@pendragon.ideasonboard.com> References: <20200818112217.43816-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200818112217.43816-1-weiyongjun1@huawei.com> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hi Wei, Thank you for the patch. On Tue, Aug 18, 2020 at 07:22:17PM +0800, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/dma/xilinx/xilinx_dpdma.c:349:37: warning: > symbol 'dpdma_debugfs_reqs' was not declared. Should it be static? > > This variable is not used outside of xilinx_dpdma.c, so this commit > marks it static. > > Reported-by: Hulk Robot > Fixes: 1d220435cab3 ("dmaengine: xilinx: dpdma: Add debugfs support") > Signed-off-by: Wei Yongjun Looks good to me. Reviewed-by: Laurent Pinchart Vinod, could you pick this up as a v5.9 fix ? > --- > drivers/dma/xilinx/xilinx_dpdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c > index 7db70d226e89..81ed1e482878 100644 > --- a/drivers/dma/xilinx/xilinx_dpdma.c > +++ b/drivers/dma/xilinx/xilinx_dpdma.c > @@ -346,7 +346,7 @@ static int xilinx_dpdma_debugfs_desc_done_irq_write(char *args) > } > > /* Match xilinx_dpdma_testcases vs dpdma_debugfs_reqs[] entry */ > -struct xilinx_dpdma_debugfs_request dpdma_debugfs_reqs[] = { > +static struct xilinx_dpdma_debugfs_request dpdma_debugfs_reqs[] = { > { > .name = "DESCRIPTOR_DONE_INTR", > .tc = DPDMA_TC_INTR_DONE, > -- Regards, Laurent Pinchart