dmaengine.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandru Ardelean <alexandru.ardelean@analog.com>
To: <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <vkoul@kernel.org>, <lars@metafoo.de>, <dan.j.williams@intel.com>,
	<ardeleanalex@gmail.com>,
	Alexandru Ardelean <alexandru.ardelean@analog.com>
Subject: [RESEND PATCH v2 3/6] dmaengine: axi-dmac: move clock enable earlier
Date: Tue, 25 Aug 2020 18:19:47 +0300	[thread overview]
Message-ID: <20200825151950.57605-4-alexandru.ardelean@analog.com> (raw)
In-Reply-To: <20200825151950.57605-1-alexandru.ardelean@analog.com>

The clock may also be required to read registers from the IP core (if it is
provided and the driver needs to control it).
So, move it earlier in the probe.

Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
 drivers/dma/dma-axi-dmac.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
index 90a99bdffa2b..f4b17b5e3914 100644
--- a/drivers/dma/dma-axi-dmac.c
+++ b/drivers/dma/dma-axi-dmac.c
@@ -850,16 +850,23 @@ static int axi_dmac_probe(struct platform_device *pdev)
 	if (IS_ERR(dmac->clk))
 		return PTR_ERR(dmac->clk);
 
+	ret = clk_prepare_enable(dmac->clk);
+	if (ret < 0)
+		return ret;
+
 	of_channels = of_get_child_by_name(pdev->dev.of_node, "adi,channels");
-	if (of_channels == NULL)
-		return -ENODEV;
+	if (of_channels == NULL) {
+		ret = -ENODEV;
+		goto err_clk_disable;
+	}
 
 	for_each_child_of_node(of_channels, of_chan) {
 		ret = axi_dmac_parse_chan_dt(of_chan, &dmac->chan);
 		if (ret) {
 			of_node_put(of_chan);
 			of_node_put(of_channels);
-			return -EINVAL;
+			ret = -EINVAL;
+			goto err_clk_disable;
 		}
 	}
 	of_node_put(of_channels);
@@ -892,10 +899,6 @@ static int axi_dmac_probe(struct platform_device *pdev)
 	dmac->chan.vchan.desc_free = axi_dmac_desc_free;
 	vchan_init(&dmac->chan.vchan, dma_dev);
 
-	ret = clk_prepare_enable(dmac->clk);
-	if (ret < 0)
-		return ret;
-
 	version = axi_dmac_read(dmac, ADI_AXI_REG_VERSION);
 
 	ret = axi_dmac_detect_caps(dmac, version);
-- 
2.17.1


  parent reply	other threads:[~2020-08-25 15:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 15:19 [RESEND PATCH v2 0/6] dmaengine: axi-dmac: add support for reading bus attributes from register Alexandru Ardelean
2020-08-25 15:19 ` [RESEND PATCH v2 1/6] dmaengine: axi-dmac: move version read in probe Alexandru Ardelean
2020-08-25 15:19 ` [RESEND PATCH v2 2/6] dmaengine: axi-dmac: move active_descs list init after device-tree init Alexandru Ardelean
2020-08-25 15:19 ` Alexandru Ardelean [this message]
2020-08-25 15:19 ` [RESEND PATCH v2 4/6] dmaengine: axi-dmac: wrap entire dt parse in a function Alexandru Ardelean
2020-08-25 15:19 ` [RESEND PATCH v2 5/6] dmaengine: axi-dmac: wrap channel parameter adjust into function Alexandru Ardelean
2020-08-25 15:19 ` [RESEND PATCH v2 6/6] dmaengine: axi-dmac: add support for reading bus attributes from registers Alexandru Ardelean
2020-08-25 15:37 ` [RESEND PATCH v2 0/6] dmaengine: axi-dmac: add support for reading bus attributes from register Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200825151950.57605-4-alexandru.ardelean@analog.com \
    --to=alexandru.ardelean@analog.com \
    --cc=ardeleanalex@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).