From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vladimir Murzin <vladimir.murzin@arm.com>
Cc: dmaengine@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: 6b41030fdc790 broke dmatest badly
Date: Mon, 7 Sep 2020 15:04:40 +0300 [thread overview]
Message-ID: <20200907120440.GC1891694@smile.fi.intel.com> (raw)
In-Reply-To: <d95f1b54-2a62-7b79-c53c-c8179324e935@arm.com>
On Mon, Sep 07, 2020 at 12:03:26PM +0100, Vladimir Murzin wrote:
> On 9/4/20 6:34 PM, Andy Shevchenko wrote:
> > It becomes a bit annoying to fix dmatest after almost each release.
> > The commit 6b41030fdc79 ("dmaengine: dmatest: Restore default for channel")
> > broke my use case when I tried to start busy channel.
> >
> > So, before this patch
> > ...
> > echo "busy_chan" > channel
> > echo 1 > run
> > sh: write error: Device or resource busy
> > [ 1013.868313] dmatest: Could not start test, no channels configured
> >
> > After I have got it run on *ALL* available channels.
>
> Is not that controlled with max_channels?
How? I would like to run the test against specific channel. That channel is
occupied and thus I should get an error. This is how it suppose to work and
actually did before your patch.
> > dmatest compiled as a module.
> >
> > Fix this ASAP, otherwise I will send revert of this and followed up patch next
> > week.
>
> I don't quite get it, you are sending revert and then a fix rather then helping
> with a fix?
Correct.
> What is reason for such extreme (and non-cooperative) flow?
There are few reasons:
- the patch made a clear regression
- I do not understand what that patch is doing and how
- I do not have time to look at it
- we are now at v5.9-rc4 and it seems like one or two weeks time to get it
into v5.9 release
- and I'm annoyed by breaking this module not the first time for the last
couple of years
And on top of that it's not how OSS community works. Since you replied, I give
you time to figure out what's going on and provide necessary testing if needed.
> P.S.
> Unfortunately, I do not have access to hardware to run reproducer.
So, please, propose a fix without it. I will test myself.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-09-07 12:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 17:34 6b41030fdc790 broke dmatest badly Andy Shevchenko
2020-09-07 11:03 ` Vladimir Murzin
2020-09-07 12:04 ` Andy Shevchenko [this message]
2020-09-07 13:06 ` Vladimir Murzin
2020-09-07 14:05 ` Andy Shevchenko
2020-09-07 16:52 ` Vladimir Murzin
2020-09-11 8:34 ` Vladimir Murzin
2020-09-15 12:35 ` Andy Shevchenko
2020-09-15 12:46 ` Vladimir Murzin
[not found] ` <20200915134625.GZ3956970@smile.fi.intel.com>
2020-09-15 13:56 ` Andy Shevchenko
2020-09-15 14:20 ` Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907120440.GC1891694@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=vkoul@kernel.org \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).