dmaengine Archive on lore.kernel.org
 help / color / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: dmaengine@vger.kernel.org, "Allen Pais" <allen.lkml@gmail.com>,
	"Romain Perier" <romain.perier@gmail.com>,
	linux-kernel@vger.kernel.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [PATCH 5/5] dmaengine: owl-dma: fix kernel-doc style for enum
Date: Fri, 9 Oct 2020 09:48:22 +0530
Message-ID: <20201009041822.GC2968@vkoul-mobl> (raw)
In-Reply-To: <20201008140403.GB23649@linux>

On 08-10-20, 19:34, Manivannan Sadhasivam wrote:
> On Wed, Oct 07, 2020 at 02:01:13PM +0530, Vinod Koul wrote:
> > Driver doesn't use keyword enum for enum owl_dmadesc_offsets resulting
> > in warning:
> > 
> > drivers/dma/owl-dma.c:139: warning: cannot understand function prototype:
> > 'enum owl_dmadesc_offsets '
> > 
> > So add the keyword to fix it and also add documentation for missing
> > OWL_DMADESC_SIZE
> > 
> 
> Do we really need to document the max value? Does it produce any warning?

It does.. Once you add the enum, it will treat is as such and look at
members and complain that the OWL_DMADESC_SIZE is not documented ;)

-- 
~Vinod

      reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07  8:31 [PATCH 0/5] Fix warning in dmaengine subsystem Vinod Koul
2020-10-07  8:31 ` [PATCH 1/5] dmaengine: altera-msgdma: fix kernel-doc style for tasklet Vinod Koul
2020-10-07  8:31 ` [PATCH 2/5] dmaengine: qcom: bam_dma: " Vinod Koul
2020-10-07  8:31 ` [PATCH 3/5] dmaengine: xilinx_dma: " Vinod Koul
2020-10-07  8:36   ` Michal Simek
2020-10-07  8:31 ` [PATCH 4/5] dmaengine: zynqmp_dma: " Vinod Koul
2020-10-07  8:36   ` Michal Simek
2020-10-07  8:31 ` [PATCH 5/5] dmaengine: owl-dma: fix kernel-doc style for enum Vinod Koul
2020-10-08 14:04   ` Manivannan Sadhasivam
2020-10-09  4:18     ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201009041822.GC2968@vkoul-mobl \
    --to=vkoul@kernel.org \
    --cc=afaerber@suse.de \
    --cc=allen.lkml@gmail.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=romain.perier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org
	public-inbox-index dmaengine

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git