From: Barry Song <song.bao.hua@hisilicon.com>
To: <vkoul@kernel.org>, <dmaengine@vger.kernel.org>
Cc: <linuxarm@huawei.com>, Barry Song <song.bao.hua@hisilicon.com>
Subject: [PATCH v2 08/10] dmaengine: moxart-dma: remove redundant irqsave and irqrestore in hardIRQ
Date: Wed, 28 Oct 2020 10:52:50 +1300 [thread overview]
Message-ID: <20201027215252.25820-9-song.bao.hua@hisilicon.com> (raw)
In-Reply-To: <20201027215252.25820-1-song.bao.hua@hisilicon.com>
Running in hardIRQ, disabling IRQ is redundant since hardIRQ has disabled
IRQ. This patch removes the irqsave and irqstore to save some instruction
cycles.
Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
---
drivers/dma/moxart-dma.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/moxart-dma.c b/drivers/dma/moxart-dma.c
index 347146a6e1d0..74755093e14b 100644
--- a/drivers/dma/moxart-dma.c
+++ b/drivers/dma/moxart-dma.c
@@ -524,7 +524,6 @@ static irqreturn_t moxart_dma_interrupt(int irq, void *devid)
struct moxart_dmadev *mc = devid;
struct moxart_chan *ch = &mc->slave_chans[0];
unsigned int i;
- unsigned long flags;
u32 ctrl;
dev_dbg(chan2dev(&ch->vc.chan), "%s\n", __func__);
@@ -541,14 +540,14 @@ static irqreturn_t moxart_dma_interrupt(int irq, void *devid)
if (ctrl & APB_DMA_FIN_INT_STS) {
ctrl &= ~APB_DMA_FIN_INT_STS;
if (ch->desc) {
- spin_lock_irqsave(&ch->vc.lock, flags);
+ spin_lock(&ch->vc.lock);
if (++ch->sgidx < ch->desc->sglen) {
moxart_dma_start_sg(ch, ch->sgidx);
} else {
vchan_cookie_complete(&ch->desc->vd);
moxart_dma_start_desc(&ch->vc.chan);
}
- spin_unlock_irqrestore(&ch->vc.lock, flags);
+ spin_unlock(&ch->vc.lock);
}
}
--
2.25.1
next prev parent reply other threads:[~2020-10-27 21:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 21:52 [PATCH v2 00/10] dmaengine: a bundle of cleanup on spin_lock_irqsave/irqrestore Barry Song
2020-10-27 21:52 ` [PATCH v2 01/10] dmaengine: ipu_idmac: remove redundant irqsave and restore in hardIRQ Barry Song
2020-10-27 21:52 ` [PATCH v2 02/10] dmaengine: ti: k3-udma: remove redundant irqsave and irqrestore " Barry Song
2020-10-27 21:52 ` [PATCH v2 03/10] dmaengine: sf-pdma: " Barry Song
2020-10-27 21:52 ` [PATCH v2 04/10] dmaengine: tegra210-adma: " Barry Song
2020-10-27 21:52 ` [PATCH v2 05/10] dmaengine: milbeaut-xdmac: " Barry Song
2020-10-27 21:52 ` [PATCH v2 06/10] dmaengine: k3dma: " Barry Song
2020-10-27 21:52 ` [PATCH v2 07/10] dmaengine: hisi_dma: " Barry Song
2020-10-27 21:52 ` Barry Song [this message]
2020-10-27 21:52 ` [PATCH v2 09/10] dmaengine: ste_dma40: " Barry Song
2020-11-05 13:48 ` Linus Walleij
2020-10-27 21:52 ` [PATCH v2 10/10] dmaengine: pxa_dma: " Barry Song
2020-11-09 11:56 ` [PATCH v2 00/10] dmaengine: a bundle of cleanup on spin_lock_irqsave/irqrestore Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027215252.25820-9-song.bao.hua@hisilicon.com \
--to=song.bao.hua@hisilicon.com \
--cc=dmaengine@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).