From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1311C4361B for ; Wed, 16 Dec 2020 16:23:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B84AE2335A for ; Wed, 16 Dec 2020 16:23:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726155AbgLPQW7 (ORCPT ); Wed, 16 Dec 2020 11:22:59 -0500 Received: from mga01.intel.com ([192.55.52.88]:64599 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725889AbgLPQW7 (ORCPT ); Wed, 16 Dec 2020 11:22:59 -0500 IronPort-SDR: hfGiN8SALici98Wzdyrn6EzL+xR34Px54mozyu8VUuUlrabEh5iyRVnCDiqRiyqw2hP/J+xLMj Hk6Rs5iqF+ow== X-IronPort-AV: E=McAfee;i="6000,8403,9837"; a="193475554" X-IronPort-AV: E=Sophos;i="5.78,424,1599548400"; d="scan'208";a="193475554" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2020 08:22:18 -0800 IronPort-SDR: VETua8fxWHr/CeIooreX6c+iVQLzE+ovXAJm6vDZGzLbFLieJpIkeqXraEvdRe3zWV6SO9kF+9 gTt+BpkHUVNA== X-IronPort-AV: E=Sophos;i="5.78,424,1599548400"; d="scan'208";a="369160262" Received: from anagallo-mobl.amr.corp.intel.com (HELO localhost) ([10.209.99.164]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2020 08:22:17 -0800 Date: Wed, 16 Dec 2020 09:22:15 -0700 From: Dave Jiang To: Dan Carpenter Cc: Vinod Koul , Dan Williams , dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] dmaengine: idxd: off by one in cleanup code Message-ID: <20201216092215.000061b6@intel.com> In-Reply-To: References: Organization: Intel Corp X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Wed, 16 Dec 2020 11:29:46 +0300 Dan Carpenter wrote: > The clean up is off by one so this will start at "i" and it should > start with "i - 1" and then it doesn't unregister the zeroeth > elements in the array. > > Fixes: c52ca478233c ("dmaengine: idxd: add configuration component of > driver") Signed-off-by: Dan Carpenter Acked-by: Dave Jiang Thanks Dan! > --- > drivers/dma/idxd/sysfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c > index 266423a2cabc..4dbb03c545e4 100644 > --- a/drivers/dma/idxd/sysfs.c > +++ b/drivers/dma/idxd/sysfs.c > @@ -434,7 +434,7 @@ int idxd_register_driver(void) > return 0; > > drv_fail: > - for (; i > 0; i--) > + while (--i >= 0) > driver_unregister(&idxd_drvs[i]->drv); > return rc; > } > @@ -1840,7 +1840,7 @@ int idxd_register_bus_type(void) > return 0; > > bus_err: > - for (; i > 0; i--) > + while (--i >= 0) > bus_unregister(idxd_bus_types[i]); > return rc; > }