* [PATCH] dmaengine: idxd: off by one in cleanup code
@ 2020-12-16 8:29 Dan Carpenter
2020-12-16 16:22 ` Dave Jiang
2020-12-21 13:59 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-12-16 8:29 UTC (permalink / raw)
To: Dave Jiang; +Cc: Vinod Koul, Dan Williams, dmaengine, kernel-janitors
The clean up is off by one so this will start at "i" and it should start
with "i - 1" and then it doesn't unregister the zeroeth elements in the
array.
Fixes: c52ca478233c ("dmaengine: idxd: add configuration component of driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/dma/idxd/sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c
index 266423a2cabc..4dbb03c545e4 100644
--- a/drivers/dma/idxd/sysfs.c
+++ b/drivers/dma/idxd/sysfs.c
@@ -434,7 +434,7 @@ int idxd_register_driver(void)
return 0;
drv_fail:
- for (; i > 0; i--)
+ while (--i >= 0)
driver_unregister(&idxd_drvs[i]->drv);
return rc;
}
@@ -1840,7 +1840,7 @@ int idxd_register_bus_type(void)
return 0;
bus_err:
- for (; i > 0; i--)
+ while (--i >= 0)
bus_unregister(idxd_bus_types[i]);
return rc;
}
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: idxd: off by one in cleanup code
2020-12-16 8:29 [PATCH] dmaengine: idxd: off by one in cleanup code Dan Carpenter
@ 2020-12-16 16:22 ` Dave Jiang
2020-12-21 13:59 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2020-12-16 16:22 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Vinod Koul, Dan Williams, dmaengine, kernel-janitors
On Wed, 16 Dec 2020 11:29:46 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The clean up is off by one so this will start at "i" and it should
> start with "i - 1" and then it doesn't unregister the zeroeth
> elements in the array.
>
> Fixes: c52ca478233c ("dmaengine: idxd: add configuration component of
> driver") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Dave Jiang <dave.jiang@intel.com>
Thanks Dan!
> ---
> drivers/dma/idxd/sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c
> index 266423a2cabc..4dbb03c545e4 100644
> --- a/drivers/dma/idxd/sysfs.c
> +++ b/drivers/dma/idxd/sysfs.c
> @@ -434,7 +434,7 @@ int idxd_register_driver(void)
> return 0;
>
> drv_fail:
> - for (; i > 0; i--)
> + while (--i >= 0)
> driver_unregister(&idxd_drvs[i]->drv);
> return rc;
> }
> @@ -1840,7 +1840,7 @@ int idxd_register_bus_type(void)
> return 0;
>
> bus_err:
> - for (; i > 0; i--)
> + while (--i >= 0)
> bus_unregister(idxd_bus_types[i]);
> return rc;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: idxd: off by one in cleanup code
2020-12-16 8:29 [PATCH] dmaengine: idxd: off by one in cleanup code Dan Carpenter
2020-12-16 16:22 ` Dave Jiang
@ 2020-12-21 13:59 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2020-12-21 13:59 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Dave Jiang, Dan Williams, dmaengine, kernel-janitors
On 16-12-20, 11:29, Dan Carpenter wrote:
> The clean up is off by one so this will start at "i" and it should start
> with "i - 1" and then it doesn't unregister the zeroeth elements in the
> array.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-21 13:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-16 8:29 [PATCH] dmaengine: idxd: off by one in cleanup code Dan Carpenter
2020-12-16 16:22 ` Dave Jiang
2020-12-21 13:59 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).