From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 740CAC43332 for ; Thu, 7 Jan 2021 16:41:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E07C23403 for ; Thu, 7 Jan 2021 16:41:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728251AbhAGQld (ORCPT ); Thu, 7 Jan 2021 11:41:33 -0500 Received: from elvis.franken.de ([193.175.24.41]:34782 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727874AbhAGQld (ORCPT ); Thu, 7 Jan 2021 11:41:33 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kxYL4-0000Tv-00; Thu, 07 Jan 2021 17:40:42 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 98E5BC080E; Thu, 7 Jan 2021 17:40:15 +0100 (CET) Date: Thu, 7 Jan 2021 17:40:15 +0100 From: Thomas Bogendoerfer To: Joe Perches Cc: Matt Mackall , Herbert Xu , Dan Williams , Vinod Koul , "David S. Miller" , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Jakub Kicinski , Alessandro Zummo , Alexandre Belloni , Mark Brown , Wim Van Sebroeck , Guenter Roeck , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org, linux-ide@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, linux-watchdog@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 05/10] dma: tx49 removal Message-ID: <20210107164015.GA12533@alpha.franken.de> References: <20210105140305.141401-1-tsbogend@alpha.franken.de> <20210105140305.141401-6-tsbogend@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Wed, Jan 06, 2021 at 11:10:38AM -0800, Joe Perches wrote: > On Tue, 2021-01-05 at 15:02 +0100, Thomas Bogendoerfer wrote: > > Signed-off-by: Thomas Bogendoerfer > [] > > diff --git a/drivers/dma/txx9dmac.h b/drivers/dma/txx9dmac.h > [] > > @@ -26,11 +26,6 @@ > >   * DMA channel. > >   */ > >   > > > > -#ifdef CONFIG_MACH_TX49XX > > -static inline bool txx9_dma_have_SMPCHN(void) > > -{ > > - return true; > > -} > >  #define TXX9_DMA_USE_SIMPLE_CHAIN > >  #else > >  static inline bool txx9_dma_have_SMPCHN(void) > > This doesn't look like it compiles as there's now an #else > without an #if you are right, no idea what I had in mind while doing that. Vinod, as this patch series found a still active user of the platform, could you drop the patch from your tree, or do you want a revert from me ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]