From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74EA3C04FF3 for ; Sat, 22 May 2021 02:13:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46C6861177 for ; Sat, 22 May 2021 02:13:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230474AbhEVCOo (ORCPT ); Fri, 21 May 2021 22:14:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230371AbhEVCOn (ORCPT ); Fri, 21 May 2021 22:14:43 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84A69C0613ED; Fri, 21 May 2021 19:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=l7pAGv6nylMQQxZzZY1b/tuf+2vehC2Wuu34Kc+vOmA=; b=UA1pWQOTTMWToP+sPmYtSuMl7w Xorugk/p4Ah8YsOaYhPSaDzXhYtKmuHq+JKigCnLkk3GDixP/FXoP3iuYbSpKcwZxngddrFTa6ytx W/eQ1pvtFCR0hQ+juC2h5/6lzkwouQ6/nhzMExXebNSYd2AMXHo8JRjPNLpR1LGqvmY7vhtU0Prtl h9d9bhk1k/9on7N28pYf+XNXu415TMs/3wInqfQnnjMqzhdZlRT41N0hGK4kifzUtHwcY4Y5/BSZn +SguzLc+nx+bvK8wIPKle0eggzKvFU7BJVcoL6QfYWazD2s2m/n7n3N4mhKFoi50jhHCMGF2GBgSJ hpYYnHLw==; Received: from [2601:1c0:6280:3f0::7376] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lkH8e-00HX9I-Jh; Sat, 22 May 2021 02:13:16 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Stefan Roese , Vinod Koul , dmaengine@vger.kernel.org, Sinan Kaya , Green Wan , Hyun Kwon , Tejas Upadhyay , Michal Simek , Laurent Pinchart , kernel test robot Subject: [PATCH 2/4] DMA: QCOM_HIDMA_MGMT depends on HAS_IOMEM Date: Fri, 21 May 2021 19:13:11 -0700 Message-Id: <20210522021313.16405-3-rdunlap@infradead.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210522021313.16405-1-rdunlap@infradead.org> References: <20210522021313.16405-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org When CONFIG_HAS_IOMEM is not set/enabled, certain iomap() family functions [including ioremap(), devm_ioremap(), etc.] are not available. Drivers that use these functions should depend on HAS_IOMEM so that they do not cause build errors. Rectifies these build errors: s390-linux-ld: drivers/dma/qcom/hidma_mgmt.o: in function `hidma_mgmt_probe': hidma_mgmt.c:(.text+0x780): undefined reference to `devm_ioremap_resource' s390-linux-ld: drivers/dma/qcom/hidma_mgmt.o: in function `hidma_mgmt_init': hidma_mgmt.c:(.init.text+0x126): undefined reference to `of_address_to_resource' s390-linux-ld: hidma_mgmt.c:(.init.text+0x16e): undefined reference to `of_address_to_resource' Fixes: 67a2003e0607 ("dmaengine: add Qualcomm Technologies HIDMA channel driver") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Sinan Kaya Cc: Vinod Koul Cc: dmaengine@vger.kernel.org --- drivers/dma/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+) --- linux-next-20210521.orig/drivers/dma/qcom/Kconfig +++ linux-next-20210521/drivers/dma/qcom/Kconfig @@ -33,6 +33,7 @@ config QCOM_GPI_DMA config QCOM_HIDMA_MGMT tristate "Qualcomm Technologies HIDMA Management support" + depends on HAS_IOMEM select DMA_ENGINE help Enable support for the Qualcomm Technologies HIDMA Management.