From: Jason Gunthorpe <jgg@nvidia.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: alex.williamson@redhat.com, kwankhede@nvidia.com,
tglx@linutronix.de, vkoul@kernel.org, megha.dey@intel.com,
jacob.jun.pan@intel.com, ashok.raj@intel.com, yi.l.liu@intel.com,
baolu.lu@intel.com, kevin.tian@intel.com,
sanjay.k.kumar@intel.com, tony.luck@intel.com,
dan.j.williams@intel.com, eric.auger@redhat.com,
pbonzini@redhat.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v6 13/20] vfio/mdev: idxd: add mdev driver registration and helper functions
Date: Sun, 23 May 2021 20:32:23 -0300 [thread overview]
Message-ID: <20210523233223.GI1002214@nvidia.com> (raw)
In-Reply-To: <162164282601.261970.10405911922092921185.stgit@djiang5-desk3.ch.intel.com>
On Fri, May 21, 2021 at 05:20:26PM -0700, Dave Jiang wrote:
> +static int idxd_vdcm_mmap(struct vfio_device *vdev, struct vm_area_struct *vma)
> +{
> + unsigned int wq_idx;
> + unsigned long req_size, pgoff = 0, offset;
> + pgprot_t pg_prot;
> + struct vdcm_idxd *vidxd = vdev_to_vidxd(vdev);
> + struct idxd_wq *wq = vidxd->wq;
> + struct idxd_device *idxd = vidxd->idxd;
> + enum idxd_portal_prot virt_portal, phys_portal;
> + phys_addr_t base = pci_resource_start(idxd->pdev, IDXD_WQ_BAR);
> + struct device *dev = vdev->dev;
> +
> + if (!(vma->vm_flags & VM_SHARED))
> + return -EINVAL;
> +
> + pg_prot = vma->vm_page_prot;
> + req_size = vma->vm_end - vma->vm_start;
> + if (req_size > PAGE_SIZE)
> + return -EINVAL;
> +
> + vma->vm_flags |= VM_DONTCOPY;
> +
> + offset = (vma->vm_pgoff << PAGE_SHIFT) &
> + ((1ULL << VFIO_PCI_OFFSET_SHIFT) - 1);
> +
> + wq_idx = offset >> (PAGE_SHIFT + 2);
> + if (wq_idx >= 1) {
> + dev_err(dev, "mapping invalid wq %d off %lx\n",
> + wq_idx, offset);
> + return -EINVAL;
> + }
This is a really wonky and leaky way to say that the vm_pgoff can only
be one of two values? It is uAPI, be thorough.
> +static long idxd_vdcm_ioctl(struct vfio_device *vdev, unsigned int cmd, unsigned long arg)
> +{
> + struct vdcm_idxd *vidxd = vdev_to_vidxd(vdev);
> + unsigned long minsz;
> + int rc = -EINVAL;
> + struct device *dev = vdev->dev;
> +
> + dev_dbg(dev, "vidxd %p ioctl, cmd: %d\n", vidxd, cmd);
> +
> + mutex_lock(&vidxd->dev_lock);
> + if (cmd == VFIO_DEVICE_GET_INFO) {
Sigh.. This ioctl stuff really needs splitting into proper functions
called by the core code instead of cut&pasting all of this
> static int idxd_mdev_drv_probe(struct device *dev)
> diff --git a/drivers/vfio/mdev/idxd/mdev.h b/drivers/vfio/mdev/idxd/mdev.h
> index f696fe38e374..dd4290bce772 100644
> +++ b/drivers/vfio/mdev/idxd/mdev.h
> @@ -30,11 +30,26 @@
> #define VIDXD_MAX_MSIX_ENTRIES VIDXD_MAX_MSIX_VECS
> #define VIDXD_MAX_WQS 1
>
> +#define IDXD_MDEV_NAME_LEN 64
This is never used. Check everything..
Jason
next prev parent reply other threads:[~2021-05-23 23:32 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 0:19 [PATCH v6 00/20] Add VFIO mediated device support and DEV-MSI support for the idxd driver Dave Jiang
2021-05-22 0:19 ` [PATCH v6 01/20] vfio/mdev: idxd: add theory of operation documentation for idxd mdev Dave Jiang
2021-05-22 0:19 ` [PATCH v6 02/20] dmaengine: idxd: add external module driver support for dsa_bus_type Dave Jiang
2021-05-22 0:19 ` [PATCH v6 03/20] dmaengine: idxd: add IMS offset and size retrieval code Dave Jiang
2021-05-22 0:19 ` [PATCH v6 04/20] dmaengine: idxd: add portal offset for IMS portals Dave Jiang
2021-05-22 0:19 ` [PATCH v6 05/20] vfio: mdev: common lib code for setting up Interrupt Message Store Dave Jiang
2021-05-24 0:02 ` Jason Gunthorpe
2021-05-28 1:49 ` Dave Jiang
2021-05-28 12:21 ` Jason Gunthorpe
2021-05-28 16:37 ` Dave Jiang
2021-05-28 16:39 ` Jason Gunthorpe
2021-05-31 10:41 ` Thomas Gleixner
2021-05-31 13:48 ` Thomas Gleixner
2021-05-31 15:24 ` Jason Gunthorpe
2021-06-08 15:57 ` Dave Jiang
2021-06-08 17:22 ` Jason Gunthorpe
2021-06-10 13:00 ` Thomas Gleixner
2021-05-22 0:19 ` [PATCH v6 06/20] vfio/mdev: idxd: add PCI config for read/write for mdev Dave Jiang
2021-05-22 0:19 ` [PATCH v6 07/20] vfio/mdev: idxd: Add administrative commands emulation " Dave Jiang
2021-05-22 0:19 ` [PATCH v6 08/20] vfio/mdev: idxd: Add mdev device context initialization Dave Jiang
2021-05-22 0:20 ` [PATCH v6 09/20] vfio/mdev: Add mmio read/write support for mdev Dave Jiang
2021-05-22 0:20 ` [PATCH v6 10/20] vfio/mdev: idxd: add mdev type as a new wq type Dave Jiang
2021-05-22 0:20 ` [PATCH v6 11/20] vfio/mdev: idxd: Add basic driver setup for idxd mdev Dave Jiang
2021-05-23 23:27 ` Jason Gunthorpe
2021-05-23 23:52 ` Jason Gunthorpe
2021-05-22 0:20 ` [PATCH v6 12/20] vfio: move VFIO PCI macros to common header Dave Jiang
2021-06-04 3:47 ` Alex Williamson
2021-05-22 0:20 ` [PATCH v6 13/20] vfio/mdev: idxd: add mdev driver registration and helper functions Dave Jiang
2021-05-23 23:32 ` Jason Gunthorpe [this message]
2021-05-23 23:46 ` Jason Gunthorpe
2021-05-22 0:20 ` [PATCH v6 14/20] vfio/mdev: idxd: add 1dwq-v1 mdev type Dave Jiang
2021-05-23 23:47 ` Jason Gunthorpe
2021-05-22 0:20 ` [PATCH v6 15/20] vfio/mdev: idxd: ims domain setup for the vdcm Dave Jiang
2021-05-23 23:50 ` Jason Gunthorpe
2021-05-27 0:22 ` Dave Jiang
2021-05-27 0:54 ` Jason Gunthorpe
2021-05-27 1:15 ` Dave Jiang
2021-05-27 1:41 ` Raj, Ashok
2021-05-27 13:36 ` Jason Gunthorpe
2021-05-31 14:02 ` Thomas Gleixner
2021-05-31 16:57 ` Jason Gunthorpe
2021-05-31 23:55 ` Thomas Gleixner
2021-06-01 12:16 ` Jason Gunthorpe
2021-05-22 0:20 ` [PATCH v6 16/20] vfio/mdev: idxd: add new wq state for mdev Dave Jiang
2021-05-22 0:20 ` [PATCH v6 17/20] vfio/mdev: idxd: add error notification from host driver to mediated device Dave Jiang
2021-05-22 0:20 ` [PATCH v6 18/20] vfio: move vfio_pci_set_ctx_trigger_single to common code Dave Jiang
2021-05-22 0:21 ` [PATCH v6 19/20] vfio: mdev: Add device request interface Dave Jiang
2021-05-23 22:38 ` Jason Gunthorpe
2021-05-22 0:21 ` [PATCH v6 20/20] vfio: mdev: idxd: setup request interrupt Dave Jiang
2021-05-23 23:22 ` [PATCH v6 00/20] Add VFIO mediated device support and DEV-MSI support for the idxd driver Jason Gunthorpe
2021-06-02 15:40 ` Dave Jiang
2021-06-02 23:17 ` Jason Gunthorpe
2021-06-03 1:11 ` Tian, Kevin
2021-06-03 1:49 ` Jason Gunthorpe
2021-06-03 5:52 ` Tian, Kevin
2021-06-03 11:23 ` Jason Gunthorpe
2021-06-04 3:40 ` Alex Williamson
2021-06-07 6:22 ` Tian, Kevin
2021-06-07 18:13 ` Dave Jiang
2021-06-07 19:11 ` Jason Gunthorpe
2021-06-08 16:02 ` Dave Jiang
2021-06-11 18:21 ` Dave Jiang
2021-06-11 18:29 ` Jason Gunthorpe
2021-06-07 18:28 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210523233223.GI1002214@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=eric.auger@redhat.com \
--cc=jacob.jun.pan@intel.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=megha.dey@intel.com \
--cc=pbonzini@redhat.com \
--cc=sanjay.k.kumar@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vkoul@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).