Hi Dave, I love your patch! Perhaps something to improve: [auto build test WARNING on vkoul-dmaengine/next] [also build test WARNING on v5.13-rc4 next-20210603] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Dave-Jiang/dmanegine-idxd-cleanup-all-device-related-bits-after-disabling-device/20210604-053001 base: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/14a8f88b13e03ff7d7606519b823e9fac4b7af36 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Dave-Jiang/dmanegine-idxd-cleanup-all-device-related-bits-after-disabling-device/20210604-053001 git checkout 14a8f88b13e03ff7d7606519b823e9fac4b7af36 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/dma/idxd/sysfs.c: In function 'idxd_config_bus_remove': >> drivers/dma/idxd/sysfs.c:265:6: warning: variable 'rc' set but not used [-Wunused-but-set-variable] 265 | int rc; | ^~ vim +/rc +265 drivers/dma/idxd/sysfs.c c52ca478233c17 Dave Jiang 2020-01-21 262 c52ca478233c17 Dave Jiang 2020-01-21 263 static int idxd_config_bus_remove(struct device *dev) c52ca478233c17 Dave Jiang 2020-01-21 264 { c52ca478233c17 Dave Jiang 2020-01-21 @265 int rc; c52ca478233c17 Dave Jiang 2020-01-21 266 c52ca478233c17 Dave Jiang 2020-01-21 267 dev_dbg(dev, "%s called for %s\n", __func__, dev_name(dev)); c52ca478233c17 Dave Jiang 2020-01-21 268 c52ca478233c17 Dave Jiang 2020-01-21 269 /* disable workqueue here */ c52ca478233c17 Dave Jiang 2020-01-21 270 if (is_idxd_wq_dev(dev)) { c52ca478233c17 Dave Jiang 2020-01-21 271 struct idxd_wq *wq = confdev_to_wq(dev); c52ca478233c17 Dave Jiang 2020-01-21 272 c52ca478233c17 Dave Jiang 2020-01-21 273 disable_wq(wq); c52ca478233c17 Dave Jiang 2020-01-21 274 } else if (is_idxd_dev(dev)) { c52ca478233c17 Dave Jiang 2020-01-21 275 struct idxd_device *idxd = confdev_to_idxd(dev); c52ca478233c17 Dave Jiang 2020-01-21 276 int i; c52ca478233c17 Dave Jiang 2020-01-21 277 c52ca478233c17 Dave Jiang 2020-01-21 278 dev_dbg(dev, "%s removing dev %s\n", __func__, c52ca478233c17 Dave Jiang 2020-01-21 279 dev_name(&idxd->conf_dev)); c52ca478233c17 Dave Jiang 2020-01-21 280 for (i = 0; i < idxd->max_wqs; i++) { 7c5dd23e57c14c Dave Jiang 2021-04-15 281 struct idxd_wq *wq = idxd->wqs[i]; c52ca478233c17 Dave Jiang 2020-01-21 282 c52ca478233c17 Dave Jiang 2020-01-21 283 if (wq->state == IDXD_WQ_DISABLED) c52ca478233c17 Dave Jiang 2020-01-21 284 continue; c52ca478233c17 Dave Jiang 2020-01-21 285 dev_warn(dev, "Active wq %d on disable %s.\n", i, c52ca478233c17 Dave Jiang 2020-01-21 286 dev_name(&idxd->conf_dev)); c52ca478233c17 Dave Jiang 2020-01-21 287 device_release_driver(&wq->conf_dev); c52ca478233c17 Dave Jiang 2020-01-21 288 } c52ca478233c17 Dave Jiang 2020-01-21 289 8f47d1a5e545f9 Dave Jiang 2020-01-21 290 idxd_unregister_dma_device(idxd); c52ca478233c17 Dave Jiang 2020-01-21 291 rc = idxd_device_disable(idxd); 14a8f88b13e03f Dave Jiang 2021-06-03 292 idxd_device_reset(idxd); 42d279f9137ab7 Dave Jiang 2020-01-21 293 module_put(THIS_MODULE); 42d279f9137ab7 Dave Jiang 2020-01-21 294 14a8f88b13e03f Dave Jiang 2021-06-03 295 dev_info(dev, "Device %s disabled\n", dev_name(dev)); c52ca478233c17 Dave Jiang 2020-01-21 296 } c52ca478233c17 Dave Jiang 2020-01-21 297 c52ca478233c17 Dave Jiang 2020-01-21 298 return 0; c52ca478233c17 Dave Jiang 2020-01-21 299 } c52ca478233c17 Dave Jiang 2020-01-21 300 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org