From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: "Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Frank Li" <Frank.Li@nxp.com>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Alexey Malahov" <Alexey.Malahov@baikalelectronics.ru>,
"Pavel Parkhomenko" <Pavel.Parkhomenko@baikalelectronics.ru>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
linux-pci@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 14/26] dmaengine: dw-edma: Convert DebugFS descs to being kz-allocated
Date: Thu, 12 May 2022 20:47:34 +0530 [thread overview]
Message-ID: <20220512151734.GK35848@thinkpad> (raw)
In-Reply-To: <20220503225104.12108-15-Sergey.Semin@baikalelectronics.ru>
On Wed, May 04, 2022 at 01:50:52AM +0300, Serge Semin wrote:
> Currently all the DW eDMA DebugFS nodes descriptors are allocated on
> stack, while the DW eDMA driver private data and CSR limits are statically
> preserved. Such design won't work for the multi-eDMA platforms. As a
> preparation to adding the multi-eDMA system setups support we need to have
> each DebugFS node separately allocated and described. Afterwards we'll put
> an addition info there like Read/Write channel flag, channel ID, DW eDMA
> private data reference.
>
> Note this conversion is mainly required due to having the legacy DW eDMA
> controllers with indirect Read/Write channels context CSRs access. If we
> didn't need to have a synchronized access to these registers the DebugFS
> code of the driver would have been much simpler.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
>
> ---
>
> Changelog v2:
> - Drop __iomem qualifier from the struct dw_edma_debugfs_entry instance
> definition in the dw_edma_debugfs_u32_get() method. (@Manivannan)
> ---
> drivers/dma/dw-edma/dw-edma-v0-debugfs.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/dw-edma/dw-edma-v0-debugfs.c b/drivers/dma/dw-edma/dw-edma-v0-debugfs.c
> index 2121ffc33cf3..78f15e4b07ac 100644
> --- a/drivers/dma/dw-edma/dw-edma-v0-debugfs.c
> +++ b/drivers/dma/dw-edma/dw-edma-v0-debugfs.c
> @@ -53,7 +53,8 @@ struct dw_edma_debugfs_entry {
>
> static int dw_edma_debugfs_u32_get(void *data, u64 *val)
> {
> - void __iomem *reg = data;
> + struct dw_edma_debugfs_entry *entry = data;
> + void __iomem *reg = entry->reg;
>
> if (dw->chip->mf == EDMA_MF_EDMA_LEGACY &&
> reg >= (void __iomem *)®s->type.legacy.ch) {
> @@ -94,14 +95,22 @@ static int dw_edma_debugfs_u32_get(void *data, u64 *val)
> }
> DEFINE_DEBUGFS_ATTRIBUTE(fops_x32, dw_edma_debugfs_u32_get, NULL, "0x%08llx\n");
>
> -static void dw_edma_debugfs_create_x32(const struct dw_edma_debugfs_entry entries[],
> +static void dw_edma_debugfs_create_x32(const struct dw_edma_debugfs_entry ini[],
> int nr_entries, struct dentry *dir)
> {
> + struct dw_edma_debugfs_entry *entries;
> int i;
>
> + entries = devm_kcalloc(dw->chip->dev, nr_entries, sizeof(*entries),
> + GFP_KERNEL);
> + if (!entries)
> + return;
> +
> for (i = 0; i < nr_entries; i++) {
> + entries[i] = ini[i];
> +
> debugfs_create_file_unsafe(entries[i].name, 0444, dir,
> - entries[i].reg, &fops_x32);
> + &entries[i], &fops_x32);
> }
> }
>
> --
> 2.35.1
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-05-12 15:17 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 22:50 [PATCH v2 00/26] dmaengine: dw-edma: Add RP/EP local DMA controllers support Serge Semin
2022-05-03 22:50 ` [PATCH v2 01/26] dma-direct: take dma-ranges/offsets into account in resource mapping Serge Semin
2022-05-09 6:15 ` Christoph Hellwig
2022-05-12 23:28 ` Serge Semin
2022-05-03 22:50 ` [PATCH v2 02/26] dmaengine: Fix dma_slave_config.dst_addr description Serge Semin
2022-05-12 14:18 ` Manivannan Sadhasivam
2022-05-03 22:50 ` [PATCH v2 03/26] dmaengine: dw-edma: Release requested IRQs on failure Serge Semin
2022-05-12 14:39 ` Manivannan Sadhasivam
2022-05-03 22:50 ` [PATCH v2 04/26] dmaengine: dw-edma: Convert ll/dt phys-address to PCIe bus/DMA address Serge Semin
2022-05-03 22:50 ` [PATCH v2 05/26] dmaengine: dw-edma: Fix missing src/dst address of the interleaved xfers Serge Semin
2022-05-03 22:50 ` [PATCH v2 06/26] dmaengine: dw-edma: Don't permit non-inc " Serge Semin
2022-05-12 14:41 ` Manivannan Sadhasivam
2022-05-03 22:50 ` [PATCH v2 07/26] dmaengine: dw-edma: Fix invalid interleaved xfers semantics Serge Semin
2022-05-12 15:16 ` Manivannan Sadhasivam
2022-05-03 22:50 ` [PATCH v2 08/26] dmaengine: dw-edma: Add CPU to PCIe bus address translation Serge Semin
2022-05-03 22:50 ` [PATCH v2 09/26] dmaengine: dw-edma: Add PCIe bus address getter to the remote EP glue-driver Serge Semin
2022-05-03 22:50 ` [PATCH v2 10/26] dmaengine: dw-edma: Drop chancnt initialization Serge Semin
2022-05-03 22:50 ` [PATCH v2 11/26] dmaengine: dw-edma: Fix DebugFS reg entry type Serge Semin
2022-05-03 22:50 ` [PATCH v2 12/26] dmaengine: dw-edma: Stop checking debugfs_create_*() return value Serge Semin
2022-05-03 22:50 ` [PATCH v2 13/26] dmaengine: dw-edma: Add dw_edma prefix to the DebugFS nodes descriptor Serge Semin
2022-05-03 22:50 ` [PATCH v2 14/26] dmaengine: dw-edma: Convert DebugFS descs to being kz-allocated Serge Semin
2022-05-12 15:17 ` Manivannan Sadhasivam [this message]
2022-05-03 22:50 ` [PATCH v2 15/26] dmaengine: dw-edma: Rename DebugFS dentry variables to 'dent' Serge Semin
2022-05-12 15:19 ` Manivannan Sadhasivam
2022-05-03 22:50 ` [PATCH v2 16/26] dmaengine: dw-edma: Simplify the DebugFS context CSRs init procedure Serge Semin
2022-05-12 15:20 ` Manivannan Sadhasivam
2022-05-03 22:50 ` [PATCH v2 17/26] dmaengine: dw-edma: Move eDMA data pointer to DebugFS node descriptor Serge Semin
2022-05-03 22:50 ` [PATCH v2 18/26] dmaengine: dw-edma: Join Write/Read channels into a single device Serge Semin
2022-05-03 22:50 ` [PATCH v2 19/26] dmaengine: dw-edma: Use DMA-engine device DebugFS subdirectory Serge Semin
2022-05-03 22:50 ` [PATCH v2 20/26] dmaengine: dw-edma: Use non-atomic io-64 methods Serge Semin
2022-05-12 15:21 ` Manivannan Sadhasivam
2022-05-03 22:50 ` [PATCH v2 21/26] dmaengine: dw-edma: Drop DT-region allocation Serge Semin
2022-05-03 22:51 ` [PATCH v2 22/26] dmaengine: dw-edma: Replace chip ID number with device name Serge Semin
2022-05-03 22:51 ` [PATCH v2 23/26] dmaengine: dw-edma: Bypass dma-ranges mapping for the local setup Serge Semin
2022-05-24 13:19 ` Manivannan Sadhasivam
2022-05-25 8:56 ` Serge Semin
2022-05-03 22:51 ` [PATCH v2 24/26] dmaengine: dw-edma: Skip cleanup procedure if no private data found Serge Semin
2022-05-12 15:23 ` Manivannan Sadhasivam
2022-05-12 17:38 ` Serge Semin
2022-05-03 22:51 ` [PATCH v2 25/26] PCI: dwc: Add generic iATU/eDMA CSRs space detection method Serge Semin
2022-05-03 22:51 ` [PATCH v2 26/26] PCI: dwc: Add DW eDMA engine support Serge Semin
2022-05-12 14:11 ` [PATCH v2 00/26] dmaengine: dw-edma: Add RP/EP local DMA controllers support Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512151734.GK35848@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Frank.Li@nxp.com \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=bhelgaas@google.com \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).