From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11EFFC04A95 for ; Tue, 25 Oct 2022 07:59:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229455AbiJYH7m (ORCPT ); Tue, 25 Oct 2022 03:59:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231390AbiJYH7k (ORCPT ); Tue, 25 Oct 2022 03:59:40 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E77325CE for ; Tue, 25 Oct 2022 00:59:37 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id s22-20020a17090a075600b002130d2ad62aso4380989pje.2 for ; Tue, 25 Oct 2022 00:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=cMUESaRlILiaSWwbpZuVWrzmIieCVjRDSyCQWGc52qc=; b=K1WGVUEUAjRGEDecQJUkXGvrVKFuMpNXHZfEo+T64wtofDcgZTkKf9/zk+Nm42YjPH uLWiltD2Yqlt0PrPaRsvVYOpGDPHPXFwVNCoZp+2kmVjYP1S7ZMAWcUDpDefvkw3vxCo oCnyumVsRs1uk7TfTNzSzNLAsj9aglxXYSxnhCKvmVJhF3MzIu8Yg31gA3wBwU9RkP+c ikJlzHrO0esHUkhCrd+6Dk5jO2bFni18OuIICnaTz12GrRIYLmR+XojT70M077V9NWjs FlKg8QJQtsRGgE2cFhStmE4XEg9TF+z72JUBCLZmhltPXqZ+l5O/0lxleo1/dkZFhXDj 2gRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cMUESaRlILiaSWwbpZuVWrzmIieCVjRDSyCQWGc52qc=; b=Ocz5uAxOxWGwEDntAMDFkTwfeaX46Fry8sZfpXF+4vvxVqHu61NCpuKEy0xItjXpdf 4KKiVdd6Qk6voAqSsy9oeDuWp9eB4l9TBppNxPEr7LMm+BhbmOFmhO0HEWMBe/Vifpwc x69eryK5nJwe/XhXWv12BntTv6mDLLQkzJ+GWNg2sMvxou6mlMVAvHUi/OVEcZs9MdU+ NiNnAGGP2J9L222WE3pYq1zEWHgs9oCenD+imQfbC47IyABzMqsZxOyLoj0s0RIrPUjm Z8/y3dLGzQ1yHgO5UfRfrpXPMgrwRVJsVz2wbyYrWSnkQBGU6T9Wym2DoJn456pJWJZO AAFA== X-Gm-Message-State: ACrzQf0Vr6wf4IxpvCnALiJrcBKiP2pRTQuNttVnfgyTkZ71dkvyT8Hl jueefHXzfLHvu5UUMXIIVPOS X-Google-Smtp-Source: AMsMyM4MfcpJpHJgKg4DNjFnqy2evZXRi10iSPyt9sQmowEhgrwDYbpGxSaO0VypGb/OUGNyDRB1/A== X-Received: by 2002:a17:90b:380b:b0:20d:7364:796f with SMTP id mq11-20020a17090b380b00b0020d7364796fmr41812019pjb.13.1666684777244; Tue, 25 Oct 2022 00:59:37 -0700 (PDT) Received: from thinkpad ([117.193.211.146]) by smtp.gmail.com with ESMTPSA id x23-20020aa78f17000000b0056baca45977sm908046pfr.21.2022.10.25.00.59.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 00:59:36 -0700 (PDT) Date: Tue, 25 Oct 2022 13:29:30 +0530 From: Manivannan Sadhasivam To: Serge Semin Cc: Gustavo Pimentel , Vinod Koul , Rob Herring , Bjorn Helgaas , Lorenzo Pieralisi , Jingoo Han , Frank Li , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND v5 00/24] dmaengine: dw-edma: Add RP/EP local DMA controllers support Message-ID: <20221025075930.GB221610@thinkpad> References: <20220822185332.26149-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220822185332.26149-1-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Mon, Aug 22, 2022 at 09:53:08PM +0300, Serge Semin wrote: > This is a final patchset in the series created in the framework of > my Baikal-T1 PCIe/eDMA-related work: > > [1: Done v5] PCI: dwc: Various fixes and cleanups > Link: https://lore.kernel.org/linux-pci/20220624143428.8334-1-Sergey.Semin@baikalelectronics.ru/ > Merged: kernel 6.0-rc1 > [2: Done v4] PCI: dwc: Add hw version and dma-ranges support > Link: https://lore.kernel.org/linux-pci/20220624143947.8991-1-Sergey.Semin@baikalelectronics.ru > Merged: kernel 6.0-rc1 > [3: In-review v5] PCI: dwc: Add generic resources and Baikal-T1 support > Link: https://lore.kernel.org/linux-pci/20220822184701.25246-1-Sergey.Semin@baikalelectronics.ru/ > [4: Done v5] dmaengine: dw-edma: Add RP/EP local DMA support > Link: ---you are looking at it--- > > Note it is very recommended to merge the patchsets in the same order as > they are listed in the set above in order to have them applied smoothly. > Nothing prevents them from being reviewed synchronously though. > > Please note originally this series was self content, but due to Frank > being a bit faster in his work submission I had to rebase my patchset onto > his one. So now this patchset turns to be dependent on the Frank' work: > > Link: https://lore.kernel.org/linux-pci/20220524152159.2370739-1-Frank.Li@nxp.com/ > > Here is a short summary regarding this patchset. The series starts with > fixes patches. We discovered that the dw-edma-pcie.c driver incorrectly > initializes the LL/DT base addresses for the platforms with not matching > CPU and PCIe memory spaces. It is fixed by using the pci_bus_address() > method to get a correct base address. After that you can find a series of > the interleaved xfers fixes. It turned out the interleaved transfers > implementation didn't work quite correctly from the very beginning for > instance missing src/dst addresses initialization, etc. In the framework > of the next two patches we suggest to add a new platform-specific > callback - pci_address() and use it to convert the CPU address to the PCIe > space address. It is at least required for the DW eDMA remote End-point > setup on the platforms with not-matching CPU/PCIe address spaces. In case > of the DW eDMA local RP/EP setup the conversion will be done automatically > by the outbound iATU (if no DMA-bypass flag is specified for the > corresponding iATU window). Then we introduce a set of the patches to make > the DebugFS part of the code supporting the multi-eDMA controllers > platforms. It starts with several cleanup patches and is closed joining > the Read/Write channels into a single DMA-device as they originally should > have been. After that you can find the patches with adding the non-atomic > io-64 methods usage, dropping DT-region descriptors allocation, replacing > chip IDs with the device name. In addition to that in order to have the > eDMA embedded into the DW PCIe RP/EP supported we need to bypass the > dma-ranges-based memory ranges mapping since in case of the root port DT > node it's applicable for the peripheral PCIe devices only. Finally at the > series closure we introduce a generic DW eDMA controller support being > available in the DW PCIe Root Port/Endpoint driver. > Looks like this series still got stuck :( And most of the discussion is with patch 22/24 and it is for the Baikal platform (at present) I believe. There is also a discussion on 24/24, but that's not a big deal as 22/24. Can we exclude the patch 22/24 (even 24/24 if required) and merge rest in the meantime. The patch(es) can still be submitted separately and merged after reaching consensus. Thanks, Mani > Link: https://lore.kernel.org/linux-pci/20220324014836.19149-1-Sergey.Semin@baikalelectronics.ru/ > Changelog v2: > - Drop the patches: > [PATCH 1/25] dmaengine: dw-edma: Drop dma_slave_config.direction field usage > [PATCH 2/25] dmaengine: dw-edma: Fix eDMA Rd/Wr-channels and DMA-direction semantics > since they are going to be merged in in the framework of the > Frank's patchset. > - Add a new patch: "dmaengine: dw-edma: Release requested IRQs on > failure." > - Drop __iomem qualifier from the struct dw_edma_debugfs_entry instance > definition in the dw_edma_debugfs_u32_get() method. (@Manivannan) > - Add a new patch: "dmaengine: dw-edma: Rename DebugFS dentry variables to > 'dent'." (@Manivannan) > - Slightly extend the eDMA name array size. (@Manivannan) > - Change the specific DMA mapping comment a bit to being > clearer. (@Manivannan) > - Add a new patch: "PCI: dwc: Add generic iATU/eDMA CSRs space detection > method." > - Don't fail eDMA detection procedure if the DW eDMA driver couldn't probe > device. That happens if the driver is disabled. (@Manivannan) > - Add "dma" registers resource mapping procedure. (@Manivannan) > - Move the eDMA CSRs space detection into the dw_pcie_map_detect() method. > - Remove eDMA on the dw_pcie_ep_init() internal errors. (@Manivannan) > - Remove eDMA in the dw_pcie_ep_exit() method. > - Move the dw_pcie_edma_detect() method execution to the tail of the > dw_pcie_ep_init() function. > > Link: https://lore.kernel.org/linux-pci/20220503225104.12108-1-Sergey.Semin@baikalelectronics.ru/ > Changelog v3: > - Conditionally set dchan->dev->device.dma_coherent field since it can > be missing on some platforms. (@Manivannan) > - Drop the patch: "PCI: dwc: Add generic iATU/eDMA CSRs space detection > method". A similar modification has been done in another patchset. > - Add more comprehensive and less regression prune eDMA block detection > procedure. > - Drop the patch: "dma-direct: take dma-ranges/offsets into account in > resource mapping". It will be separately reviewed. > - Remove Manivannan tb tag from the modified patches. > - Rebase onto the kernel v5.18. > > Link: https://lore.kernel.org/linux-pci/20220610091459.17612-1-Sergey.Semin@baikalelectronics.ru > Changelog v4: > - Rabase onto the laters Frank Li series: > Link: https://lore.kernel.org/all/20220524152159.2370739-1-Frank.Li@nxp.com/ > - Add Vinod' Ab-tag. > - Rebase onto the kernel v5.19-rcX. > > Link: https://lore.kernel.org/linux-pci/20220728142841.12305-1-Sergey.Semin@baikalelectronics.ru > Changelog v5: > - Just resend. > - Rebase onto the kernel v6.0-rc2. > > Signed-off-by: Serge Semin > Reviewed-by: Manivannan Sadhasivam > Acked-By: Vinod Koul > Cc: Alexey Malahov > Cc: Pavel Parkhomenko > Cc: "Krzysztof Wilczyński" > Cc: linux-pci@vger.kernel.org > Cc: dmaengine@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > > Serge Semin (24): > dmaengine: Fix dma_slave_config.dst_addr description > dmaengine: dw-edma: Release requested IRQs on failure > dmaengine: dw-edma: Convert ll/dt phys-address to PCIe bus/DMA address > dmaengine: dw-edma: Fix missing src/dst address of the interleaved > xfers > dmaengine: dw-edma: Don't permit non-inc interleaved xfers > dmaengine: dw-edma: Fix invalid interleaved xfers semantics > dmaengine: dw-edma: Add CPU to PCIe bus address translation > dmaengine: dw-edma: Add PCIe bus address getter to the remote EP > glue-driver > dmaengine: dw-edma: Drop chancnt initialization > dmaengine: dw-edma: Fix DebugFS reg entry type > dmaengine: dw-edma: Stop checking debugfs_create_*() return value > dmaengine: dw-edma: Add dw_edma prefix to the DebugFS nodes descriptor > dmaengine: dw-edma: Convert DebugFS descs to being kz-allocated > dmaengine: dw-edma: Rename DebugFS dentry variables to 'dent' > dmaengine: dw-edma: Simplify the DebugFS context CSRs init procedure > dmaengine: dw-edma: Move eDMA data pointer to DebugFS node descriptor > dmaengine: dw-edma: Join Write/Read channels into a single device > dmaengine: dw-edma: Use DMA-engine device DebugFS subdirectory > dmaengine: dw-edma: Use non-atomic io-64 methods > dmaengine: dw-edma: Drop DT-region allocation > dmaengine: dw-edma: Replace chip ID number with device name > dmaengine: dw-edma: Bypass dma-ranges mapping for the local setup > dmaengine: dw-edma: Skip cleanup procedure if no private data found > PCI: dwc: Add DW eDMA engine support > > drivers/dma/dw-edma/dw-edma-core.c | 216 +++++----- > drivers/dma/dw-edma/dw-edma-core.h | 10 +- > drivers/dma/dw-edma/dw-edma-pcie.c | 24 +- > drivers/dma/dw-edma/dw-edma-v0-core.c | 60 +-- > drivers/dma/dw-edma/dw-edma-v0-core.h | 1 - > drivers/dma/dw-edma/dw-edma-v0-debugfs.c | 372 ++++++++---------- > drivers/dma/dw-edma/dw-edma-v0-debugfs.h | 5 - > .../pci/controller/dwc/pcie-designware-ep.c | 12 +- > .../pci/controller/dwc/pcie-designware-host.c | 13 +- > drivers/pci/controller/dwc/pcie-designware.c | 186 +++++++++ > drivers/pci/controller/dwc/pcie-designware.h | 20 + > include/linux/dma/edma.h | 18 +- > include/linux/dmaengine.h | 2 +- > 13 files changed, 583 insertions(+), 356 deletions(-) > > -- > 2.35.1 > -- மணிவண்ணன் சதாசிவம்