From: Allen Pais <apais@linux.microsoft.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Vinod Koul <vkoul@kernel.org>,
olivier.dautricourt@orolia.com, sr@denx.de,
Kees Cook <keescook@chromium.org>,
linux-hardening@vger.kernel.org, ludovic.desroches@microchip.com,
tudor.ambarus@microchip.com, f.fainelli@gmail.com,
rjui@broadcom.com, sbranden@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, nsaenz@kernel.org,
paul@crapouillou.net, Eugeniy.Paltsev@synopsys.com,
gustavo.pimentel@synopsys.com, vireshk@kernel.org,
andriy.shevchenko@linux.intel.com, leoyang.li@nxp.com,
zw@zh-kernel.org, wangzhou1@hisilicon.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, sean.wang@mediatek.com,
matthias.bgg@gmail.com, afaerber@suse.de, mani@kernel.org,
logang@deltatee.com, sanju.mehta@amd.com, daniel@zonque.org,
haojian.zhuang@gmail.com, robert.jarzmik@free.fr,
agross@kernel.org, bjorn.andersson@linaro.org,
krzysztof.kozlowski@linaro.org, green.wan@sifive.com,
orsonzhai@gmail.com, baolin.wang7@gmail.com,
zhang.lyra@gmail.com, patrice.chotard@foss.st.com,
linus.walleij@linaro.org, wens@csie.org,
jernej.skrabec@gmail.com, samuel@sholland.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/1] drivers/dma/*: replace tasklets with workqueue
Date: Wed, 27 Apr 2022 08:58:52 -0700 [thread overview]
Message-ID: <27B51CB8-FCC0-49FB-AA28-93594943423E@linux.microsoft.com> (raw)
In-Reply-To: <e8cb3d63-f5b9-d067-af66-86f7a7c7f76c@intel.com>
>> On 19-04-22, 21:16, Allen Pais wrote:
>>> The tasklet is an old API which will be deprecated, workqueue API
>>> cab be used instead of them.
>> What is the reason for tasklet removal, I am not sure old is a reason to
>> remove an API...
>>
>>> This patch replaces the tasklet usage in drivers/dma/* with a
>>> simple work.
>> Dmaengines need very high throughput, one of the reasons in dmaengine
>> API design to use tasklet was higher priority given to them. Will the
>> workqueue allow that...?
>
> Wouldn't the logical move be to convert threaded irq IF tasklets are being deprecated rather than using workqueue as replacement?
Logically yes. Would all tasklets need to be moved to threaded irq, that I am not sure. I think
Workqueues does the job.
>
> Also, wouldn't all the spin_lock_bh() calls need to be changed to spin_lock_irqsave() now? Probably not as simple as just replace tasklet with workqueue.
>
Yes, this was carefully looked at as we have moved from the interrupt/softirq context to process context.
Thanks.
next prev parent reply other threads:[~2022-04-27 16:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 21:16 [RFC 0/1] refactor all tasklet users into other APIs Allen Pais
2022-04-19 21:16 ` [RFC 1/1] drivers/dma/*: replace tasklets with workqueue Allen Pais
2022-04-20 2:31 ` Kees Cook
2022-04-22 16:48 ` Allen Pais
2022-04-25 15:06 ` Linus Walleij
2022-04-25 23:59 ` Allen Pais
2022-04-25 15:56 ` Krzysztof Kozlowski
2022-04-25 19:55 ` Gustavo A. R. Silva
2022-04-28 9:29 ` Andy Shevchenko
[not found] ` <DA101ED8-F99F-4DCB-9CB7-370A62C44B65@linux.microsoft.com>
2022-05-12 21:54 ` Linus Walleij
2022-05-16 11:40 ` Vinod Koul
2022-04-26 0:04 ` Allen Pais
2022-04-27 2:45 ` Vinod Koul
2022-04-27 15:20 ` Dave Jiang
2022-04-27 15:58 ` Allen Pais [this message]
2022-04-27 15:53 ` Allen Pais
2022-05-25 9:24 ` Linus Walleij
2022-05-25 9:52 ` Vincent Guittot
2022-05-25 11:03 ` Arnd Bergmann
2022-05-25 15:14 ` David Laight
[not found] ` <6E248F41-6687-4F2B-B847-DB5459BA1344@linux.microsoft.com>
2022-05-25 17:48 ` Arnd Bergmann
2022-05-25 18:04 ` Allen Pais
2022-05-27 8:06 ` Vinod Koul
2022-05-27 10:59 ` Arnd Bergmann
2022-05-31 6:56 ` Vinod Koul
[not found] ` <0A9EDEDC-9E6C-47F8-89C0-48DCDD3F9DE3@linux.microsoft.com>
2022-05-31 18:02 ` Arnd Bergmann
2022-05-31 18:19 ` Allen Pais
2022-05-31 19:27 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27B51CB8-FCC0-49FB-AA28-93594943423E@linux.microsoft.com \
--to=apais@linux.microsoft.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=afaerber@suse.de \
--cc=agross@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baolin.wang7@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@zonque.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=green.wan@sifive.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=haojian.zhuang@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=keescook@chromium.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=ludovic.desroches@microchip.com \
--cc=mani@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nsaenz@kernel.org \
--cc=olivier.dautricourt@orolia.com \
--cc=orsonzhai@gmail.com \
--cc=patrice.chotard@foss.st.com \
--cc=paul@crapouillou.net \
--cc=rjui@broadcom.com \
--cc=robert.jarzmik@free.fr \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=sanju.mehta@amd.com \
--cc=sbranden@broadcom.com \
--cc=sean.wang@mediatek.com \
--cc=shawnguo@kernel.org \
--cc=sr@denx.de \
--cc=tudor.ambarus@microchip.com \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=wens@csie.org \
--cc=zhang.lyra@gmail.com \
--cc=zw@zh-kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).