From: Robin Murphy <robin.murphy@arm.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
linux-kernel@vger.kernel.org
Cc: linux-amarula@amarulasolutions.com,
Michael Trimarchi <michael@amarulasolutions.com>,
stable@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>, Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH v5 2/2] dmaengine: mxs: fix section mismatch
Date: Wed, 21 Sep 2022 10:35:42 +0100 [thread overview]
Message-ID: <2ce32413-d338-5032-71f1-7da183b2c561@arm.com> (raw)
In-Reply-To: <20220904141020.2947725-2-dario.binacchi@amarulasolutions.com>
On 2022-09-04 15:10, Dario Binacchi wrote:
> The patch was suggested by the following modpost warning:
>
> WARNING: modpost: vmlinux.o(.data+0xa3900): Section mismatch in reference from the variable mxs_dma_driver to the function .init.text:mxs_dma_probe()
> The variable mxs_dma_driver references
> the function __init mxs_dma_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
This is very wrong - even *with* platform_driver_probe(), the driver may
remain registered beyond init, so when the driver core walks the list
trying to match a driver for some other device later it can access freed
data and crash. Which is absolutely no fun to debug...
The correct fix is to remove the __init annotation from the probe
routine. If you want to support deferred probe, consider that even your
own probe call might potentially be delayed until after initdata is freed.
Thanks,
Robin.
> Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Cc: stable@vger.kernel.org
> ---
>
> (no changes since v1)
>
> drivers/dma/mxs-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
> index 18f8154b859b..a01953e06048 100644
> --- a/drivers/dma/mxs-dma.c
> +++ b/drivers/dma/mxs-dma.c
> @@ -834,7 +834,7 @@ static int __init mxs_dma_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static struct platform_driver mxs_dma_driver = {
> +static struct platform_driver mxs_dma_driver __initdata = {
> .driver = {
> .name = "mxs-dma",
> .of_match_table = mxs_dma_dt_ids,
next prev parent reply other threads:[~2022-09-21 9:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 14:10 [RESEND PATCH v5 1/2] dmaengine: mxs: use platform_driver_register Dario Binacchi
2022-09-04 14:10 ` [RESEND PATCH v5 2/2] dmaengine: mxs: fix section mismatch Dario Binacchi
2022-09-21 9:35 ` Robin Murphy [this message]
2022-09-13 16:35 ` [RESEND PATCH v5 1/2] dmaengine: mxs: use platform_driver_register Sascha Hauer
2022-09-20 17:10 ` Dario Binacchi
2022-09-21 3:23 ` Vinod Koul
2022-09-21 10:39 ` Sascha Hauer
2022-09-21 12:50 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2022-08-20 8:44 Dario Binacchi
2022-08-20 8:45 ` [RESEND PATCH v5 2/2] dmaengine: mxs: fix section mismatch Dario Binacchi
2022-07-28 6:18 [RESEND PATCH v5 1/2] dmaengine: mxs: use platform_driver_register Dario Binacchi
2022-07-28 6:18 ` [RESEND PATCH v5 2/2] dmaengine: mxs: fix section mismatch Dario Binacchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ce32413-d338-5032-71f1-7da183b2c561@arm.com \
--to=robin.murphy@arm.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).