From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0939EC433E7 for ; Mon, 31 Aug 2020 16:17:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DCAAA2073A for ; Mon, 31 Aug 2020 16:17:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=deltatee.com header.i=@deltatee.com header.b="JAaALqlm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727819AbgHaQRT (ORCPT ); Mon, 31 Aug 2020 12:17:19 -0400 Received: from ale.deltatee.com ([204.191.154.188]:51322 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726167AbgHaQRS (ORCPT ); Mon, 31 Aug 2020 12:17:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+VhhBoso0OeJQNeLxxGllDbQ4VsvPv92VaqWa6nzq9k=; b=JAaALqlmnjF5lknH8a65XJhzbX +GRXNALsTKK92io9vuHR96KCcmHfNPNTkcythokatyWLVlbXStrAyw8HyZf7kG5I23xOceo7Vp5ih ct6GYXmycdyiOsFY3zcHp9oax0GDZcaGBGaZzS+CUsjxyyJN2Nclo0rfaTxV//Q7ichyKuwF9SGB/ 5Rsli7MutqQf5cBO0bXARzxOVkY2G0229zmnb4FV+vR5X1SNCOO8WsJET4JWI55wpMII6OUEoEOO9 yNP01SsEOz2wSLS0I3kh4CKLHmPfOt23O5vqJ7w8X9mnL1/vtzKZ83QqWiw2DJzVTC/f34nj+bgJA /Qv9jVHw==; Received: from [172.16.1.162] by ale.deltatee.com with esmtp (Exim 4.92) (envelope-from ) id 1kCmUe-0000ts-QR; Mon, 31 Aug 2020 10:17:17 -0600 To: Allen Cc: Vinod Koul , Linus Walleij , vireshk@kernel.org, leoyang.li@nxp.com, zw@zh-kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, sean.wang@mediatek.com, matthias.bgg@gmail.com, agross@kernel.org, jorn.andersson@linaro.org, green.wan@sifive.com, baohua@kernel.org, mripard@kernel.org, wens@csie.org, dmaengine@vger.kernel.org References: <20200831103542.305571-1-allen.lkml@gmail.com> <20200831103542.305571-34-allen.lkml@gmail.com> <9368c823-4240-4d86-879c-6dae662a36e4@deltatee.com> From: Logan Gunthorpe Message-ID: <3247010a-2592-8d7e-8142-d267627d096d@deltatee.com> Date: Mon, 31 Aug 2020 10:17:14 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: dmaengine@vger.kernel.org, wens@csie.org, mripard@kernel.org, baohua@kernel.org, green.wan@sifive.com, jorn.andersson@linaro.org, agross@kernel.org, matthias.bgg@gmail.com, sean.wang@mediatek.com, s.hauer@pengutronix.de, shawnguo@kernel.org, zw@zh-kernel.org, leoyang.li@nxp.com, vireshk@kernel.org, linus.walleij@linaro.org, vkoul@kernel.org, allen.lkml@gmail.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v3 33/35] dmaengine: plx_dma: convert tasklets to use new tasklet_setup() API X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 2020-08-31 9:56 a.m., Allen wrote: > Logan, >>> In preparation for unconditionally passing the >>> struct tasklet_struct pointer to all tasklet >>> callbacks, switch to using the new tasklet_setup() >>> and from_tasklet() to pass the tasklet pointer explicitly. >>> >>> Signed-off-by: Allen Pais >>> --- >>> drivers/dma/plx_dma.c | 7 +++---- >>> 1 file changed, 3 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c >>> index db4c5fd453a9..f387c5bbc170 100644 >>> --- a/drivers/dma/plx_dma.c >>> +++ b/drivers/dma/plx_dma.c >>> @@ -241,9 +241,9 @@ static void plx_dma_stop(struct plx_dma_dev *plxdev) >>> rcu_read_unlock(); >>> } >>> >>> -static void plx_dma_desc_task(unsigned long data) >>> +static void plx_dma_desc_task(struct tasklet_struct *t) >>> { >>> - struct plx_dma_dev *plxdev = (void *)data; >>> + struct plx_dma_dev *plxdev = from_tasklet(plxdev, t, desc_task); >> >> The discussion I saw on another thread suggested the private macro >> from_tasklet() would be replaced with something generic. So isn't this >> patchset a bit premature? > > Yes, but efforts to replace it with something generic was not well accepted. > We were left with either using a private macro from_tasklet() or use > well known container_of(). I have left it to the maintainers to decide > which one they prefer. Well my vote would be for using container_of() directly. But I don't really have much clout here. Logan