From: dinghao.liu@zju.edu.cn
To: "Jon Hunter" <jonathanh@nvidia.com>
Cc: kjlu@umn.edu, "Laxman Dewangan" <ldewangan@nvidia.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH] dmaengine: tegra210-adma: Fix runtime PM imbalance on error
Date: Fri, 22 May 2020 18:57:18 +0800 (GMT+08:00) [thread overview]
Message-ID: <45d18e3c.bfdab.1723c07b7d3.Coremail.dinghao.liu@zju.edu.cn> (raw)
In-Reply-To: <967c17d2-6b57-27f0-7762-cd0835caaec9@nvidia.com>
>
> On 22/05/2020 08:58, Dinghao Liu wrote:
> > pm_runtime_get_sync() increments the runtime PM usage counter even
> > when it returns an error code. Thus a pairing decrement is needed on
> > the error handling path to keep the counter balanced.
> >
> > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> > ---
> > drivers/dma/tegra210-adma.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> > index c4ce5dfb149b..803e1f4d5dac 100644
> > --- a/drivers/dma/tegra210-adma.c
> > +++ b/drivers/dma/tegra210-adma.c
> > @@ -658,6 +658,7 @@ static int tegra_adma_alloc_chan_resources(struct dma_chan *dc)
> >
> > ret = pm_runtime_get_sync(tdc2dev(tdc));
> > if (ret < 0) {
> > + pm_runtime_put_sync(tdc2dev(tdc));
> > free_irq(tdc->irq, tdc);
> > return ret;
> > }
> >
>
>
> There is another place in probe that needs to be fixed as well. Can you
> correct this while you are at it?
>
> Thanks
> Jon
>
> --
> nvpublic
Sure. I have sent a patch to fix PM imbalance in tegra_adma_probe().
Regards,
Dinghao
next prev parent reply other threads:[~2020-05-22 10:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 7:58 [PATCH] dmaengine: tegra210-adma: Fix runtime PM imbalance on error Dinghao Liu
2020-05-22 10:43 ` Jon Hunter
2020-05-22 10:57 ` dinghao.liu [this message]
2020-05-22 11:27 ` Jon Hunter
2020-05-22 11:32 ` dinghao.liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45d18e3c.bfdab.1723c07b7d3.Coremail.dinghao.liu@zju.edu.cn \
--to=dinghao.liu@zju.edu.cn \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kjlu@umn.edu \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).