From: Dave Jiang <dave.jiang@intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
Subject: Re: [PATCH -next] dmaengine: idxd: fix PCI_MSI build errors
Date: Tue, 14 Jul 2020 07:58:09 -0700 [thread overview]
Message-ID: <46ae481e-3213-f1e0-604b-177bc876bb93@intel.com> (raw)
In-Reply-To: <9dee3f46-70d9-ea75-10cb-5527ab297d1d@infradead.org>
On 7/13/2020 11:35 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors when CONFIG_PCI_MSI is not enabled by making the
> driver depend on PCI_MSI:
>
> ld: drivers/dma/idxd/device.o: in function `idxd_mask_msix_vector':
> device.c:(.text+0x26f): undefined reference to `pci_msi_mask_irq'
> ld: drivers/dma/idxd/device.o: in function `idxd_unmask_msix_vector':
> device.c:(.text+0x2af): undefined reference to `pci_msi_unmask_irq'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: dmaengine@vger.kernel.org
> Cc: Vinod Koul <vkoul@kernel.org>
Vinod, I submitted this fix patch last week:
https://patchwork.kernel.org/patch/11649231/
But I think maybe Randy's patch may be more preferable? You can apply this one
and ignore my submission.
> ---
> drivers/dma/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- mmotm-2020-0713-1949.orig/drivers/dma/Kconfig
> +++ mmotm-2020-0713-1949/drivers/dma/Kconfig
> @@ -285,6 +285,7 @@ config INTEL_IDMA64
> config INTEL_IDXD
> tristate "Intel Data Accelerators support"
> depends on PCI && X86_64
> + depends on PCI_MSI
> depends on SBITMAP
> select DMA_ENGINE
> help
>
>
next prev parent reply other threads:[~2020-07-14 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 6:35 [PATCH -next] dmaengine: idxd: fix PCI_MSI build errors Randy Dunlap
2020-07-14 14:58 ` Dave Jiang [this message]
2020-07-15 6:03 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46ae481e-3213-f1e0-604b-177bc876bb93@intel.com \
--to=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).