dmaengine Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] dmaengine: dw-edma: Fix build error without CONFIG_PCI_MSI
@ 2019-06-12  4:18 YueHaibing
  2019-06-12  4:21 ` Yuehaibing
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-06-12  4:18 UTC (permalink / raw)
  To: gustavo.pimentel, vkoul, dan.j.williams
  Cc: linux-kernel, dmaengine, YueHaibing

If CONFIG_PCI_MSI is not set, building with CONFIG_DW_EDMA
fails:

drivers/dma/dw-edma/dw-edma-core.c: In function dw_edma_irq_request:
drivers/dma/dw-edma/dw-edma-core.c:784:21: error: implicit declaration of function pci_irq_vector; did you mean rcu_irq_enter? [-Werror=implicit-function-declaration]
   err = request_irq(pci_irq_vector(to_pci_dev(dev), 0),
                     ^~~~~~~~~~~~~~

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: e63d79d1ffcd ("dmaengine: Add Synopsys eDMA IP core driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/dma/dw-edma/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/dw-edma/Kconfig b/drivers/dma/dw-edma/Kconfig
index c0838ce..7ff17b2 100644
--- a/drivers/dma/dw-edma/Kconfig
+++ b/drivers/dma/dw-edma/Kconfig
@@ -2,6 +2,7 @@
 
 config DW_EDMA
 	tristate "Synopsys DesignWare eDMA controller driver"
+	depends on PCI && PCI_MSI
 	select DMA_ENGINE
 	select DMA_VIRTUAL_CHANNELS
 	help
-- 
2.7.4



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] dmaengine: dw-edma: Fix build error without CONFIG_PCI_MSI
  2019-06-12  4:18 [PATCH] dmaengine: dw-edma: Fix build error without CONFIG_PCI_MSI YueHaibing
@ 2019-06-12  4:21 ` Yuehaibing
  0 siblings, 0 replies; 2+ messages in thread
From: Yuehaibing @ 2019-06-12  4:21 UTC (permalink / raw)
  To: gustavo.pimentel, vkoul, dan.j.williams; +Cc: linux-kernel, dmaengine

Pls ignore this, will fix patch title and resend

On 2019/6/12 12:18, YueHaibing wrote:
> If CONFIG_PCI_MSI is not set, building with CONFIG_DW_EDMA
> fails:
> 
> drivers/dma/dw-edma/dw-edma-core.c: In function dw_edma_irq_request:
> drivers/dma/dw-edma/dw-edma-core.c:784:21: error: implicit declaration of function pci_irq_vector; did you mean rcu_irq_enter? [-Werror=implicit-function-declaration]
>    err = request_irq(pci_irq_vector(to_pci_dev(dev), 0),
>                      ^~~~~~~~~~~~~~
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: e63d79d1ffcd ("dmaengine: Add Synopsys eDMA IP core driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/dma/dw-edma/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/dw-edma/Kconfig b/drivers/dma/dw-edma/Kconfig
> index c0838ce..7ff17b2 100644
> --- a/drivers/dma/dw-edma/Kconfig
> +++ b/drivers/dma/dw-edma/Kconfig
> @@ -2,6 +2,7 @@
>  
>  config DW_EDMA
>  	tristate "Synopsys DesignWare eDMA controller driver"
> +	depends on PCI && PCI_MSI
>  	select DMA_ENGINE
>  	select DMA_VIRTUAL_CHANNELS
>  	help
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-12  4:18 [PATCH] dmaengine: dw-edma: Fix build error without CONFIG_PCI_MSI YueHaibing
2019-06-12  4:21 ` Yuehaibing

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org dmaengine@archiver.kernel.org
	public-inbox-index dmaengine


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/ public-inbox