From: Stefan Roese <sr@denx.de>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, Sinan Kaya <okaya@codeaurora.org>,
Green Wan <green.wan@sifive.com>,
Hyun Kwon <hyun.kwon@xilinx.com>,
Tejas Upadhyay <tejasu@xilinx.com>,
Michal Simek <michal.simek@xilinx.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 1/4] DMA: ALTERA_MSGDMA depends on HAS_IOMEM
Date: Sat, 22 May 2021 09:21:24 +0200 [thread overview]
Message-ID: <4fde705b-6d57-ba73-e7d6-63beb690117e@denx.de> (raw)
In-Reply-To: <20210522021313.16405-2-rdunlap@infradead.org>
On 22.05.21 04:13, Randy Dunlap wrote:
> When CONFIG_HAS_IOMEM is not set/enabled, certain iomap() family
> functions [including ioremap(), devm_ioremap(), etc.] are not
> available.
> Drivers that use these functions should depend on HAS_IOMEM so that
> they do not cause build errors.
>
> Repairs this build error:
> s390-linux-ld: drivers/dma/altera-msgdma.o: in function `request_and_map':
> altera-msgdma.c:(.text+0x14b0): undefined reference to `devm_ioremap'
>
> Fixes: a85c6f1b2921 ("dmaengine: Add driver for Altera / Intel mSGDMA IP core")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: dmaengine@vger.kernel.org
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> drivers/dma/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210521.orig/drivers/dma/Kconfig
> +++ linux-next-20210521/drivers/dma/Kconfig
> @@ -59,6 +59,7 @@ config DMA_OF
> #devices
> config ALTERA_MSGDMA
> tristate "Altera / Intel mSGDMA Engine"
> + depends on HAS_IOMEM
> select DMA_ENGINE
> help
> Enable support for Altera / Intel mSGDMA controller.
>
Viele Grüße,
Stefan
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
next prev parent reply other threads:[~2021-05-22 7:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 2:13 [PATCH 0/4] DMA: several drivers depend on HAS_IOMEM Randy Dunlap
2021-05-22 2:13 ` [PATCH 1/4] DMA: ALTERA_MSGDMA depends " Randy Dunlap
2021-05-22 7:21 ` Stefan Roese [this message]
2021-05-22 2:13 ` [PATCH 2/4] DMA: QCOM_HIDMA_MGMT " Randy Dunlap
2021-05-22 2:13 ` [PATCH 3/4] DMA: SF_PDMA " Randy Dunlap
2021-05-22 2:13 ` [PATCH 4/4] DMA: XILINX_ZYNQMP_DPDMA " Randy Dunlap
2021-05-23 0:20 ` Laurent Pinchart
2021-05-23 1:07 ` Randy Dunlap
2021-05-23 18:53 ` Laurent Pinchart
2021-05-23 19:08 ` Randy Dunlap
2021-05-31 4:12 ` Vinod Koul
2021-05-31 4:14 ` [PATCH 0/4] DMA: several drivers depend " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fde705b-6d57-ba73-e7d6-63beb690117e@denx.de \
--to=sr@denx.de \
--cc=dmaengine@vger.kernel.org \
--cc=green.wan@sifive.com \
--cc=hyun.kwon@xilinx.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=michal.simek@xilinx.com \
--cc=okaya@codeaurora.org \
--cc=rdunlap@infradead.org \
--cc=tejasu@xilinx.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).