dmaengine.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin Tůma" <tumic@gpxsee.org>
To: Lizhi Hou <lizhi.hou@amd.com>,
	vkoul@kernel.org, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: max.zhen@amd.com, sonal.santan@amd.com, larry.liu@amd.com,
	brian.xu@amd.com
Subject: Re: [PATCH V12 XDMA 0/2] xilinx XDMA driver
Date: Fri, 20 Jan 2023 13:20:44 +0100	[thread overview]
Message-ID: <5fbe6029-61d5-bba4-556b-2282153f21dc@gpxsee.org> (raw)
In-Reply-To: <1674145926-29449-1-git-send-email-lizhi.hou@amd.com>

On 19. 01. 23 17:32, Lizhi Hou wrote:
> Hello,
> 
> This V12 of patch series is to provide the platform driver to support the
> Xilinx XDMA subsystem. The XDMA subsystem is used in conjunction with the
> PCI Express IP block to provide high performance data transfer between host
> memory and the card's DMA subsystem. It also provides up to 16 user
> interrupt wires to user logic that generate interrupts to the host.
> 
>              +-------+       +-------+       +-----------+
>     PCIe     |       |       |       |       |           |
>     Tx/Rx    |       |       |       |  AXI  |           |
>   <=======>  | PCIE  | <===> | XDMA  | <====>| User Logic|
>              |       |       |       |       |           |
>              +-------+       +-------+       +-----------+
> 
> The XDMA has been used for Xilinx Alveo PCIe devices.
> And it is also integrated into Versal ACAP DMA and Bridge Subsystem.
>      https://www.xilinx.com/products/boards-and-kits/alveo.html
>      https://docs.xilinx.com/r/en-US/pg344-pcie-dma-versal/Introduction-to-the-DMA-and-Bridge-Subsystems
> 
> The device driver for any FPGA based PCIe device which leverages XDMA can
> call the standard dmaengine APIs to discover and use the XDMA subsystem
> without duplicating the XDMA driver code in its own driver.
> 
> Changes since v11:
> - minor fixes based on review comments.
> 
> Changes since v10:
> - Added Tested-by Martin Tuma tumic@gpxsee.org
> 
> Changes since v9:
> - Cleanup code based on review comments.
> 
> Changes since v8:
> - Fixed test robot failure on s390.
> 
> Changes since v7:
> - Used pci device pointer for dma_pool_create().
> 
> Changes since v6:
> - Fixed descriptor filling bug.
> 
> Changes since v5:
> - Modified user logic interrupt APIs to handle user logic IP which does not
>    have its own register to enable/disable interrupt.
> - Clean up code based on review comments.
> 
> Changes since v4:
> - Modified user logic interrupt APIs.
> 
> Changes since v3:
> - Added one patch to support user logic interrupt.
> 
> Changes since v2:
> - Removed tasklet.
> - Fixed regression bug introduced to V2.
> - Test Robot warning.
> 
> Changes since v1:
> - Moved filling hardware descriptor to xdma_prep_device_sg().
> - Changed hardware descriptor enum to "struct xdma_hw_desc".
> - Minor changes from code review comments.
> 
> Lizhi Hou (2):
>    dmaengine: xilinx: xdma: Add xilinx xdma driver
>    dmaengine: xilinx: xdma: Add user logic interrupt support
> 
>   MAINTAINERS                            |  11 +
>   drivers/dma/Kconfig                    |  14 +
>   drivers/dma/xilinx/Makefile            |   1 +
>   drivers/dma/xilinx/xdma-regs.h         | 166 +++++
>   drivers/dma/xilinx/xdma.c              | 974 +++++++++++++++++++++++++
>   include/linux/dma/amd_xdma.h           |  16 +
>   include/linux/platform_data/amd_xdma.h |  34 +
>   7 files changed, 1216 insertions(+)
>   create mode 100644 drivers/dma/xilinx/xdma-regs.h
>   create mode 100644 drivers/dma/xilinx/xdma.c
>   create mode 100644 include/linux/dma/amd_xdma.h
>   create mode 100644 include/linux/platform_data/amd_xdma.h
> 

I have re-tested this (v12) driver version on our mgb4 PCIe card and 
everything seems to work fine.

M.


  parent reply	other threads:[~2023-01-20 12:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 16:32 [PATCH V12 XDMA 0/2] xilinx XDMA driver Lizhi Hou
2023-01-19 16:32 ` [PATCH V12 XDMA 1/2] dmaengine: xilinx: xdma: Add xilinx xdma driver Lizhi Hou
2023-01-19 16:32 ` [PATCH V12 XDMA 2/2] dmaengine: xilinx: xdma: Add user logic interrupt support Lizhi Hou
2023-01-20 12:20 ` Martin Tůma [this message]
2023-02-10  6:03 ` [PATCH V12 XDMA 0/2] xilinx XDMA driver Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5fbe6029-61d5-bba4-556b-2282153f21dc@gpxsee.org \
    --to=tumic@gpxsee.org \
    --cc=brian.xu@amd.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=larry.liu@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizhi.hou@amd.com \
    --cc=max.zhen@amd.com \
    --cc=sonal.santan@amd.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).