Re: [PATCH 2/4] dmaengine: move struct in interface to use peripheral term

[Peter Ujfalusi <peter.ujfalusi@ti.com>]

Hi Vinod,

one minor comment...

On 15/10/2020 10.31, Vinod Koul wrote:
> dmaengine history has a non inclusive terminology of dmaengine slave, I
> feel it is time to replace that.
> 
> This moves structures in dmaengine interface with replacement of slave
> to peripheral which is an appropriate term for dmaengine peripheral
> devices
> 
> Since the change of name can break users, the new names have been added
> with old structs kept as macro define for new names. Once the users have
> been migrated, these macros will be dropped.
> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>

...

> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index f7f420876d21..04b993a5373c 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h

...

>  /**
> - * struct dma_slave_map - associates slave device and it's slave channel with
> + * struct dma_peripheral_map - associates peripheral device and it's peripheral channel with
>   * parameter to be used by a filter function
>   * @devname: name of the device
> - * @slave: slave channel name
> + * @peripheral: peripheral channel name

I know that this is slave -> peripheral change, but would not be better
to call this as 'channame'?

>   * @param: opaque parameter to pass to struct dma_filter.fn
>   */
> -struct dma_slave_map {
> +struct dma_peripheral_map {
>  	const char *devname;
> -	const char *slave;
> +	const char *peripheral;
>  	void *param;
>  };
>  
> +#define dma_slave_map dma_peripheral_map
> +

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki