dmaengine Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] dma: ti: unexport filter functions
@ 2019-08-12  9:36 Arnd Bergmann
  2019-08-12 10:06 ` Stephen Rothwell
  2019-08-12 10:10 ` Peter Ujfalusi
  0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2019-08-12  9:36 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Arnd Bergmann, Stephen Rothwell, Peter Ujfalusi, dmaengine, linux-kernel

The two filter functions are now marked stable, but still exported,
which triggers a coming build-time check:

WARNING: "omap_dma_filter_fn" [vmlinux] is a static EXPORT_SYMBOL_GPL
WARNING: "edma_filter_fn" [vmlinux] is a static EXPORT_SYMBOL

Remove the unneeded exports as well, as originally intended.

Fixes: 9c71b9eb3cb2 ("dmaengine: omap-dma: make omap_dma_filter_fn private")
Fixes: d2bfe7b5d182 ("dmaengine: edma: make edma_filter_fn private")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/dma/ti/edma.c     | 1 -
 drivers/dma/ti/omap-dma.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
index f2549ee3fb49..ea028388451a 100644
--- a/drivers/dma/ti/edma.c
+++ b/drivers/dma/ti/edma.c
@@ -2540,7 +2540,6 @@ static bool edma_filter_fn(struct dma_chan *chan, void *param)
 	}
 	return match;
 }
-EXPORT_SYMBOL(edma_filter_fn);
 
 static int edma_init(void)
 {
diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c
index 49da402a1927..98b39bcb7b37 100644
--- a/drivers/dma/ti/omap-dma.c
+++ b/drivers/dma/ti/omap-dma.c
@@ -1652,7 +1652,6 @@ static bool omap_dma_filter_fn(struct dma_chan *chan, void *param)
 	}
 	return false;
 }
-EXPORT_SYMBOL_GPL(omap_dma_filter_fn);
 
 static int omap_dma_init(void)
 {
-- 
2.20.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dma: ti: unexport filter functions
  2019-08-12  9:36 [PATCH] dma: ti: unexport filter functions Arnd Bergmann
@ 2019-08-12 10:06 ` Stephen Rothwell
  2019-08-12 10:10 ` Peter Ujfalusi
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2019-08-12 10:06 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: Vinod Koul, Peter Ujfalusi, dmaengine, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

Hi Arnd,

Just a nit.

On Mon, 12 Aug 2019 11:36:03 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
>
> The two filter functions are now marked stable, but still exported,
                                          ^^^^^^
static ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dma: ti: unexport filter functions
  2019-08-12  9:36 [PATCH] dma: ti: unexport filter functions Arnd Bergmann
  2019-08-12 10:06 ` Stephen Rothwell
@ 2019-08-12 10:10 ` Peter Ujfalusi
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Ujfalusi @ 2019-08-12 10:10 UTC (permalink / raw)
  To: Arnd Bergmann, Vinod Koul; +Cc: Stephen Rothwell, dmaengine, linux-kernel



On 12/08/2019 12.36, Arnd Bergmann wrote:
> The two filter functions are now marked stable, but still exported,
> which triggers a coming build-time check:
> 
> WARNING: "omap_dma_filter_fn" [vmlinux] is a static EXPORT_SYMBOL_GPL
> WARNING: "edma_filter_fn" [vmlinux] is a static EXPORT_SYMBOL
> 
> Remove the unneeded exports as well, as originally intended.
> 
> Fixes: 9c71b9eb3cb2 ("dmaengine: omap-dma: make omap_dma_filter_fn private")
> Fixes: d2bfe7b5d182 ("dmaengine: edma: make edma_filter_fn private")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> ---
>  drivers/dma/ti/edma.c     | 1 -
>  drivers/dma/ti/omap-dma.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
> index f2549ee3fb49..ea028388451a 100644
> --- a/drivers/dma/ti/edma.c
> +++ b/drivers/dma/ti/edma.c
> @@ -2540,7 +2540,6 @@ static bool edma_filter_fn(struct dma_chan *chan, void *param)
>  	}
>  	return match;
>  }
> -EXPORT_SYMBOL(edma_filter_fn);
>  
>  static int edma_init(void)
>  {
> diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c
> index 49da402a1927..98b39bcb7b37 100644
> --- a/drivers/dma/ti/omap-dma.c
> +++ b/drivers/dma/ti/omap-dma.c
> @@ -1652,7 +1652,6 @@ static bool omap_dma_filter_fn(struct dma_chan *chan, void *param)
>  	}
>  	return false;
>  }
> -EXPORT_SYMBOL_GPL(omap_dma_filter_fn);
>  
>  static int omap_dma_init(void)
>  {
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-12  9:36 [PATCH] dma: ti: unexport filter functions Arnd Bergmann
2019-08-12 10:06 ` Stephen Rothwell
2019-08-12 10:10 ` Peter Ujfalusi

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org dmaengine@archiver.kernel.org
	public-inbox-index dmaengine


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/ public-inbox