dmaengine Archive on lore.kernel.org
 help / color / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Barry Song <song.bao.hua@hisilicon.com>, <vkoul@kernel.org>,
	<dmaengine@vger.kernel.org>
Subject: Re: [PATCH 02/10] dmaengine: k3-udma: remove redundant irqsave and irqrestore in hardIRQ
Date: Mon, 19 Oct 2020 16:45:06 +0300
Message-ID: <6a4beeb9-3473-9655-5004-41ea8958b855@ti.com> (raw)
In-Reply-To: <20201015235921.21224-3-song.bao.hua@hisilicon.com>



On 16/10/2020 2.59, Barry Song wrote:
> Running in hardIRQ, disabling IRQ is redundant.

Subject should be: dmaengine: ti: k3-udma: ...

Other than that:
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
> ---
>  drivers/dma/ti/k3-udma.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index 82cf6c77f5c9..e508280b3d70 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -1020,13 +1020,12 @@ static irqreturn_t udma_ring_irq_handler(int irq, void *data)
>  {
>  	struct udma_chan *uc = data;
>  	struct udma_desc *d;
> -	unsigned long flags;
>  	dma_addr_t paddr = 0;
>  
>  	if (udma_pop_from_ring(uc, &paddr) || !paddr)
>  		return IRQ_HANDLED;
>  
> -	spin_lock_irqsave(&uc->vc.lock, flags);
> +	spin_lock(&uc->vc.lock);
>  
>  	/* Teardown completion message */
>  	if (cppi5_desc_is_tdcm(paddr)) {
> @@ -1077,7 +1076,7 @@ static irqreturn_t udma_ring_irq_handler(int irq, void *data)
>  		}
>  	}
>  out:
> -	spin_unlock_irqrestore(&uc->vc.lock, flags);
> +	spin_unlock(&uc->vc.lock);
>  
>  	return IRQ_HANDLED;
>  }
> @@ -1086,9 +1085,8 @@ static irqreturn_t udma_udma_irq_handler(int irq, void *data)
>  {
>  	struct udma_chan *uc = data;
>  	struct udma_desc *d;
> -	unsigned long flags;
>  
> -	spin_lock_irqsave(&uc->vc.lock, flags);
> +	spin_lock(&uc->vc.lock);
>  	d = uc->desc;
>  	if (d) {
>  		d->tr_idx = (d->tr_idx + 1) % d->sglen;
> @@ -1103,7 +1101,7 @@ static irqreturn_t udma_udma_irq_handler(int irq, void *data)
>  		}
>  	}
>  
> -	spin_unlock_irqrestore(&uc->vc.lock, flags);
> +	spin_unlock(&uc->vc.lock);
>  
>  	return IRQ_HANDLED;
>  }
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

  reply index

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 23:59 [PATCH 00/10] dmaengine: a bundle of cleanup on spin_lock_irqsave/irqrestore Barry Song
2020-10-15 23:59 ` [PATCH 01/10] dmaengine: ipu_idmac: remove redundant irqsave and restore in hardIRQ Barry Song
2020-10-15 23:59 ` [PATCH 02/10] dmaengine: k3-udma: remove redundant irqsave and irqrestore " Barry Song
2020-10-19 13:45   ` Peter Ujfalusi [this message]
2020-10-15 23:59 ` [PATCH 03/10] dmaengine: sf-pdma: " Barry Song
2020-10-15 23:59 ` [PATCH 04/10] dmaengine: tegra210-adma: " Barry Song
2020-10-19 10:31   ` Jon Hunter
2020-10-15 23:59 ` [PATCH 05/10] dmaengine: milbeaut-xdmac: " Barry Song
2020-10-15 23:59 ` [PATCH 06/10] dmaengine: k3dma: " Barry Song
2020-10-15 23:59 ` [PATCH 07/10] dmaengine: hisi_dma: " Barry Song
2020-10-26  1:23   ` Zhou Wang
2020-10-15 23:59 ` [PATCH 08/10] dmaengine: moxart-dma: " Barry Song
2020-10-15 23:59 ` [PATCH 09/10] dmaengine: ste_dma40: " Barry Song
2020-10-29 14:01   ` Linus Walleij
2020-10-29 20:58     ` Song Bao Hua (Barry Song)
2020-10-15 23:59 ` [PATCH 10/10] dmaengine: pxa_dma: " Barry Song
2020-10-23 20:16   ` Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a4beeb9-3473-9655-5004-41ea8958b855@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=song.bao.hua@hisilicon.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org
	public-inbox-index dmaengine

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git