From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 449B8C06510 for ; Tue, 2 Jul 2019 12:27:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 132ED20836 for ; Tue, 2 Jul 2019 12:27:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E426/GGJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726483AbfGBM1g (ORCPT ); Tue, 2 Jul 2019 08:27:36 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:33123 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbfGBM1g (ORCPT ); Tue, 2 Jul 2019 08:27:36 -0400 Received: by mail-lj1-f196.google.com with SMTP id h10so16702137ljg.0; Tue, 02 Jul 2019 05:27:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1197N7NnH+TITMc0XTZixbzwCIXIqQU63tq5LhdHmAM=; b=E426/GGJI9RKb4MAeSR+u6xH0BBA2d4lPnlcSal5EPfyMK5FFcmJNFj7f6gotQSOhB 1uxdin0/h3+sPYi15z/guNb4d31O3hv7fG6YMuU9kKQZuq5qZqqy0EZd17TPYjkjhKcj 9qRNnYMy0NTBA4lSve37Tl1OlzM16ujlKNkdM7FgBa66xKOVv6VUwINdV/+xFNA5FRe2 1Wnn1jws7mWgLQMfxH5yB6Dxrcg5E32IE7lFf13WX3AbGc0nRnJO9xFhsdhWnzXgsirk pECElXyZDv40uS2tCRp6gpBRlG8LGi4Fj0QdCON4Z/rGY5fm0ZBrg7pPEK5MQT6W2MFV 5rAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1197N7NnH+TITMc0XTZixbzwCIXIqQU63tq5LhdHmAM=; b=VZg/U+Cp6mcvfS0EHspxMIFjnj1DUjIuO9+y0G0fkgKJ4h7ZJ341FA9EVp7cLwyJEk HF6Ovm70lMHxZonzGah/Q1kRv6VRllmPF3MZ6d42jNKakQA34nBKVtI1JCGts2b6ckqi cMCrMrDBRgb8boMsLebV3c8jbUZ+pOhO89pLiysvCfBV7/8TmD4jPOk96+C4deA+6mLL 44/jXsmQbfAdafVb0sPBTwoF7vm6L9wLa2btrOhjTBtT735EGda0E0tUiaVxF6vnGMqX lyEPYt/Ll7q7Lksv/S8IGh6wN2cIRWbjJmAzuq78HUK34wcNBW2ZVWfDeN5g1Nx6iBns 9T/w== X-Gm-Message-State: APjAAAVH270z3RrF40kljZhFGShjDLCEpAPE5xEXxuVfBSzXPby9lMY9 NeQJDegnmD9vWQcFcKQeRUvUY52g X-Google-Smtp-Source: APXvYqwVGY7W79JkiJqtVEIR2E6tM1mtsewwyN7HE3eiAWkJLg4d0JHjg2yG0w+5CF4EVgfd9mWyPg== X-Received: by 2002:a2e:5c6:: with SMTP id 189mr17560736ljf.22.1562070453207; Tue, 02 Jul 2019 05:27:33 -0700 (PDT) Received: from [192.168.2.145] (ppp79-139-233-208.pppoe.spdop.ru. [79.139.233.208]) by smtp.googlemail.com with ESMTPSA id h3sm3796776lja.93.2019.07.02.05.27.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Jul 2019 05:27:32 -0700 (PDT) Subject: Re: [PATCH v3] dmaengine: tegra-apb: Support per-burst residue granularity From: Dmitry Osipenko To: Jon Hunter , Laxman Dewangan , Vinod Koul , Thierry Reding , Ben Dooks Cc: dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190627194728.8948-1-digetx@gmail.com> <3a5403fe-b81f-993c-e7c0-407387e001d9@gmail.com> <39df67ea-d707-7181-3050-3d215f4487f6@gmail.com> <108982bc-1741-8fee-d2dd-4f4d45178ba0@gmail.com> Message-ID: <7b02adbd-2b12-a3ea-e74a-d41c4f924fd9@gmail.com> Date: Tue, 2 Jul 2019 15:27:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <108982bc-1741-8fee-d2dd-4f4d45178ba0@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org 02.07.2019 15:04, Dmitry Osipenko пишет: > 02.07.2019 14:56, Dmitry Osipenko пишет: >> 02.07.2019 14:37, Dmitry Osipenko пишет: >>> 02.07.2019 14:20, Jon Hunter пишет: >>>> >>>> On 27/06/2019 20:47, Dmitry Osipenko wrote: >>>>> Tegra's APB DMA engine updates words counter after each transferred burst >>>>> of data, hence it can report transfer's residual with more fidelity which >>>>> may be required in cases like audio playback. In particular this fixes >>>>> audio stuttering during playback in a chromium web browser. The patch is >>>>> based on the original work that was made by Ben Dooks and a patch from >>>>> downstream kernel. It was tested on Tegra20 and Tegra30 devices. >>>>> >>>>> Link: https://lore.kernel.org/lkml/20190424162348.23692-1-ben.dooks@codethink.co.uk/ >>>>> Link: https://nv-tegra.nvidia.com/gitweb/?p=linux-4.4.git;a=commit;h=c7bba40c6846fbf3eaad35c4472dcc7d8bbc02e5 >>>>> Inspired-by: Ben Dooks >>>>> Signed-off-by: Dmitry Osipenko >>>>> --- >>>>> >>>>> Changelog: >>>>> >>>>> v3: Added workaround for a hardware design shortcoming that results >>>>> in a words counter wraparound before end-of-transfer bit is set >>>>> in a cyclic mode. >>>>> >>>>> v2: Addressed review comments made by Jon Hunter to v1. We won't try >>>>> to get words count if dma_desc is on free list as it will result >>>>> in a NULL dereference because this case wasn't handled properly. >>>>> >>>>> The residual value is now updated properly, avoiding potential >>>>> integer overflow by adding the "bytes" to the "bytes_transferred" >>>>> instead of the subtraction. >>>>> >>>>> drivers/dma/tegra20-apb-dma.c | 69 +++++++++++++++++++++++++++++++---- >>>>> 1 file changed, 62 insertions(+), 7 deletions(-) >>>>> >>>>> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c >>>>> index 79e9593815f1..71473eda28ee 100644 >>>>> --- a/drivers/dma/tegra20-apb-dma.c >>>>> +++ b/drivers/dma/tegra20-apb-dma.c >>>>> @@ -152,6 +152,7 @@ struct tegra_dma_sg_req { >>>>> bool last_sg; >>>>> struct list_head node; >>>>> struct tegra_dma_desc *dma_desc; >>>>> + unsigned int words_xferred; >>>>> }; >>>>> >>>>> /* >>>>> @@ -496,6 +497,7 @@ static void tegra_dma_configure_for_next(struct tegra_dma_channel *tdc, >>>>> tdc_write(tdc, TEGRA_APBDMA_CHAN_CSR, >>>>> nsg_req->ch_regs.csr | TEGRA_APBDMA_CSR_ENB); >>>>> nsg_req->configured = true; >>>>> + nsg_req->words_xferred = 0; >>>>> >>>>> tegra_dma_resume(tdc); >>>>> } >>>>> @@ -511,6 +513,7 @@ static void tdc_start_head_req(struct tegra_dma_channel *tdc) >>>>> typeof(*sg_req), node); >>>>> tegra_dma_start(tdc, sg_req); >>>>> sg_req->configured = true; >>>>> + sg_req->words_xferred = 0; >>>>> tdc->busy = true; >>>>> } >>>>> >>>>> @@ -797,6 +800,61 @@ static int tegra_dma_terminate_all(struct dma_chan *dc) >>>>> return 0; >>>>> } >>>>> >>>>> +static unsigned int tegra_dma_sg_bytes_xferred(struct tegra_dma_channel *tdc, >>>>> + struct tegra_dma_sg_req *sg_req) >>>>> +{ >>>>> + unsigned long status, wcount = 0; >>>>> + >>>>> + if (!list_is_first(&sg_req->node, &tdc->pending_sg_req)) >>>>> + return 0; >>>>> + >>>>> + if (tdc->tdma->chip_data->support_separate_wcount_reg) >>>>> + wcount = tdc_read(tdc, TEGRA_APBDMA_CHAN_WORD_TRANSFER); >>>>> + >>>>> + status = tdc_read(tdc, TEGRA_APBDMA_CHAN_STATUS); >>>>> + >>>>> + if (!tdc->tdma->chip_data->support_separate_wcount_reg) >>>>> + wcount = status; >>>>> + >>>>> + if (status & TEGRA_APBDMA_STATUS_ISE_EOC) >>>>> + return sg_req->req_len; >>>>> + >>>>> + wcount = get_current_xferred_count(tdc, sg_req, wcount); >>>>> + >>>>> + if (!wcount) { >>>>> + /* >>>>> + * If wcount wasn't ever polled for this SG before, then >>>>> + * simply assume that transfer hasn't started yet. >>>>> + * >>>>> + * Otherwise it's the end of the transfer. >>>>> + * >>>>> + * The alternative would be to poll the status register >>>>> + * until EOC bit is set or wcount goes UP. That's so >>>>> + * because EOC bit is getting set only after the last >>>>> + * burst's completion and counter is less than the actual >>>>> + * transfer size by 4 bytes. The counter value wraps around >>>>> + * in a cyclic mode before EOC is set(!), so we can't easily >>>>> + * distinguish start of transfer from its end. >>>>> + */ >>>>> + if (sg_req->words_xferred) >>>>> + wcount = sg_req->req_len - 4; >>>>> + >>>>> + } else if (wcount < sg_req->words_xferred) { >>>>> + /* >>>>> + * This case shall not ever happen because EOC bit >>>>> + * must be set once next cyclic transfer is started. >>>> >>>> I am not sure I follow this and why this condition cannot happen for >>>> cyclic transfers. What about non-cyclic transfers? >>> >>> It cannot happen because the EOC bit will be set in that case. The counter wraps >>> around when the transfer of a last burst happens, EOC bit is guaranteed to be set >>> after completion of the last burst. That's my observation after a thorough testing, >>> it will be very odd if EOC setting happened completely asynchronously. >>> >>> For a non-cyclic transfers it doesn't matter.. because they are not cyclic and thus >>> counter will be stopped by itself. It will be a disaster if all of sudden a >>> non-cyclic transfer becomes cyclic, don't you think so? :) >>> >> >> Ah, probably I was too focused on audio playback use-case. If it's a free-running >> transfer, then that case of a wraparound seems should be legit.. hmm. >> > > Looks like that will work: > > diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c > index 71473eda28ee..201c693b11f5 100644 > --- a/drivers/dma/tegra20-apb-dma.c > +++ b/drivers/dma/tegra20-apb-dma.c > @@ -648,6 +648,8 @@ static void handle_cont_sngl_cycle_dma_done(struct tegra_dma_channel *tdc, > st = handle_continuous_head_request(tdc, sgreq, to_terminate); > if (!st) > dma_desc->dma_status = DMA_ERROR; > + } else { > + sg_req->words_xferred = 0; > } > } > BTW, I don't understand the logic of having multiple SGs for a cyclic transfer. It looks like driver is doing insane thing by trying to substitute an in-fly SG with another one..