From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Richard Acayan <mailingradian@gmail.com>, linux-arm-msm@vger.kernel.org
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: dma: qcom: gpi: add fallback compatible
Date: Fri, 23 Sep 2022 23:26:12 +0200 [thread overview]
Message-ID: <7b066e11-6e5c-c6d9-c8ed-9feccaec4c0c@linaro.org> (raw)
In-Reply-To: <20220923210934.280034-2-mailingradian@gmail.com>
On 23/09/2022 23:09, Richard Acayan wrote:
> The drivers are transitioning from matching against lists of specific
> compatible strings to matching against smaller lists of more generic
> compatible strings. Add a fallback compatible string in the schema to
> support this change.
Thanks for the patch. I wished we discussed it a bit more. :)
qcom,gpi-dma does not look like specific enough to be correct fallback,
at least not for all of the devices. I propose either a IP block version
(which is tricky without access to documentation) or just one of the SoC
IP blocks.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
> .../devicetree/bindings/dma/qcom,gpi.yaml | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> index eabf8a76d3a0..25bc1a6de794 100644
> --- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> @@ -18,14 +18,15 @@ allOf:
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-23 21:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 21:09 [PATCH v2 0/4] SDM670 GPI DMA support Richard Acayan
2022-09-23 21:09 ` [PATCH v2 1/4] dt-bindings: dma: qcom: gpi: add fallback compatible Richard Acayan
2022-09-23 21:26 ` Krzysztof Kozlowski [this message]
2022-09-23 22:20 ` [PATCH v2 1/4] dt-bindings: dma: qcom: gpi: add fallback Richard Acayan
2022-09-26 23:12 ` Rob Herring
2022-09-27 1:53 ` Richard Acayan
2022-09-28 7:57 ` Krzysztof Kozlowski
2022-09-29 7:39 ` [PATCH v2 1/4] dt-bindings: dma: qcom: gpi: add fallback compatible Vinod Koul
2022-09-29 7:47 ` Krzysztof Kozlowski
2022-09-23 21:09 ` [PATCH v2 2/4] dt-bindings: dma: qcom: gpi: add compatible for sdm670 Richard Acayan
2022-09-23 21:09 ` [PATCH v2 3/4] arm64: dts: qcom: add gpi-dma fallback compatible Richard Acayan
2022-09-23 21:09 ` [PATCH v2 4/4] dmaengine: qcom: gpi: drop redundant of_device_id entries Richard Acayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b066e11-6e5c-c6d9-c8ed-9feccaec4c0c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).