dmaengine Archive on lore.kernel.org
 help / color / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: "Dmitry Osipenko" <digetx@gmail.com>,
	"Laxman Dewangan" <ldewangan@nvidia.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: <dmaengine@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 11/19] dmaengine: tegra-apb: Remove duplicated pending_sg_req checks
Date: Fri, 14 Feb 2020 14:13:13 +0000
Message-ID: <81d0f76a-8391-f8ee-c713-b699188d1856@nvidia.com> (raw)
In-Reply-To: <20200209163356.6439-12-digetx@gmail.com>


On 09/02/2020 16:33, Dmitry Osipenko wrote:
> There are few place in the code which check whether pending_sg_req list is
> empty despite of the check already being done. Let's remove the duplicated
> checks to keep code clean.
> 
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  drivers/dma/tegra20-apb-dma.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
> index 22b88ccff05d..049e98ae1240 100644
> --- a/drivers/dma/tegra20-apb-dma.c
> +++ b/drivers/dma/tegra20-apb-dma.c
> @@ -504,9 +504,6 @@ static void tdc_start_head_req(struct tegra_dma_channel *tdc)
>  {
>  	struct tegra_dma_sg_req *sg_req;
>  
> -	if (list_empty(&tdc->pending_sg_req))
> -		return;
> -
>  	sg_req = list_first_entry(&tdc->pending_sg_req, typeof(*sg_req), node);
>  	tegra_dma_start(tdc, sg_req);
>  	sg_req->configured = true;
> @@ -518,9 +515,6 @@ static void tdc_configure_next_head_desc(struct tegra_dma_channel *tdc)
>  {
>  	struct tegra_dma_sg_req *hsgreq, *hnsgreq;
>  
> -	if (list_empty(&tdc->pending_sg_req))
> -		return;
> -
>  	hsgreq = list_first_entry(&tdc->pending_sg_req, typeof(*hsgreq), node);
>  	if (!list_is_last(&hsgreq->node, &tdc->pending_sg_req)) {
>  		hnsgreq = list_first_entry(&hsgreq->node, typeof(*hnsgreq),
> @@ -567,12 +561,6 @@ static bool handle_continuous_head_request(struct tegra_dma_channel *tdc,
>  {
>  	struct tegra_dma_sg_req *hsgreq;
>  
> -	if (list_empty(&tdc->pending_sg_req)) {
> -		dev_err(tdc2dev(tdc), "DMA is running without req\n");
> -		tegra_dma_stop(tdc);
> -		return false;
> -	}
> -
>  	/*
>  	 * Check that head req on list should be in flight.
>  	 * If it is not in flight then abort transfer as
> 

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Thanks
Jon

-- 
nvpublic

  reply index

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-09 16:33 [PATCH v8 00/19] NVIDIA Tegra APB DMA driver fixes and improvements Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 01/19] dmaengine: tegra-apb: Fix use-after-free Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 02/19] dmaengine: tegra-apb: Prevent race conditions of tasklet vs free list Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 03/19] dmaengine: tegra-apb: Implement synchronization hook Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 04/19] dmaengine: tegra-apb: Prevent race conditions on channel's freeing Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 05/19] dmaengine: tegra-apb: Clean up tasklet releasing Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 06/19] dmaengine: tegra-apb: Use devm_platform_ioremap_resource Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 07/19] dmaengine: tegra-apb: Use devm_request_irq Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 08/19] dmaengine: tegra-apb: Fix coding style problems Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 09/19] dmaengine: tegra-apb: Remove unneeded initialization of tdc->config_init Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 10/19] dmaengine: tegra-apb: Remove assumptions about unavailable runtime PM Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 11/19] dmaengine: tegra-apb: Remove duplicated pending_sg_req checks Dmitry Osipenko
2020-02-14 14:13   ` Jon Hunter [this message]
2020-02-09 16:33 ` [PATCH v8 12/19] dmaengine: tegra-apb: Keep clock enabled only during of DMA transfer Dmitry Osipenko
2020-02-14 14:15   ` Jon Hunter
2020-02-09 16:33 ` [PATCH v8 13/19] dmaengine: tegra-apb: Clean up suspend-resume Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 14/19] dmaengine: tegra-apb: Add missing of_dma_controller_free Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 15/19] dmaengine: tegra-apb: Allow to compile as a loadable kernel module Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 16/19] dmaengine: tegra-apb: Remove MODULE_ALIAS Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 17/19] dmaengine: tegra-apb: Support COMPILE_TEST Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 18/19] dmaengine: tegra-apb: Remove unused function argument Dmitry Osipenko
2020-02-14 14:16   ` Jon Hunter
2020-02-14 16:54     ` Dmitry Osipenko
2020-02-17 11:15       ` Jon Hunter
2020-02-17 14:56         ` Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 19/19] dmaengine: tegra-apb: Improve error message about DMA underflow Dmitry Osipenko
2020-02-14 14:16   ` Jon Hunter

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81d0f76a-8391-f8ee-c713-b699188d1856@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=dan.j.williams@intel.com \
    --cc=digetx@gmail.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=thierry.reding@gmail.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org
	public-inbox-index dmaengine

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git