From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: dan.j.williams@intel.com, vkoul@kernel.org,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] dma: pxa_dma: no need to check return value of debugfs_create functions
Date: Tue, 13 Aug 2019 23:21:04 +0200 [thread overview]
Message-ID: <87o90srccf.fsf@belgarion.home> (raw)
In-Reply-To: <20190811070350.GA28202@kroah.com> (Greg Kroah-Hartman's message of "Sun, 11 Aug 2019 09:03:50 +0200")
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> On Sat, Aug 10, 2019 at 09:27:26PM +0200, Robert Jarzmik wrote:
>> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
>>
>> This is not strictly equivalent.
>> Imagine that the debugfs_create_dir() fails and returns NULL :
> How can that happen?
Well in v5.0-rc1 that could happen ... unfortunately that's also the code I
checked ...
>> - in the former case, neither "state", "descriptors" nor "requesters" would be
>> created
>> - in the new code, "state", "descriptors" nor "requesters" will be created in
>> the debugfs root directory
>
> I agree, but debugfs_create_dir() does not return a NULL on an error
> since many kernel releases. Neither can debugfs_create_file() so really
> this test is not working at all as-is :)
Ah yes, you're right, I wasn't aware of the debugfs changes ...
But checking a bit further, your original mail is 2 monthes old, and this patch
was already merged in v5.2. I probably fell in a time-space anomaly, as I
received this mail only a couple of days ago.
Have a nice day.
--
Robert
next prev parent reply other threads:[~2019-08-13 21:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 12:25 [PATCH 1/6] dma: amba-pl08x: no need to cast away call to debugfs_create_file() Greg Kroah-Hartman
2019-06-12 12:25 ` [PATCH 2/6] dma: bcm-sba-raid: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-06-12 12:25 ` [PATCH 3/6] dma: coh901318: no need to cast away call to debugfs_create_file() Greg Kroah-Hartman
2019-06-12 12:42 ` Linus Walleij
2019-06-12 12:25 ` [PATCH 4/6] dma: pxa_dma: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-08-10 19:27 ` Robert Jarzmik
2019-08-11 7:03 ` Greg Kroah-Hartman
2019-08-13 21:21 ` Robert Jarzmik [this message]
2019-06-12 12:25 ` [PATCH 5/6] dma: mic_x100_dma: " Greg Kroah-Hartman
2019-06-12 15:44 ` Sudeep Dutt
2019-06-12 12:25 ` [PATCH 6/6] dma: qcom: hidma: " Greg Kroah-Hartman
2019-06-12 15:24 ` Sinan Kaya
2019-06-12 15:39 ` Greg Kroah-Hartman
2019-06-12 16:17 ` Sinan Kaya
2019-06-12 16:47 ` Greg Kroah-Hartman
2019-06-14 5:46 ` [PATCH 1/6] dma: amba-pl08x: no need to cast away call to debugfs_create_file() Vinod Koul
2019-06-14 5:55 ` Greg Kroah-Hartman
2019-06-18 16:00 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o90srccf.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=dan.j.williams@intel.com \
--cc=daniel@zonque.org \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).