From: Jon Hunter <jonathanh@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Vinod Koul <vkoul@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Ben Dooks <ben.dooks@codethink.co.uk>
Cc: <dmaengine@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] dmaengine: tegra-apb: Support per-burst residue granularity
Date: Tue, 2 Jul 2019 13:57:41 +0100 [thread overview]
Message-ID: <892f4ec3-c063-7e75-a891-3f814db2b9ff@nvidia.com> (raw)
In-Reply-To: <b50045f9-7d8f-d91a-8629-625bcd7057bc@nvidia.com>
On 02/07/2019 13:54, Jon Hunter wrote:
>
> On 02/07/2019 12:37, Dmitry Osipenko wrote:
>> 02.07.2019 14:20, Jon Hunter пишет:
>>>
>>> On 27/06/2019 20:47, Dmitry Osipenko wrote:
>>>> Tegra's APB DMA engine updates words counter after each transferred burst
>>>> of data, hence it can report transfer's residual with more fidelity which
>>>> may be required in cases like audio playback. In particular this fixes
>>>> audio stuttering during playback in a chromium web browser. The patch is
>>>> based on the original work that was made by Ben Dooks and a patch from
>>>> downstream kernel. It was tested on Tegra20 and Tegra30 devices.
>>>>
>>>> Link: https://lore.kernel.org/lkml/20190424162348.23692-1-ben.dooks@codethink.co.uk/
>>>> Link: https://nv-tegra.nvidia.com/gitweb/?p=linux-4.4.git;a=commit;h=c7bba40c6846fbf3eaad35c4472dcc7d8bbc02e5
>>>> Inspired-by: Ben Dooks <ben.dooks@codethink.co.uk>
>>>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>>>> ---
>>>>
>>>> Changelog:
>>>>
>>>> v3: Added workaround for a hardware design shortcoming that results
>>>> in a words counter wraparound before end-of-transfer bit is set
>>>> in a cyclic mode.
>>>>
>>>> v2: Addressed review comments made by Jon Hunter to v1. We won't try
>>>> to get words count if dma_desc is on free list as it will result
>>>> in a NULL dereference because this case wasn't handled properly.
>>>>
>>>> The residual value is now updated properly, avoiding potential
>>>> integer overflow by adding the "bytes" to the "bytes_transferred"
>>>> instead of the subtraction.
>>>>
>>>> drivers/dma/tegra20-apb-dma.c | 69 +++++++++++++++++++++++++++++++----
>>>> 1 file changed, 62 insertions(+), 7 deletions(-)
>>>>
>>>> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
>>>> index 79e9593815f1..71473eda28ee 100644
>>>> --- a/drivers/dma/tegra20-apb-dma.c
>>>> +++ b/drivers/dma/tegra20-apb-dma.c
>>>> @@ -152,6 +152,7 @@ struct tegra_dma_sg_req {
>>>> bool last_sg;
>>>> struct list_head node;
>>>> struct tegra_dma_desc *dma_desc;
>>>> + unsigned int words_xferred;
>>>> };
>>>>
>>>> /*
>>>> @@ -496,6 +497,7 @@ static void tegra_dma_configure_for_next(struct tegra_dma_channel *tdc,
>>>> tdc_write(tdc, TEGRA_APBDMA_CHAN_CSR,
>>>> nsg_req->ch_regs.csr | TEGRA_APBDMA_CSR_ENB);
>>>> nsg_req->configured = true;
>>>> + nsg_req->words_xferred = 0;
>>>>
>>>> tegra_dma_resume(tdc);
>>>> }
>>>> @@ -511,6 +513,7 @@ static void tdc_start_head_req(struct tegra_dma_channel *tdc)
>>>> typeof(*sg_req), node);
>>>> tegra_dma_start(tdc, sg_req);
>>>> sg_req->configured = true;
>>>> + sg_req->words_xferred = 0;
>>>> tdc->busy = true;
>>>> }
>>>>
>>>> @@ -797,6 +800,61 @@ static int tegra_dma_terminate_all(struct dma_chan *dc)
>>>> return 0;
>>>> }
>>>>
>>>> +static unsigned int tegra_dma_sg_bytes_xferred(struct tegra_dma_channel *tdc,
>>>> + struct tegra_dma_sg_req *sg_req)
>>>> +{
>>>> + unsigned long status, wcount = 0;
>>>> +
>>>> + if (!list_is_first(&sg_req->node, &tdc->pending_sg_req))
>>>> + return 0;
>>>> +
>>>> + if (tdc->tdma->chip_data->support_separate_wcount_reg)
>>>> + wcount = tdc_read(tdc, TEGRA_APBDMA_CHAN_WORD_TRANSFER);
>>>> +
>>>> + status = tdc_read(tdc, TEGRA_APBDMA_CHAN_STATUS);
>>>> +
>>>> + if (!tdc->tdma->chip_data->support_separate_wcount_reg)
>>>> + wcount = status;
>>>> +
>>>> + if (status & TEGRA_APBDMA_STATUS_ISE_EOC)
>>>> + return sg_req->req_len;
>>>> +
>>>> + wcount = get_current_xferred_count(tdc, sg_req, wcount);
>>>> +
>>>> + if (!wcount) {
>>>> + /*
>>>> + * If wcount wasn't ever polled for this SG before, then
>>>> + * simply assume that transfer hasn't started yet.
>>>> + *
>>>> + * Otherwise it's the end of the transfer.
>>>> + *
>>>> + * The alternative would be to poll the status register
>>>> + * until EOC bit is set or wcount goes UP. That's so
>>>> + * because EOC bit is getting set only after the last
>>>> + * burst's completion and counter is less than the actual
>>>> + * transfer size by 4 bytes. The counter value wraps around
>>>> + * in a cyclic mode before EOC is set(!), so we can't easily
>>>> + * distinguish start of transfer from its end.
>>>> + */
>>>> + if (sg_req->words_xferred)
>>>> + wcount = sg_req->req_len - 4;
>>>> +
>>>> + } else if (wcount < sg_req->words_xferred) {
>>>> + /*
>>>> + * This case shall not ever happen because EOC bit
>>>> + * must be set once next cyclic transfer is started.
>>>
>>> I am not sure I follow this and why this condition cannot happen for
>>> cyclic transfers. What about non-cyclic transfers?
>>
>> It cannot happen because the EOC bit will be set in that case. The counter wraps
>> around when the transfer of a last burst happens, EOC bit is guaranteed to be set
>> after completion of the last burst. That's my observation after a thorough testing,
>> it will be very odd if EOC setting happened completely asynchronously.
>
> I see how you know that the EOC is set. Anyway, you check if the EOC is
> set before and if so return sg_req->req_len prior to this test.
s/I see/I don't see/
Jon
--
nvpublic
next prev parent reply other threads:[~2019-07-02 12:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 19:47 [PATCH v3] dmaengine: tegra-apb: Support per-burst residue granularity Dmitry Osipenko
2019-07-02 9:25 ` Dmitry Osipenko
2019-07-02 11:20 ` Jon Hunter
2019-07-02 11:37 ` Dmitry Osipenko
2019-07-02 11:56 ` Dmitry Osipenko
2019-07-02 12:04 ` Dmitry Osipenko
2019-07-02 12:27 ` Dmitry Osipenko
2019-07-02 12:56 ` Jon Hunter
2019-07-02 12:54 ` Jon Hunter
2019-07-02 12:57 ` Jon Hunter [this message]
2019-07-02 13:22 ` Dmitry Osipenko
2019-07-02 13:41 ` Jon Hunter
2019-07-02 14:41 ` Dmitry Osipenko
2019-07-02 15:27 ` Jon Hunter
2019-07-02 15:29 ` Jon Hunter
2019-07-02 15:37 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=892f4ec3-c063-7e75-a891-3f814db2b9ff@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=ben.dooks@codethink.co.uk \
--cc=digetx@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).