From: Sanjay R Mehta <sanmehta@amd.com>
To: Vinod Koul <vkoul@kernel.org>, Sanjay R Mehta <Sanju.Mehta@amd.com>
Cc: gregkh@linuxfoundation.org, dan.j.williams@intel.com,
Thomas.Lendacky@amd.com, Shyam-sundar.S-k@amd.com,
Nehal-bakulchandra.Shah@amd.com, robh@kernel.org,
mchehab+samsung@kernel.org, davem@davemloft.net,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v9 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA
Date: Tue, 15 Jun 2021 16:50:07 +0530 [thread overview]
Message-ID: <94bba5dd-b755-81d0-de30-ce3cdaa3f241@amd.com> (raw)
In-Reply-To: <YL+rUBGUJoFLS902@vkoul-mobl>
On 6/8/2021 11:09 PM, Vinod Koul wrote:
> [CAUTION: External Email]
>
> On 02-06-21, 12:22, Sanjay R Mehta wrote:
>
>> +static int pt_core_execute_cmd(struct ptdma_desc *desc, struct pt_cmd_queue *cmd_q)
>> +{
>> + bool soc = FIELD_GET(DWORD0_SOC, desc->dw0);
>> + u8 *q_desc = (u8 *)&cmd_q->qbase[cmd_q->qidx];
>> + u8 *dp = (u8 *)desc;
>
> this case seems unnecessary?
>
>> +int pt_core_perform_passthru(struct pt_cmd_queue *cmd_q,
>> + struct pt_passthru_engine *pt_engine)
>
> Pls align this to preceding open brace, checkpatch with --strict would
> warn you about this
>
>> +static irqreturn_t pt_core_irq_handler(int irq, void *data)
>> +{
>> + struct pt_device *pt = data;
>> + struct pt_cmd_queue *cmd_q = &pt->cmd_q;
>> + u32 status;
>> +
>> + pt_core_disable_queue_interrupts(pt);
>> +
>> + status = ioread32(cmd_q->reg_interrupt_status);
>> + if (status) {
>> + cmd_q->int_status = status;
>> + cmd_q->q_status = ioread32(cmd_q->reg_status);
>> + cmd_q->q_int_status = ioread32(cmd_q->reg_int_status);
>> +
>> + /* On error, only save the first error value */
>> + if ((status & INT_ERROR) && !cmd_q->cmd_error)
>> + cmd_q->cmd_error = CMD_Q_ERROR(cmd_q->q_status);
>> +
>> + /* Acknowledge the interrupt */
>> + iowrite32(status, cmd_q->reg_interrupt_status);
>> + }
>> +
>> + pt_core_enable_queue_interrupts(pt);
>> +
>> + return IRQ_HANDLED;
>
> should you always return IRQ_HANDLED, that sounds apt for the if loop
> but not for the non loop case
>
>> +int pt_core_init(struct pt_device *pt)
>> +{
>> + char dma_pool_name[MAX_DMAPOOL_NAME_LEN];
>> + struct pt_cmd_queue *cmd_q = &pt->cmd_q;
>> + u32 dma_addr_lo, dma_addr_hi;
>> + struct device *dev = pt->dev;
>> + struct dma_pool *dma_pool;
>> + int ret;
>> +
>> + /* Allocate a dma pool for the queue */
>> + snprintf(dma_pool_name, sizeof(dma_pool_name), "%s_q", pt->name);
>> +
>> + dma_pool = dma_pool_create(dma_pool_name, dev,
>> + PT_DMAPOOL_MAX_SIZE,
>> + PT_DMAPOOL_ALIGN, 0);
>> + if (!dma_pool) {
>> + dev_err(dev, "unable to allocate dma pool\n");
>
> This is superfluous, allocator would warn on failure
>
>> +static struct pt_device *pt_alloc_struct(struct device *dev)
>> +{
>> + struct pt_device *pt;
>> +
>> + pt = devm_kzalloc(dev, sizeof(*pt), GFP_KERNEL);
>> +
>> + if (!pt)
>> + return NULL;
>> + pt->dev = dev;
>> + pt->ord = atomic_inc_return(&pt_ordinal);
>
> What is the use of this number?
>
There are eight similar instances of this DMA engine on AMD SOC.
It is to differentiate each of these instances.
- Sanjay
next prev parent reply other threads:[~2021-06-15 11:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 17:22 [PATCH v9 0/3] Add support for AMD PTDMA controller driver Sanjay R Mehta
2021-06-02 17:22 ` [PATCH v9 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA Sanjay R Mehta
2021-06-08 17:39 ` Vinod Koul
2021-06-15 11:20 ` Sanjay R Mehta [this message]
2021-06-16 4:15 ` Vinod Koul
2021-06-16 4:54 ` Sanjay R Mehta
2021-06-16 6:16 ` Greg KH
2021-06-16 6:57 ` Sanjay R Mehta
2021-06-16 7:17 ` Greg KH
2021-06-16 7:52 ` Vinod Koul
2021-06-16 7:59 ` Greg KH
2021-06-16 9:46 ` Sanjay R Mehta
2021-06-16 9:56 ` Vinod Koul
2021-06-16 12:00 ` Sanjay R Mehta
2021-06-16 12:23 ` Greg KH
2021-06-16 12:53 ` Sanjay R Mehta
2021-06-16 12:57 ` Greg KH
2021-06-02 17:22 ` [PATCH v9 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource Sanjay R Mehta
2021-06-08 18:56 ` Vinod Koul
2021-06-15 11:34 ` Sanjay R Mehta
2021-06-16 4:18 ` Vinod Koul
2021-06-16 5:23 ` Sanjay R Mehta
2021-06-20 3:52 ` Sanjay R Mehta
2021-06-02 17:22 ` [PATCH v9 3/3] dmaengine: ptdma: Add debugfs entries for PTDMA Sanjay R Mehta
2021-06-09 14:10 ` Vinod Koul
2021-06-15 11:18 ` Sanjay R Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94bba5dd-b755-81d0-de30-ce3cdaa3f241@amd.com \
--to=sanmehta@amd.com \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Sanju.Mehta@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).