From: Robin Murphy <robin.murphy@arm.com>
To: Sinan Kaya <Okaya@kernel.org>, Fuqian Huang <huangfq.daxian@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
David Brown <david.brown@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v3 04/24] dmaengine: qcom_hidma: Remove call to memset after dmam_alloc_coherent
Date: Tue, 16 Jul 2019 12:35:05 +0100 [thread overview]
Message-ID: <9ea5f97f-5963-5836-6ab2-dc30628c6820@arm.com> (raw)
In-Reply-To: <245ffd79-316c-e985-d1da-2ccea6d29636@kernel.org>
On 15/07/2019 16:17, Sinan Kaya wrote:
> On 7/15/2019 1:43 AM, Fuqian Huang wrote:
>> Should I rewrite the commit log? Just mention that dma_alloc_coherent
>> has already
>> zeroed the memory and not to reference the commit?
>
> I'd like to hear from Robin Murphy that arm smmu driver follows this as
> well.
I'd be lying if I said it did.
...but only because that's never been part of the SMMU driver's
responsibility either way. The iommu-dma layer however, and thus the
respective arm64 iommu_dma_ops, has always zeroed allocations right from
its inception.
518a2f1925c3 was just cleaning up the last of the stragglers which
*weren't* already clearing buffers anyway, such that we could formalise
that behaviour into the API.
Robin.
next prev parent reply other threads:[~2019-07-16 11:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 3:17 [PATCH v3 04/24] dmaengine: qcom_hidma: Remove call to memset after dmam_alloc_coherent Fuqian Huang
2019-07-15 4:17 ` Sinan Kaya
2019-07-15 5:43 ` Fuqian Huang
2019-07-15 15:17 ` Sinan Kaya
2019-07-16 11:35 ` Robin Murphy [this message]
2019-07-16 15:10 ` Sinan Kaya
2019-08-08 12:22 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ea5f97f-5963-5836-6ab2-dc30628c6820@arm.com \
--to=robin.murphy@arm.com \
--cc=Okaya@kernel.org \
--cc=agross@kernel.org \
--cc=david.brown@linaro.org \
--cc=dmaengine@vger.kernel.org \
--cc=hch@infradead.org \
--cc=huangfq.daxian@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).