From: "N, Pandith" <pandith.n@intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: "Eugeniy.Paltsev@synopsys.com" <Eugeniy.Paltsev@synopsys.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"Raja Subramanian,
Lakshmi Bai" <lakshmi.bai.raja.subramanian@intel.com>,
"Pan, Kris" <kris.pan@intel.com>,
"Sangannavar,
Mallikarjunappa" <mallikarjunappa.sangannavar@intel.com>,
"Thokala, Srikanth" <srikanth.thokala@intel.com>
Subject: RE: [linux-drivers-review] [PATCH V2 1/1] dmaengine: dw-axi-dmac: support parallel memory <--> peripheral transfers
Date: Wed, 14 Jul 2021 12:45:39 +0000 [thread overview]
Message-ID: <BYAPR11MB35282B43582FAB4C6619790EE1139@BYAPR11MB3528.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YO5tAlVshNLat2jt@matsya>
Hi Vinod,
Thanks for review, Please check for in-line response for the comments
Regards
Pandith
> -----Original Message-----
> From: Vinod Koul <vkoul@kernel.org>
> Sent: Wednesday, July 14, 2021 10:20 AM
> To: N, Pandith <pandith.n@intel.com>
> Cc: Eugeniy.Paltsev@synopsys.com; dmaengine@vger.kernel.org; Raja
> Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@intel.com>; Pan, Kris
> <kris.pan@intel.com>; Sangannavar, Mallikarjunappa
> <mallikarjunappa.sangannavar@intel.com>; Thokala, Srikanth
> <srikanth.thokala@intel.com>
> Subject: Re: [linux-drivers-review] [PATCH V2 1/1] dmaengine: dw-axi-dmac:
> support parallel memory <--> peripheral transfers
>
> On 09-07-21, 15:21, pandith.n@intel.com wrote:
> > From: Pandith N <pandith.n@intel.com>
> >
> > Added support for multiple DMA_MEM_TO_DEV, DMA_DEV_TO_MEM
> transfers in
> > parallel. This is required for peripherals using DMA for transmit and
> > receive operations at the same time. APB slot number needs to be
> > programmed in channel hardware handshaking interface.
> >
> > Removed free slot check algorithm in dw_axi_dma_set_hw_channel. For 8
> > DMA channels, use respective handshake slot in DMA_HS_SEL APB register.
>
> and why was that removed, maybe a different patch for that?
>
For every channel, an dedicated slot is provided in hardware handshake register.
Peripheral source number is programmed in respective channel slots.
> >
> > Burst length, DMA HW capability set in dt-binding is now used in driver.
>
> Another patch...
>
> So, too many changes below for the description above, pls split
>
I will split the changes as separate patches in next version.
> --
> ~Vinod
next prev parent reply other threads:[~2021-07-14 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 9:51 [linux-drivers-review] [PATCH V2 1/1] dmaengine: dw-axi-dmac: support parallel memory <--> peripheral transfers pandith.n
2021-07-14 4:50 ` Vinod Koul
2021-07-14 12:45 ` N, Pandith [this message]
2021-07-20 12:24 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB35282B43582FAB4C6619790EE1139@BYAPR11MB3528.namprd11.prod.outlook.com \
--to=pandith.n@intel.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=dmaengine@vger.kernel.org \
--cc=kris.pan@intel.com \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=srikanth.thokala@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).