From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16BC3C6FA82 for ; Thu, 15 Sep 2022 21:56:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229759AbiIOV4j (ORCPT ); Thu, 15 Sep 2022 17:56:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbiIOV4i (ORCPT ); Thu, 15 Sep 2022 17:56:38 -0400 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58BD88B981 for ; Thu, 15 Sep 2022 14:56:36 -0700 (PDT) Received: by mail-yb1-xb2d.google.com with SMTP id e81so10391610ybb.13 for ; Thu, 15 Sep 2022 14:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=JX9fTkq4tugLO6FL9ET8mX9f3rZGcI9uwJUlh9oT3XY=; b=Srf1ZQSyBr19coh7nj2aTvsXsaOIS/oIKx2DhWYMjU2NKDO7WQxtuGTyglZAyVrbnA Uj/QMJC9CSd/l8iFJ01p0tKtEQ2U3EQ1koMIPvAMFp+bkgD9LSk2v4N5YUW6f0QaOtV6 wNOeA+4BkU6iyumZrZM3oEk9Yms7pfcFdJ7lv4GYqYCQBlPSjMBmN6poh4GpTuqPLFkC xxET9x6krRs2nQphspUHs/BSeGBOUacsRnu37Feuj4i2VWkopcNB2lmCowlOYbuR2oZg gQvY4ekhDQBXCFgg95GiWFo5hGHp0lFHQSZtNZWxf7ljc1wHsjtg9RZCCXOCFcGiMF5X ANqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=JX9fTkq4tugLO6FL9ET8mX9f3rZGcI9uwJUlh9oT3XY=; b=AJK7/5Zjd4c75Nk/KNQ4dc9rYGf+ARrBdu7IGj7o+dZXKx+VsabZYOFpUCAY42gO47 8Ufpi/OariRwAjd0x0zgKi8gkIFY/BqrR3WJ8c/SFhcDPtfGCQBL6CgcG3Bol/xtgBXs ffVG/n9IzxcmmOvx9wxOyelzRnAuQbg3cfjdhvrx9kIDunJuZa1A+K1Jz6cAN5BOvvGB 0Y16Pn9HdmpByN15EASWs2s4iMUSeXYnvACKjWgdIC/qoS6srhgsk0oX5QFqSZ4icN0o eh22neYMqYVtldSdMuh0NjAIxvqShVQidepMtFFfhfsqOE3sAxczR4wIcitgSTr3xsT6 KuiA== X-Gm-Message-State: ACrzQf1r+GFNhyc0C/DgIh/Aue9BIMJ+kWnvID2/uT0f/EQ475UqRS9V AFBy4/RfCo9hfBjEb4KpffZcBi9L5u48AHPGlTQD5w== X-Google-Smtp-Source: AMsMyM7v2nmvHmfbjX5rLUALCSTtuecAYdmFE+aJnXkmcOJa5iDWlDanh9g4UOjwuvBWDm4ZbJzoju1oeXo/moiWjjc= X-Received: by 2002:a25:af13:0:b0:6ae:3166:1aee with SMTP id a19-20020a25af13000000b006ae31661aeemr1717295ybh.288.1663278995367; Thu, 15 Sep 2022 14:56:35 -0700 (PDT) MIME-Version: 1.0 References: <20220915204844.3838-1-ansuelsmth@gmail.com> In-Reply-To: <20220915204844.3838-1-ansuelsmth@gmail.com> From: Dmitry Baryshkov Date: Fri, 16 Sep 2022 00:56:24 +0300 Message-ID: Subject: Re: [PATCH] dmaengine: qcom-adm: fix wrong sizeof config in slave_config To: Christian Marangi Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Mark Brown , Arnd Bergmann , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Thu, 15 Sept 2022 at 23:49, Christian Marangi wrote: > > Fix broken slave_config function that uncorrectly compare the > peripheral_size with the size of the config pointer instead of the size > of the config struct. This cause the crci value to be ignored and cause > a kernel panic on any slave that use adm driver. > > To fix this, compare to the size of the struct and NOT the size of the > pointer. > > Fixes: 03de6b273805 ("dmaengine: qcom-adm: stop abusing slave_id config") > Signed-off-by: Christian Marangi > Cc: stable@vger.kernel.org # v5.17+ Reviewed-by: Dmitry Baryshkov > --- > drivers/dma/qcom/qcom_adm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) -- With best wishes Dmitry