From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E95AC31E4B for ; Fri, 14 Jun 2019 13:26:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22DE52133D for ; Fri, 14 Jun 2019 13:26:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qnmZOrT5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727766AbfFNN0D (ORCPT ); Fri, 14 Jun 2019 09:26:03 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:41790 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727737AbfFNN0D (ORCPT ); Fri, 14 Jun 2019 09:26:03 -0400 Received: by mail-ot1-f66.google.com with SMTP id 107so2602827otj.8 for ; Fri, 14 Jun 2019 06:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q0OJmGrN/dUckm8xh8/mUqwvTl2m3MsC/Nix3u2EbOo=; b=qnmZOrT55WICaHNRVQwbPhpDLhQ9v0a+iHtcCyaMhVpCyoneH9oAOuBKoqF9Jhg5Y7 fiMHHhBY5xT45QppZFNTXizLTM28cqcVtay4I/KmcB9PBLkZ+3UISDtysaQpGJAUvD8p FaXdCcyrG6eT2aYg9tfbalMYtjbqJO6ymYuutbIQSMpIZKD0DJqly6nfy0IEaOrsFA3s NgsQ40wco1ktUihHcmvXrLk3Mo7Stsqtcde9pZsHaqQA6xnQkosZhas2AFvQcbJi1Dv7 qqxHhuKPtLo4A92pO77eJ27C09s8xT+N2ETINcJ9D2TOdn5BVdmhElSPO+TsokZM19EW cUXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q0OJmGrN/dUckm8xh8/mUqwvTl2m3MsC/Nix3u2EbOo=; b=HbgVoM3kV7WDDCIOHAtUCIFpoBONiSfjSvHHH4KA8NqPmV/wVLDBDWYR7BvZjRTERZ +iMpvk1ZQd//Bxjospn+jqCYLx29K8uIRXahYlCvttHJn9/7mr3L36wi5mqN7TEhwkep v3SUZiJaF9V7Le1tmX4rHuX0Qs1GDK0VZLH0s4WtDa/s+6mUYQVE3UTi8ycBHLe/zffO iiXHoaqMnkaUAeIz0rTVLw2EyRas1yJCI4rTKnVa/nVs13bsaPNs/nTu70zdnGK4gZnx 1Dk0a5UomUWJ6POIgPX6ROG/ZDQ4zRPcPFgsRTN4MPacfMJPnNud6paRQGq9w+CABd8h aBIQ== X-Gm-Message-State: APjAAAWiQC3JnEIkqRHApQ0Y4gygNbfZ3B68nM+mUALALGSF/RuWu3tP fRPouFIJ/bNPmLzeRZBD7dmpquW/miNBaKW7otM= X-Google-Smtp-Source: APXvYqzZ4yTzZxukuh4ByGQZgpQG6EO0dCIycVqbuDQkexw5XYN6RtEOuxvysNlyk3gw1XEj2+hMGs7NwNxta8Ox7+Q= X-Received: by 2002:a05:6830:16:: with SMTP id c22mr12549596otp.116.1560518762637; Fri, 14 Jun 2019 06:26:02 -0700 (PDT) MIME-Version: 1.0 References: <20190614083959.37944-1-yibin.gong@nxp.com> In-Reply-To: From: Sven Van Asbroeck Date: Fri, 14 Jun 2019 09:25:51 -0400 Message-ID: Subject: Re: [PATCH v1] dmaengine: imx-sdma: remove BD_INTR for channel0 To: Fabio Estevam Cc: Robin Gong , Shawn Guo , Sascha Hauer , Vinod , Dan Williams , NXP Linux Team , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , dmaengine@vger.kernel.org, Sascha Hauer , Michael Olbrich Content-Type: text/plain; charset="UTF-8" Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Fri, Jun 14, 2019 at 6:49 AM Fabio Estevam wrote: > > According to the original report from Sven the issue started to happen > on 5.0, so it would be good to add a Fixes tag and Cc stable so that > this fix could be backported to 5.0/5.1 stable trees. Good catch ! However, the issue is highly timing-dependent. It will come and go depending on the kernel version, devicetree and defconfig. If it works for me on 4.19, that doesn't mean the bug is gone on 4.19. Looking at the commit history, I think the commit below possibly introduced the issue. Until this commit, sdma_run_channel() would wait on the interrupt before proceeding. It has been there since 4.8: Fixes: 1d069bfa3c78 ("dmaengine: imx-sdma: ack channel 0 IRQ in the interrupt handler") But my knowledge of imx-sdma is non-existent, so I invite the more knowledgeable people in this thread to take a look at this commit. [Adding Michael Olbrich to the thread]