From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CBA1C43461 for ; Sun, 9 May 2021 19:20:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8258661288 for ; Sun, 9 May 2021 19:20:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229853AbhEITWA (ORCPT ); Sun, 9 May 2021 15:22:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229666AbhEITV7 (ORCPT ); Sun, 9 May 2021 15:21:59 -0400 Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56904C061574 for ; Sun, 9 May 2021 12:20:55 -0700 (PDT) Received: by mail-oi1-x22d.google.com with SMTP id u16so13889176oiu.7 for ; Sun, 09 May 2021 12:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4GPX6YCdFT0eI9OqiRM8BpJFmnkJ48nTNs5bVOXcOto=; b=W3oEm+Oqv8jLV7JX4eRdNWLtaUGnm18j3ZTtBh3ytvRUvWqMMuZkuTsalW6FwJM1O7 zUy9IpQYFCCLsR5UA1avToB85nZYis468um1kgBb/SwY5TG/CIlZ1bzK034KroZdFLqS 0s2UClL6u5efDdXqywqT3Zh4/b2E4cYf2DJXU/jtyB8Rf0ngt9FJ7sdYfzTz2aBVTgvb vXOD4O0mCV5xLFLNWHc82ZV2MArtTu7PbWHYjBdlnr4rnjLUEkWRtkTVS87WNLE1vnJu 9GRBQp9f7nbi32VxANmKrUXkFGiEIxHnDooT79iM5V1J4eh6t4UYcI9Epnt7xanmWzMh wX2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4GPX6YCdFT0eI9OqiRM8BpJFmnkJ48nTNs5bVOXcOto=; b=T7+SzXZ6WiRIkd+YS7RtvAu0IKs18gfoylj0M2RsodA45/5T4VieCjJT9gBHLMsvt3 iXO4zHVXkarpqPIRccAzQDr9GtMAPYYSoL9Myar26jl3XOysbH5TzcW+ArgWlNhKcC19 jQWc8V0Mv3SdlEp612XoPlsFrla07i+Bs7IwrmDMNndLY2dGLfIE0Y+B7OQZeVPM2vrk HcbATCjHHlNXuv6eS6fzlA9izXCgmYLog/6wd08QY3ukBNIJMllacSgBac6J42fYFvZK lJ3d++olbXT0lKeYD6jRa0UOM3cXAYOC2CEWhOyKbLHt4hobN5gn2rdm0RIPFKESdjDq CzuQ== X-Gm-Message-State: AOAM531u6yxMeqortSQMciD0jMazIouYuFPtUbkZpKndQGVj3Db2OLuq +PibgkAU8qD9Ue5ljXPY7/3otATe7K6PLqNIUGOTri95v7I= X-Google-Smtp-Source: ABdhPJw6+UCBlq3IWslbkvJg6hDx8LHViB9kozY6+DNTnjWO3Xjnwmrth+lDZWe6PVj3aw2O9mJQcyzhFO5f962x7fo= X-Received: by 2002:aca:3dc3:: with SMTP id k186mr23871986oia.126.1620588054621; Sun, 09 May 2021 12:20:54 -0700 (PDT) MIME-Version: 1.0 References: <20210505213731.538612-1-bhupesh.sharma@linaro.org> <20210505213731.538612-15-bhupesh.sharma@linaro.org> In-Reply-To: From: Bhupesh Sharma Date: Mon, 10 May 2021 00:50:43 +0530 Message-ID: Subject: Re: [PATCH v2 14/17] dma: qcom: bam_dma: Create a new header file for BAM DMA driver To: Vinod Koul Cc: linux-arm-msm@vger.kernel.org, Thara Gopinath , Bjorn Andersson , Rob Herring , Andy Gross , Herbert Xu , "David S . Miller" , Stephen Boyd , Michael Turquette , dmaengine@vger.kernel.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bhupesh.linux@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hi Vinod, Thanks for the review. On Sun, 9 May 2021 at 19:28, Vinod Koul wrote: > > On 06-05-21, 03:07, Bhupesh Sharma wrote: > > Create a new header file for BAM DMA driver to make sure > > that it can be included in the follow-up patch to defer probing > > drivers which require BAM DMA driver to be first probed successfully. > > > > Cc: Thara Gopinath > > Cc: Bjorn Andersson > > Cc: Rob Herring > > Cc: Andy Gross > > Cc: Herbert Xu > > Cc: David S. Miller > > Cc: Stephen Boyd > > Cc: Michael Turquette > > Cc: Vinod Koul > > Cc: dmaengine@vger.kernel.org > > Cc: linux-clk@vger.kernel.org > > Cc: linux-crypto@vger.kernel.org > > Cc: devicetree@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: bhupesh.linux@gmail.com > > Signed-off-by: Bhupesh Sharma > > --- > > drivers/dma/qcom/bam_dma.c | 283 +----------------------------------- > > include/soc/qcom/bam_dma.h | 290 +++++++++++++++++++++++++++++++++++++ > > 1. Please use -M with move patches... Oops, will do. > 2. susbsytem is dmaengine > > 3. Why move..? These things are internal to the driver and I dont think > it is wise for clients to use everything here... If the client needs to > know defer probe, it should request a channel and check the status > returned for EPROBE_DEFER Yes, the main intent is to defer the probe of the calling client driver in case the BAM DMA is not probed() yet. Sure, I will make the suggested change in v3, Regards, Bhupesh