From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D40C47097 for ; Fri, 4 Jun 2021 03:42:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0CDF96140B for ; Fri, 4 Jun 2021 03:42:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229886AbhFDDn4 (ORCPT ); Thu, 3 Jun 2021 23:43:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229794AbhFDDn4 (ORCPT ); Thu, 3 Jun 2021 23:43:56 -0400 Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D58A0C0613CE for ; Thu, 3 Jun 2021 20:41:54 -0700 (PDT) Received: by mail-ot1-x329.google.com with SMTP id 69-20020a9d0a4b0000b02902ed42f141e1so7889212otg.2 for ; Thu, 03 Jun 2021 20:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qDKqotNOGIxidneZCpCOFm1Xj7iQGtbVhRVMvdBpFyw=; b=FrW4olx7vH1AWpZD4jiByfMBDwVT9dg4znQeN7xlFnmHlgwgZfuneJl36K8INWvP7S RnDudy0d7iVbU2l1xvdenvPuV4HuItSIRlA7CG2/qt4ye3I/DpVYkTSoy2/+I6DD7GoF HS2ctFuqsS6vAHeld+orfNCC61pfw9MV9kCV6agFhqpAUXNZB8vv2Rw0vD2m/0t+VJnA InK5jZr0vsAfHSeonW30O07YgBryNQ/HtsPAipgo8nzhzJYV6MdIlHkQF23DZdseVV42 x0dJycPdpgaJJ7v4skSAm5C4Y4mGWs5ZxHIjZVvri/joAxcFeY75eTIS5mcCbIGk1BLX c5HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qDKqotNOGIxidneZCpCOFm1Xj7iQGtbVhRVMvdBpFyw=; b=ZWvrvPIEQqu0ewrP8FwrPZGQi+Qcrya4io7hEGIoX8S+jeOmZ6Fz0jcOA9grhgwcAU 4lOxTCPUnzGWU2Iorg1Hb6QTz2JkG0osCtJO4DriAB7ouD5Go/Dh3Mv9CJix2CW7XbgX 4NA7aGjpsCtjY8WTh8JFRRqM3DuPzW4eXmWkHaoLxtbS8Q14aXrskoojhji/NDggdS2X fGhLv5hTLmo8pTyZtPTz8ndQHsXDzY8WhgZwUez7Vs5wFTL8TsDQqG4UgAmIC2WuL2OY tamjMADB3GTdmD7yYROcagv0E5tu6zX4ZzyhrQ2XjIhpwUGnVHaBDlMcKx24AhvEoNfs dJlw== X-Gm-Message-State: AOAM533uXLctkVvk2XmPsBDkLv2DqKTs5nkUl8+6lyAXVYTHAJakDmaL ED+X7IYNlQMvN4ldixRXheUiK7suUNMIA5Y/EDNIfg== X-Google-Smtp-Source: ABdhPJyBlwS4ywW9sYM/BIc6j44E7w/DxEwFdwnUPP5GI2rf2VfVa1kQMxnDXRQPbeqMJpbsxfrDhGUQO3gEMNTgd6s= X-Received: by 2002:a9d:4f15:: with SMTP id d21mr2107757otl.155.1622778112475; Thu, 03 Jun 2021 20:41:52 -0700 (PDT) MIME-Version: 1.0 References: <20210519143700.27392-1-bhupesh.sharma@linaro.org> <20210519143700.27392-5-bhupesh.sharma@linaro.org> <20210521014547.GA2469643@robh.at.kernel.org> In-Reply-To: <20210521014547.GA2469643@robh.at.kernel.org> From: Bhupesh Sharma Date: Fri, 4 Jun 2021 09:11:41 +0530 Message-ID: Subject: Re: [PATCH v3 04/17] dt-bindings: qcom-qce: Convert bindings to yaml To: Rob Herring Cc: linux-arm-msm@vger.kernel.org, Thara Gopinath , Bjorn Andersson , Andy Gross , Herbert Xu , "David S . Miller" , Stephen Boyd , Michael Turquette , Vinod Koul , dmaengine@vger.kernel.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bhupesh.linux@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hi Rob, On Fri, 21 May 2021 at 07:15, Rob Herring wrote: > > On Wed, May 19, 2021 at 08:06:47PM +0530, Bhupesh Sharma wrote: > > Convert Qualcomm QCE crypto devicetree binding to YAML. > > > > Cc: Thara Gopinath > > Cc: Bjorn Andersson > > Cc: Rob Herring > > Cc: Andy Gross > > Cc: Herbert Xu > > Cc: David S. Miller > > Cc: Stephen Boyd > > Cc: Michael Turquette > > Cc: Vinod Koul > > Cc: dmaengine@vger.kernel.org > > Cc: linux-clk@vger.kernel.org > > Cc: linux-crypto@vger.kernel.org > > Cc: devicetree@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: bhupesh.linux@gmail.com > > Signed-off-by: Bhupesh Sharma > > --- > > .../devicetree/bindings/crypto/qcom-qce.txt | 25 ------- > > .../devicetree/bindings/crypto/qcom-qce.yaml | 69 +++++++++++++++++++ > > 2 files changed, 69 insertions(+), 25 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/crypto/qcom-qce.txt > > create mode 100644 Documentation/devicetree/bindings/crypto/qcom-qce.yaml > > > > diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.txt b/Documentation/devicetree/bindings/crypto/qcom-qce.txt > > deleted file mode 100644 > > index fdd53b184ba8..000000000000 > > --- a/Documentation/devicetree/bindings/crypto/qcom-qce.txt > > +++ /dev/null > > @@ -1,25 +0,0 @@ > > -Qualcomm crypto engine driver > > - > > -Required properties: > > - > > -- compatible : should be "qcom,crypto-v5.1" > > -- reg : specifies base physical address and size of the registers map > > -- clocks : phandle to clock-controller plus clock-specifier pair > > -- clock-names : "iface" clocks register interface > > - "bus" clocks data transfer interface > > - "core" clocks rest of the crypto block > > -- dmas : DMA specifiers for tx and rx dma channels. For more see > > - Documentation/devicetree/bindings/dma/dma.txt > > -- dma-names : DMA request names should be "rx" and "tx" > > - > > -Example: > > - crypto@fd45a000 { > > - compatible = "qcom,crypto-v5.1"; > > - reg = <0xfd45a000 0x6000>; > > - clocks = <&gcc GCC_CE2_AHB_CLK>, > > - <&gcc GCC_CE2_AXI_CLK>, > > - <&gcc GCC_CE2_CLK>; > > - clock-names = "iface", "bus", "core"; > > - dmas = <&cryptobam 2>, <&cryptobam 3>; > > - dma-names = "rx", "tx"; > > - }; > > diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > > new file mode 100644 > > index 000000000000..a691cd08f372 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > > @@ -0,0 +1,69 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/crypto/qcom-qce.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm crypto engine driver > > + > > +maintainers: > > + - Bhupesh Sharma > > + > > +description: | > > + This document defines the binding for the QCE crypto > > + controller found on Qualcomm parts. > > + > > +properties: > > + compatible: > > + const: qcom,crypto-v5.1 > > + > > + reg: > > + maxItems: 1 > > + description: | > > + Specifies base physical address and size of the registers map. > > Yep, that's every 'reg'. Drop. > > With that dropped, > > Reviewed-by: Rob Herring Ok, I will drop this in v4. Thanks, Bhupesh > > + > > + clocks: > > + items: > > + - description: iface clocks register interface. > > + - description: bus clocks data transfer interface. > > + - description: core clocks rest of the crypto block. > > + > > + clock-names: > > + items: > > + - const: iface > > + - const: bus > > + - const: core > > + > > + dmas: > > + items: > > + - description: DMA specifiers for tx dma channel. > > + - description: DMA specifiers for rx dma channel. > > + > > + dma-names: > > + items: > > + - const: rx > > + - const: tx > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - clock-names > > + - dmas > > + - dma-names > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + crypto-engine@fd45a000 { > > + compatible = "qcom,crypto-v5.1"; > > + reg = <0xfd45a000 0x6000>; > > + clocks = <&gcc GCC_CE2_AHB_CLK>, > > + <&gcc GCC_CE2_AXI_CLK>, > > + <&gcc GCC_CE2_CLK>; > > + clock-names = "iface", "bus", "core"; > > + dmas = <&cryptobam 2>, <&cryptobam 3>; > > + dma-names = "rx", "tx"; > > + }; > > -- > > 2.31.1 > >