From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Tony Lindgren <tony@atomide.com>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
Alexandre Bailon <abailon@baylibre.com>, Bin Liu <b-liu@ti.com>,
Daniel Mack <zonque@gmail.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
George Cherian <george.cherian@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Johan Hovold <johan@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Sekhar Nori <nsekhar@ti.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
dmaengine <dmaengine@vger.kernel.org>,
USB <linux-usb@vger.kernel.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
giulio.benetti@benettiengineering.com,
Sebastian Reichel <sre@kernel.org>,
Skvortsov <andrej.skvortzov@gmail.com>,
Yegor Yefremov <yegorslists@googlemail.com>
Subject: Re: [PATCH] dmaengine: cppi41: Fix cppi41_dma_prep_slave_sg() when idle
Date: Wed, 23 Oct 2019 21:58:30 +0300 [thread overview]
Message-ID: <CAHp75VfyTJ+ptA8+AAgRgUNETLu=5EBc=bO7tmNhgxtdQq4EUw@mail.gmail.com> (raw)
In-Reply-To: <6996a5de-215b-f9a2-1aeb-5eeed1b7cf8d@cogentembedded.com>
On Wed, Oct 23, 2019 at 9:55 PM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 10/23/2019 06:31 PM, Tony Lindgren wrote:
> > + int error;
> > +
> > + error = pm_runtime_get(cdd->ddev.dev);
> > + if (error < 0) {
>
> I'd call that variable 'status', comparison (error < 0) just doesn't look right.
> If it was *if* (error), it would have been more correct.
It's error when it's negative. That's how PM runtime is designed.
> > + pm_runtime_put_noidle(cdd->ddev.dev);
> > +
> > + return NULL;
> > + }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-10-23 18:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 15:31 [PATCH] dmaengine: cppi41: Fix cppi41_dma_prep_slave_sg() when idle Tony Lindgren
2019-10-23 15:52 ` Vinod Koul
2019-10-23 17:04 ` Peter Ujfalusi
2019-10-23 17:16 ` Tony Lindgren
2019-10-23 19:02 ` Peter Ujfalusi
2019-10-23 19:18 ` Tony Lindgren
2019-10-23 19:55 ` Peter Ujfalusi
2019-10-23 20:18 ` Tony Lindgren
2019-10-23 20:55 ` Grygorii Strashko
2019-10-23 21:27 ` Tony Lindgren
2019-10-23 21:43 ` Grygorii Strashko
2019-10-23 21:49 ` Tony Lindgren
2019-10-24 8:52 ` Peter Ujfalusi
2019-10-24 11:22 ` Andy Shevchenko
2019-10-24 14:00 ` Tony Lindgren
2019-10-23 18:55 ` Sergei Shtylyov
2019-10-23 18:58 ` Andy Shevchenko [this message]
2019-10-23 19:19 ` Sergei Shtylyov
2019-10-23 19:00 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfyTJ+ptA8+AAgRgUNETLu=5EBc=bO7tmNhgxtdQq4EUw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=abailon@baylibre.com \
--cc=andrej.skvortzov@gmail.com \
--cc=b-liu@ti.com \
--cc=bigeasy@linutronix.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=george.cherian@ti.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=grygorii.strashko@ti.com \
--cc=johan@kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
--cc=vinod.koul@intel.com \
--cc=yegorslists@googlemail.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).