From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51500C432C3 for ; Thu, 14 Nov 2019 10:53:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B8FA206F0 for ; Thu, 14 Nov 2019 10:53:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="hvzFvQO7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726960AbfKNKxj (ORCPT ); Thu, 14 Nov 2019 05:53:39 -0500 Received: from mail-io1-f67.google.com ([209.85.166.67]:37948 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726106AbfKNKxj (ORCPT ); Thu, 14 Nov 2019 05:53:39 -0500 Received: by mail-io1-f67.google.com with SMTP id i13so6290876ioj.5 for ; Thu, 14 Nov 2019 02:53:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Kc1/vTjFDnJ6RXRT1JfBA3hLPFiKVT3unzuRtbwelRQ=; b=hvzFvQO7iwFtVGzpjj/Maiqd069dCHHQRZr66u+oC+RQ1n+onzGFN2lFQyU7+ki5Nt X3c3lwpx/09gSFw9oZsytsBMgFMLyLarOOpIMbLhDHkbmObM/6ddkY6niO8e8pzoCygg W1A2GlQSLF6PLnckXx2TGtGPdwFGkV1r33rkH0iS+Uaz+oaA7VOiSv/Il/7bUKFTm4lQ zlPQAs4GXxa+7MuK+3lU09La6r2BEWna8dDKT+hvmDm9LbPT8b/fRUFwyDs6meFARJTr 2ZTknw4Rw8HFpc2I50vVO08psCbJDF4v3rIgHWmmPQaJgB+3u/wElMqGnLfiUdpaUaIQ 4eCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Kc1/vTjFDnJ6RXRT1JfBA3hLPFiKVT3unzuRtbwelRQ=; b=fYok6GB+3Q0yv/VUSx4LeHefoVc4lFj53UKtiyz3QH4gE7eDkwRhZuJeBHQH2nHSWh Y66CD8BFJcCG2Yc3bFSjYebIlOqRm97KEVLbv/hwE/jnycrvuFoSKk9i8bKx+dpI1mOR 2CHnLIa9DwJWupinQ1j5Q6BCiMCUeaITFUd3SDZtl6H+kFcIooP5McWWOOcF/7FEYQ+z 3dNXz8jogXVFDNaf6IEvBz6YyDkmGbAwebwQCYZQbzRtQuFEUfRqJ8JXevt6GNHulgo0 ay3hvH9Wo2KbVNcYDHl7waDj/Srdi5f4vuBxUXDp7yg+SNcvHyakANDn8qxZ15Lf8jey Iesg== X-Gm-Message-State: APjAAAWoGwqmFWwBCwjIfxYWrAla5rauVZasVStXwgHzbjISAK/8SMyD l4BSpcGXi8Zny7NOlL+kf6f3SRp9GFgxB/wvZqGdJg== X-Google-Smtp-Source: APXvYqwAEZUqjQiKuLs/wQ808KcqyDjY/QSLEFXpvnVRqBTItldaB74gt5LHaetoQeAUw00tv7D7uTNxdb8HFM/8Dxk= X-Received: by 2002:a6b:5f0e:: with SMTP id t14mr8298204iob.228.1573728818553; Thu, 14 Nov 2019 02:53:38 -0800 (PST) MIME-Version: 1.0 References: <20191107084955.7580-1-green.wan@sifive.com> <20191114071551.GQ952516@vkoul-mobl> In-Reply-To: <20191114071551.GQ952516@vkoul-mobl> From: Green Wan Date: Thu, 14 Nov 2019 18:53:28 +0800 Message-ID: Subject: Re: [PATCH v6 0/4] dmaengine: sf-pdma: Add platform dma driver To: Vinod Koul Cc: Rob Herring , Mark Rutland , Palmer Dabbelt , Paul Walmsley , Albert Ou , Dan Williams , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Jonathan Cameron , "Paul E. McKenney" , Bin Meng , Yash Shah , Sagar Kadam , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Thanks, Vinod, I found there are "/**" in the beginning of files but not for commenting function purpose. Those comments cause kernel-doc W=1 warning. I've fixed them and rebased to latest source. will send the patch after running regression tests soon. -- Green On Thu, Nov 14, 2019 at 3:15 PM Vinod Koul wrote: > > On 07-11-19, 16:49, Green Wan wrote: > > Add PDMA driver support for SiFive HiFive Unleashed RevA00 board. Mainly follows > > DMAengine controller doc[1] to implement and take other DMA drivers as reference. > > Such as > > > > - drivers/dma/fsl-edma.c > > - drivers/dma/dw-edma/ > > - drivers/dma/pxa-dma.c > > > > Using DMA test client[2] to test. Detailed datasheet is doc[3]. Driver supports: > > > > - 4 physical DMA channels, share same DONE and error interrupt handler. > > - Support MEM_TO_MEM > > - Tested by DMA test client > > - patches include DT Bindgins document and dts for fu450-c000 SoC. Separate dts > > patch for easier review and apply to different branch or SoC platform. > > - retry 1 time if DMA error occurs. > > I have applied this expect dt change. I see some warns due to missing > kernel-doc style comments with W=1, please fix that and send update on > top of these > > Thanks > -- > ~Vinod