From: Rob Herring <robh@kernel.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Hyun Kwon <hyun.kwon@xilinx.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Vinod Koul <vkoul@kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
"open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM"
<dmaengine@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: Fix 'reg' size issues in zynqmp examples
Date: Tue, 29 Sep 2020 09:55:43 -0500 [thread overview]
Message-ID: <CAL_JsqL6z5zarTv4e1aWCi0rVoyoDOvZYpYLEuxMJF5a1i7yHQ@mail.gmail.com> (raw)
In-Reply-To: <68d57be8-c2e9-4bfd-4f7f-041aa3ce2e92@xilinx.com>
On Tue, Sep 29, 2020 at 1:55 AM Michal Simek <michal.simek@xilinx.com> wrote:
>
> Hi Rob,
>
> On 28. 09. 20 17:59, Rob Herring wrote:
> > The default sizes in examples for 'reg' are 1 cell each. Fix the
> > incorrect sizes in zynqmp examples:
> >
> > Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.example.dt.yaml: example-0: dma-controller@fd4c0000:reg:0: [0, 4249616384, 0, 4096] is too long
> > From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
> > Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:0: [0, 4249485312, 0, 4096] is too long
> > From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
> > Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:1: [0, 4249526272, 0, 4096] is too long
> > From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
> > Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:2: [0, 4249530368, 0, 4096] is too long
> > From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
> > Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:3: [0, 4249534464, 0, 4096] is too long
> > From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
> >
> > Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: Michal Simek <michal.simek@xilinx.com>
> > Cc: Vinod Koul <vkoul@kernel.org>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: dmaengine@vger.kernel.org
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > .../bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 8 ++++----
> > .../devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml | 2 +-
> > 2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> > index 52a939cade3b..7b9d468c3e52 100644
> > --- a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> > +++ b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> > @@ -145,10 +145,10 @@ examples:
> >
> > display@fd4a0000 {
> > compatible = "xlnx,zynqmp-dpsub-1.7";
> > - reg = <0x0 0xfd4a0000 0x0 0x1000>,
> > - <0x0 0xfd4aa000 0x0 0x1000>,
> > - <0x0 0xfd4ab000 0x0 0x1000>,
> > - <0x0 0xfd4ac000 0x0 0x1000>;
> > + reg = <0xfd4a0000 0x1000>,
> > + <0xfd4aa000 0x1000>,
> > + <0xfd4ab000 0x1000>,
> > + <0xfd4ac000 0x1000>;
> > reg-names = "dp", "blend", "av_buf", "aud";
> > interrupts = <0 119 4>;
> > interrupt-parent = <&gic>;
> > diff --git a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml
> > index 5de510f8c88c..2a595b18ff6c 100644
> > --- a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml
> > @@ -57,7 +57,7 @@ examples:
> >
> > dma: dma-controller@fd4c0000 {
> > compatible = "xlnx,zynqmp-dpdma";
> > - reg = <0x0 0xfd4c0000 0x0 0x1000>;
> > + reg = <0xfd4c0000 0x1000>;
> > interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>;
> > interrupt-parent = <&gic>;
> > clocks = <&dpdma_clk>;
> >
>
> I would prefer to keep 64bit version.
> I use this style.
I prefer to keep the examples simple. The address size is outside the
scope of the binding.
Rob
next prev parent reply other threads:[~2020-09-29 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 15:59 [PATCH] dt-bindings: Fix 'reg' size issues in zynqmp examples Rob Herring
2020-09-29 6:55 ` Michal Simek
2020-09-29 14:55 ` Rob Herring [this message]
2020-09-29 16:21 ` Michal Simek
2020-10-05 4:51 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqL6z5zarTv4e1aWCi0rVoyoDOvZYpYLEuxMJF5a1i7yHQ@mail.gmail.com \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hyun.kwon@xilinx.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).