From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E13C433E1 for ; Tue, 14 Jul 2020 08:09:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10072217A0 for ; Tue, 14 Jul 2020 08:09:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725884AbgGNIJi (ORCPT ); Tue, 14 Jul 2020 04:09:38 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:36962 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725793AbgGNIJi (ORCPT ); Tue, 14 Jul 2020 04:09:38 -0400 Received: by mail-oi1-f194.google.com with SMTP id 12so13268749oir.4; Tue, 14 Jul 2020 01:09:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kQd/3+NgYL5ETBCqN/I6t615NftKK//t8YpCv8X+l+8=; b=L79lDTg5z+Wr8CrXu4B47bF4ahswvDDmZ0H/Qy/qa9Fo+XQYlDPLw9aqaQLZXqLQ/2 BXkk5/b/9JWNo8aBf0dZ3bNGBz4QCNYoh39pOIiaOfd3ojyTvKUSv+mlF7ByXRarB0m8 p0IAsFE2pP+t9NzaUcaeflghIosdBFVXGqkWBwHUvJ+Lx0uG0zmNGOE4sjXI288H39Uh nlIDJJuACYfyKEH7+Qbu/2M2dlJodA+RM0CPznBlF4DI0GnyzJ25FjpDRzQ/ztIB5iNg Izob0WAA1Jw3mXmTKFcyRFd5nkxWo6o3s7QU0ChSVQsC+i0MeScSD5jVw49BJULxQXF6 jSfA== X-Gm-Message-State: AOAM532Ka1CwR5iO1M7/Vtqob7jdCvTCM6mtMQPM80OJ6rhifWZK1L+J 35UC956Ic405nS9CHgjg1s+levydKxXA/lvt4PY= X-Google-Smtp-Source: ABdhPJz7hdIV/baG1FFq5NebTyyKrvGlXKfMdm90XT59CL4jYHtqaTc+X/vLw/NAnF5ngIMw26ZC9YKmVtr4fJbw2xI= X-Received: by 2002:aca:ac10:: with SMTP id v16mr2565069oie.153.1594714176638; Tue, 14 Jul 2020 01:09:36 -0700 (PDT) MIME-Version: 1.0 References: <1594676120-5862-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> <1594676120-5862-3-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <1594676120-5862-3-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Geert Uytterhoeven Date: Tue, 14 Jul 2020 10:09:25 +0200 Message-ID: Subject: Re: [PATCH 2/9] iommu/ipmmu-vmsa: Hook up R8A774E1 DT matching code To: Lad Prabhakar Cc: Vinod Koul , Rob Herring , Linus Walleij , Bartosz Golaszewski , Joerg Roedel , Sergei Shtylyov , "David S. Miller" , Jakub Kicinski , Magnus Damm , Yoshihiro Shimoda , dmaengine , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:GPIO SUBSYSTEM" , Linux IOMMU , netdev , Linux-Renesas , Linux Kernel Mailing List , Prabhakar Content-Type: text/plain; charset="UTF-8" Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hi Prabhakar, On Mon, Jul 13, 2020 at 11:35 PM Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Add support for RZ/G2H (R8A774E1) SoC IPMMUs. > > Signed-off-by: Marian-Cristian Rotariu > Signed-off-by: Lad Prabhakar Thanks for your patch! > --- a/drivers/iommu/ipmmu-vmsa.c > +++ b/drivers/iommu/ipmmu-vmsa.c > @@ -751,6 +751,7 @@ static const struct soc_device_attribute soc_rcar_gen3[] = { > static const struct soc_device_attribute soc_rcar_gen3_whitelist[] = { > { .soc_id = "r8a774b1", }, > { .soc_id = "r8a774c0", }, > + { .soc_id = "r8a774e1", }, Adding an entry to soc_rcar_gen3_whitelist[] doesn't do anything, unless you also add the same entry to soc_rcar_gen3[]. > { .soc_id = "r8a7795", .revision = "ES3.*" }, > { .soc_id = "r8a77961", }, > { .soc_id = "r8a77965", }, > @@ -963,6 +964,9 @@ static const struct of_device_id ipmmu_of_ids[] = { > }, { > .compatible = "renesas,ipmmu-r8a774c0", > .data = &ipmmu_features_rcar_gen3, > + }, { > + .compatible = "renesas,ipmmu-r8a774e1", > + .data = &ipmmu_features_rcar_gen3, > }, { > .compatible = "renesas,ipmmu-r8a7795", > .data = &ipmmu_features_rcar_gen3, Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds