From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [4/7] dmaengine: sprd: Add device validation to support multiple controllers From: Baolin Wang Message-Id: Date: Tue, 30 Apr 2019 16:53:32 +0800 To: Vinod Koul Cc: Dan Williams , eric.long@unisoc.com, Orson Zhai , Chunyan Zhang , Mark Brown , dmaengine@vger.kernel.org, LKML List-ID: SGkgVmlub2QsCgpPbiBUdWUsIDMwIEFwciAyMDE5IGF0IDE2OjM0LCBCYW9saW4gV2FuZyA8YmFv bGluLndhbmdAbGluYXJvLm9yZz4gd3JvdGU6Cj4KPiBPbiBUdWUsIDMwIEFwciAyMDE5IGF0IDE2 OjMwLCBWaW5vZCBLb3VsIDx2a291bEBrZXJuZWwub3JnPiB3cm90ZToKPiA+Cj4gPiBPbiAzMC0w NC0xOSwgMTM6MzAsIEJhb2xpbiBXYW5nIHdyb3RlOgo+ID4gPiBPbiBNb24sIDI5IEFwciAyMDE5 IGF0IDIyOjA1LCBWaW5vZCBLb3VsIDx2a291bEBrZXJuZWwub3JnPiB3cm90ZToKPiA+ID4gPgo+ ID4gPiA+IE9uIDI5LTA0LTE5LCAyMDoyMCwgQmFvbGluIFdhbmcgd3JvdGU6Cj4gPiA+ID4gPiBP biBNb24sIDI5IEFwciAyMDE5IGF0IDE5OjU3LCBWaW5vZCBLb3VsIDx2a291bEBrZXJuZWwub3Jn PiB3cm90ZToKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gT24gMTUtMDQtMTksIDIwOjE0LCBCYW9s aW4gV2FuZyB3cm90ZToKPiA+ID4gPiA+ID4gPiBGcm9tOiBFcmljIExvbmcgPGVyaWMubG9uZ0B1 bmlzb2MuY29tPgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gU2luY2Ugd2UgY2FuIHN1cHBv cnQgbXVsdGlwbGUgRE1BIGVuZ2luZSBjb250cm9sbGVycywgd2Ugc2hvdWxkIGFkZAo+ID4gPiA+ ID4gPiA+IGRldmljZSB2YWxpZGF0aW9uIGluIGZpbHRlciBmdW5jdGlvbiB0byBjaGVjayBpZiB0 aGUgY29ycmVjdCBjb250cm9sbGVyCj4gPiA+ID4gPiA+ID4gdG8gYmUgcmVxdWVzdGVkLgo+ID4g PiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogRXJpYyBMb25nIDxlcmljLmxv bmdAdW5pc29jLmNvbT4KPiA+ID4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBCYW9saW4gV2FuZyA8 YmFvbGluLndhbmdAbGluYXJvLm9yZz4KPiA+ID4gPiA+ID4gPiAtLS0KPiA+ID4gPiA+ID4gPiAg ZHJpdmVycy9kbWEvc3ByZC1kbWEuYyB8ICAgIDUgKysrKysKPiA+ID4gPiA+ID4gPiAgMSBmaWxl IGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKQo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZG1hL3NwcmQtZG1hLmMgYi9kcml2ZXJzL2RtYS9zcHJkLWRtYS5j Cj4gPiA+ID4gPiA+ID4gaW5kZXggMGY5MmU2MC4uOWY5OWQ0YiAxMDA2NDQKPiA+ID4gPiA+ID4g PiAtLS0gYS9kcml2ZXJzL2RtYS9zcHJkLWRtYS5jCj4gPiA+ID4gPiA+ID4gKysrIGIvZHJpdmVy cy9kbWEvc3ByZC1kbWEuYwo+ID4gPiA+ID4gPiA+IEBAIC0xMDIwLDggKzEwMjAsMTMgQEAgc3Rh dGljIHZvaWQgc3ByZF9kbWFfZnJlZV9kZXNjKHN0cnVjdCB2aXJ0X2RtYV9kZXNjICp2ZCkKPiA+ ID4gPiA+ID4gPiAgc3RhdGljIGJvb2wgc3ByZF9kbWFfZmlsdGVyX2ZuKHN0cnVjdCBkbWFfY2hh biAqY2hhbiwgdm9pZCAqcGFyYW0pCj4gPiA+ID4gPiA+ID4gIHsKPiA+ID4gPiA+ID4gPiAgICAg ICBzdHJ1Y3Qgc3ByZF9kbWFfY2huICpzY2hhbiA9IHRvX3NwcmRfZG1hX2NoYW4oY2hhbik7Cj4g PiA+ID4gPiA+ID4gKyAgICAgc3RydWN0IG9mX3BoYW5kbGVfYXJncyAqZG1hX3NwZWMgPQo+ID4g PiA+ID4gPiA+ICsgICAgICAgICAgICAgY29udGFpbmVyX29mKHBhcmFtLCBzdHJ1Y3Qgb2ZfcGhh bmRsZV9hcmdzLCBhcmdzWzBdKTsKPiA+ID4gPiA+ID4gPiAgICAgICB1MzIgc2xhdmVfaWQgPSAq KHUzMiAqKXBhcmFtOwo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gKyAgICAgaWYgKGNoYW4t PmRldmljZS0+ZGV2LT5vZl9ub2RlICE9IGRtYV9zcGVjLT5ucCkKPiA+ID4gPiA+ID4KPiA+ID4g PiA+ID4gQXJlIHlvdSBub3QgdXNpbmcgb2ZfZG1hX2ZpbmRfY29udHJvbGxlcigpIHRoYXQgZG9l cyB0aGlzLCBzbyB0aGlzIHdvdWxkCj4gPiA+ID4gPiA+IGJlIHVzZWxlc3MhCj4gPiA+ID4gPgo+ ID4gPiA+ID4gWWVzLCB3ZSBjYW4gdXNlIG9mX2RtYV9maW5kX2NvbnRyb2xsZXIoKSwgYnV0IHRo YXQgd2lsbCBiZSBhIGxpdHRsZQo+ID4gPiA+ID4gY29tcGxpY2F0ZWQgdGhhbiBjdXJyZW50IHNv bHV0aW9uLiBTaW5jZSB3ZSBuZWVkIGludHJvZHVjZSBvbmUKPiA+ID4gPiA+IHN0cnVjdHVyZSB0 byBzYXZlIHRoZSBub2RlIHRvIHZhbGlkYXRlIGluIHRoZSBmaWx0ZXIgZnVuY3Rpb24gbGlrZQo+ ID4gPiA+ID4gYmVsb3csIHdoaWNoIHNlZW1zIG1ha2UgdGhpbmdzIGNvbXBsaWNhdGVkLiBCdXQg aWYgeW91IHN0aWxsIGxpa2UgdG8KPiA+ID4gPiA+IHVzZSBvZl9kbWFfZmluZF9jb250cm9sbGVy KCksIEkgY2FuIGNoYW5nZSB0byB1c2UgaXQgaW4gbmV4dCB2ZXJzaW9uLgo+ID4gPiA+Cj4gPiA+ ID4gU29ycnkgSSBzaG91bGQgaGF2ZSBjbGFyaWZpZWQgbW9yZS4uCj4gPiA+ID4KPiA+ID4gPiBv Zl9kbWFfZmluZF9jb250cm9sbGVyKCkgaXMgY2FsbGVkIGJ5IHhsYXRlLCBzbyB5b3UgYWxyZWFk eSBydW4gdGhpcwo+ID4gPiA+IGNoZWNrLCBzbyB3aHkgdXNlIHRoaXMgOikKPiA+ID4KPiA+ID4g VGhlIG9mX2RtYV9maW5kX2NvbnRyb2xsZXIoKSBjYW4gc2F2ZSB0aGUgcmVxdWVzdGVkIGRldmlj ZSBub2RlIGludG8KPiA+ID4gZG1hX3NwZWMsIGFuZCBpbiB0aGUgb2ZfZG1hX3NpbXBsZV94bGF0 ZSgpIGZ1bmN0aW9uLCBpdCB3aWxsIGNhbGwKPiA+ID4gZG1hX3JlcXVlc3RfY2hhbm5lbCgpIHRv IHJlcXVlc3Qgb25lIGNoYW5uZWwsIGJ1dCBpdCBkaWQgbm90IHZhbGlkYXRlCj4gPiA+IHRoZSBk ZXZpY2Ugbm9kZSB0byBmaW5kIHRoZSBjb3JyZXNwb25kaW5nIGRtYSBkZXZpY2UgaW4KPiA+ID4g ZG1hX3JlcXVlc3RfY2hhbm5lbCgpLiBTbyB3ZSBzaG91bGQgaW4gb3VyIGZpbHRlciBmdW5jdGlv biB0byB2YWxpZGF0ZQo+ID4gPiB0aGUgZGV2aWNlIG5vZGUgd2l0aCB0aGUgZGV2aWNlIG5vZGUg c3BlY2lmaWVkIGJ5IHRoZSBkbWFfc3BlYy4gSG9wZSBJCj4gPiA+IG1ha2UgdGhpbmdzIGNsZWFy Lgo+ID4KPiA+IEJ1dCBkbWFfcmVxdWVzdF9jaGFubmVsKCkgY2FsbHMgb2ZfZG1hX3JlcXVlc3Rf c2xhdmVfY2hhbm5lbCgpIHdoaWNoCj4gPiBpbnZva2VzIG9mX2RtYV9maW5kX2NvbnRyb2xsZXIo KSB3aHkgaXMgaXQgYnJva2VuIGZvciB5b3UgaWYgdGhhdCBpcyB0aGUKPiA+IGNhc2UuLgo+Cj4g Tm8sdGhlIGNhbGxpbmcgcHJvY2VzcyBzaG91bGQgYmU6Cj4gZG1hX3JlcXVlc3Rfc2xhdmVfY2hh bm5lbCgpCj4gLS0tPmRtYV9yZXF1ZXN0X2NoYW4oKS0tLT5vZl9kbWFfcmVxdWVzdF9zbGF2ZV9j aGFubmVsKCktLS0tPm9mX2RtYV9zaW1wbGVfeGxhdGUoKQo+IC0tLS0+IGRtYV9yZXF1ZXN0X2No YW5uZWwoKS4KPgoKWW91IGNhbiBjaGVjayBvdGhlciBkcml2ZXJzLCB0aGV5IGFsc28gd2lsbCBz YXZlIHRoZSBkZXZpY2Ugbm9kZSB0bwp2YWxpZGF0ZSBpbiB0aGVpciBmaWx0ZXIgZnVuY3Rpb24u CkZvciBleGFtcGxlIHRoZSBpbXgtc2RtYSBkcml2ZXI6Cmh0dHBzOi8vZWxpeGlyLmJvb3RsaW4u Y29tL2xpbnV4L3Y1LjEtcmM2L3NvdXJjZS9kcml2ZXJzL2RtYS9pbXgtc2RtYS5jI0wxOTMxCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A93F1C43219 for ; Tue, 30 Apr 2019 08:53:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A4F421670 for ; Tue, 30 Apr 2019 08:53:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OAe1zycT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726668AbfD3Ixp (ORCPT ); Tue, 30 Apr 2019 04:53:45 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:42614 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbfD3Ixp (ORCPT ); Tue, 30 Apr 2019 04:53:45 -0400 Received: by mail-oi1-f195.google.com with SMTP id k9so7593986oig.9 for ; Tue, 30 Apr 2019 01:53:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A8/NEuA9marorl0ixlh/3shrh19pr40I3KqHuo9ZWlE=; b=OAe1zycT9lDlKZVighchQ6eYIy0XmGyjFcKMqUYoeryriWN1KoF3rGGIXMpOm1MOSW wgUx0cDHR3zb0tvqC9URlP1WM45RF6izTv/+uwYLDj99eI5wPP8y+aaAyVKzmFAjqAlC feJmhPrZF31W8VYorttnQ6+BZVtwXGTJempUyobcpGMhYT7H22ZWlravqZqnJYUbV5zc ktSOYP9QtbDUpUQn5egp/kHSOzXG5SISQnQgsDJ8VlWbvz3pltax2xuK7zNlJFAiI1NR SVJrMACuAzxXNHg+e6TGZ7trsDl8ZQ+C7oJzDbnHWL+BKCgvV+oYmcq8ZJEaqWV8fZ27 IcdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A8/NEuA9marorl0ixlh/3shrh19pr40I3KqHuo9ZWlE=; b=WOaUaEEQpe/5u4YH2udR2bbaOp8X6pkNmUEd8Wd/YIyuwaX9oSgxr0GnpiUufgw0tL +1akBHfExYviSsQ3fdkvsVaBcLrUyv0PcSZBg5o7Jr2tJu9NgIJ+MVDTp5TejOYTiG1n R3YjkVqOOnq/R+6DCUd82StquvcpzuHafX8ae6alWEz8ATBouUWtykY4dCSZkWeUh/UM 8+iX0sc300KRebL9hx9LnYg2Dc/lffFEuNFgywo/22z/CPsOtASIwwNJN0UDAeayhAyi 3yer1lBBtZBbKCbo+52acBAgzXUpSfuSXQDaGfKX7Tj7sIfXT0wNaPuEG/gfDFrvdnyU s9/w== X-Gm-Message-State: APjAAAVVRypkxZXRVoWSE7iyg0yX+fmMLfI6mnnNDb79b76C7bJ54ZpZ RL5vfPx5I+FWBpwLaO8StQxytejn7sxnSgi9+OpyYg== X-Google-Smtp-Source: APXvYqwtAPgDAo5ewm/8SWWaA1+o4UOZZmMGy268pyU4RTnAt8OUNfnqJVpWboYxwh48ndcMExsT4WmicraSu+Dg5hg= X-Received: by 2002:aca:ba0b:: with SMTP id k11mr2230922oif.57.1556614424087; Tue, 30 Apr 2019 01:53:44 -0700 (PDT) MIME-Version: 1.0 References: <20190429115723.GK3845@vkoul-mobl.Dlink> <20190429140537.GN3845@vkoul-mobl.Dlink> <20190430082954.GQ3845@vkoul-mobl.Dlink> In-Reply-To: From: Baolin Wang Date: Tue, 30 Apr 2019 16:53:32 +0800 Message-ID: Subject: Re: [PATCH 4/7] dmaengine: sprd: Add device validation to support multiple controllers To: Vinod Koul Cc: Dan Williams , eric.long@unisoc.com, Orson Zhai , Chunyan Zhang , Mark Brown , dmaengine@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Message-ID: <20190430085332.d9yd_jYT9XLQ4_8zj8omYR4z6LYP1n_J9V3nUuNVFfM@z> Hi Vinod, On Tue, 30 Apr 2019 at 16:34, Baolin Wang wrote: > > On Tue, 30 Apr 2019 at 16:30, Vinod Koul wrote: > > > > On 30-04-19, 13:30, Baolin Wang wrote: > > > On Mon, 29 Apr 2019 at 22:05, Vinod Koul wrote: > > > > > > > > On 29-04-19, 20:20, Baolin Wang wrote: > > > > > On Mon, 29 Apr 2019 at 19:57, Vinod Koul wrote: > > > > > > > > > > > > On 15-04-19, 20:14, Baolin Wang wrote: > > > > > > > From: Eric Long > > > > > > > > > > > > > > Since we can support multiple DMA engine controllers, we should add > > > > > > > device validation in filter function to check if the correct controller > > > > > > > to be requested. > > > > > > > > > > > > > > Signed-off-by: Eric Long > > > > > > > Signed-off-by: Baolin Wang > > > > > > > --- > > > > > > > drivers/dma/sprd-dma.c | 5 +++++ > > > > > > > 1 file changed, 5 insertions(+) > > > > > > > > > > > > > > diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c > > > > > > > index 0f92e60..9f99d4b 100644 > > > > > > > --- a/drivers/dma/sprd-dma.c > > > > > > > +++ b/drivers/dma/sprd-dma.c > > > > > > > @@ -1020,8 +1020,13 @@ static void sprd_dma_free_desc(struct virt_dma_desc *vd) > > > > > > > static bool sprd_dma_filter_fn(struct dma_chan *chan, void *param) > > > > > > > { > > > > > > > struct sprd_dma_chn *schan = to_sprd_dma_chan(chan); > > > > > > > + struct of_phandle_args *dma_spec = > > > > > > > + container_of(param, struct of_phandle_args, args[0]); > > > > > > > u32 slave_id = *(u32 *)param; > > > > > > > > > > > > > > + if (chan->device->dev->of_node != dma_spec->np) > > > > > > > > > > > > Are you not using of_dma_find_controller() that does this, so this would > > > > > > be useless! > > > > > > > > > > Yes, we can use of_dma_find_controller(), but that will be a little > > > > > complicated than current solution. Since we need introduce one > > > > > structure to save the node to validate in the filter function like > > > > > below, which seems make things complicated. But if you still like to > > > > > use of_dma_find_controller(), I can change to use it in next version. > > > > > > > > Sorry I should have clarified more.. > > > > > > > > of_dma_find_controller() is called by xlate, so you already run this > > > > check, so why use this :) > > > > > > The of_dma_find_controller() can save the requested device node into > > > dma_spec, and in the of_dma_simple_xlate() function, it will call > > > dma_request_channel() to request one channel, but it did not validate > > > the device node to find the corresponding dma device in > > > dma_request_channel(). So we should in our filter function to validate > > > the device node with the device node specified by the dma_spec. Hope I > > > make things clear. > > > > But dma_request_channel() calls of_dma_request_slave_channel() which > > invokes of_dma_find_controller() why is it broken for you if that is the > > case.. > > No,the calling process should be: > dma_request_slave_channel() > --->dma_request_chan()--->of_dma_request_slave_channel()---->of_dma_simple_xlate() > ----> dma_request_channel(). > You can check other drivers, they also will save the device node to validate in their filter function. For example the imx-sdma driver: https://elixir.bootlin.com/linux/v5.1-rc6/source/drivers/dma/imx-sdma.c#L1931 -- Baolin Wang Best Regards