* [PATCH] dmaengine: fsl-edma: Add eDMA support for QorIQ LS1028A platform
@ 2019-10-17 7:09 Peng Ma
2019-10-18 14:25 ` Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: Peng Ma @ 2019-10-17 7:09 UTC (permalink / raw)
To: vkoul
Cc: dan.j.williams, leoyang.li, k.kozlowski.k, fabio.estevam,
dmaengine, linux-kernel, Peng Ma
Our platforms with below registers(CHCFG0 - CHCFG15) of eDMA as follows:
*-----------------------------------------------------------*
| Offset | OTHERS | LS1028A |
|--------------|--------------------|-----------------------|
| 0x0 | CHCFG0 | CHCFG3 |
|--------------|--------------------|-----------------------|
| 0x1 | CHCFG1 | CHCFG2 |
|--------------|--------------------|-----------------------|
| 0x2 | CHCFG2 | CHCFG1 |
|--------------|--------------------|-----------------------|
| 0x3 | CHCFG3 | CHCFG0 |
|--------------|--------------------|-----------------------|
| ... | ...... | ...... |
|--------------|--------------------|-----------------------|
| 0xC | CHCFG12 | CHCFG15 |
|--------------|--------------------|-----------------------|
| 0xD | CHCFG13 | CHCFG14 |
|--------------|--------------------|-----------------------|
| 0xE | CHCFG14 | CHCFG13 |
|--------------|--------------------|-----------------------|
| 0xF | CHCFG15 | CHCFG12 |
*-----------------------------------------------------------*
This patch is to improve edma driver to fit LS1028A platform.
Signed-off-by: Peng Ma <peng.ma@nxp.com>
---
drivers/dma/fsl-edma-common.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c
index b1a7ca9..611186b 100644
--- a/drivers/dma/fsl-edma-common.c
+++ b/drivers/dma/fsl-edma-common.c
@@ -7,6 +7,7 @@
#include <linux/module.h>
#include <linux/slab.h>
#include <linux/dma-mapping.h>
+#include <linux/sys_soc.h>
#include "fsl-edma-common.h"
@@ -42,6 +43,11 @@
#define EDMA_TCD 0x1000
+static struct soc_device_attribute soc_fixup_tuning[] = {
+ { .family = "QorIQ LS1028A"},
+ { },
+};
+
static void fsl_edma_enable_request(struct fsl_edma_chan *fsl_chan)
{
struct edma_regs *regs = &fsl_chan->edma->regs;
@@ -109,10 +115,16 @@ void fsl_edma_chan_mux(struct fsl_edma_chan *fsl_chan,
u32 ch = fsl_chan->vchan.chan.chan_id;
void __iomem *muxaddr;
unsigned int chans_per_mux, ch_off;
+ int endian_diff[4] = {3, 1, -1, -3};
u32 dmamux_nr = fsl_chan->edma->drvdata->dmamuxs;
chans_per_mux = fsl_chan->edma->n_chans / dmamux_nr;
ch_off = fsl_chan->vchan.chan.chan_id % chans_per_mux;
+
+ if (!fsl_chan->edma->big_endian &&
+ soc_device_match(soc_fixup_tuning))
+ ch_off += endian_diff[ch_off % 4];
+
muxaddr = fsl_chan->edma->muxbase[ch / chans_per_mux];
slot = EDMAMUX_CHCFG_SOURCE(slot);
--
2.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dmaengine: fsl-edma: Add eDMA support for QorIQ LS1028A platform
2019-10-17 7:09 [PATCH] dmaengine: fsl-edma: Add eDMA support for QorIQ LS1028A platform Peng Ma
@ 2019-10-18 14:25 ` Fabio Estevam
2019-10-18 14:28 ` [EXT] " Peng Ma
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2019-10-18 14:25 UTC (permalink / raw)
To: Peng Ma
Cc: Vinod, Dan Williams, Li Yang, Krzysztof Kozłowski,
Fabio Estevam, dmaengine, linux-kernel
Hi Peng,
On Fri, Oct 18, 2019 at 7:08 AM Peng Ma <peng.ma@nxp.com> wrote:
>
> Our platforms with below registers(CHCFG0 - CHCFG15) of eDMA as follows:
Please be more specific: what does "Our platforms" mean?
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [EXT] Re: [PATCH] dmaengine: fsl-edma: Add eDMA support for QorIQ LS1028A platform
2019-10-18 14:25 ` Fabio Estevam
@ 2019-10-18 14:28 ` Peng Ma
2019-10-18 14:40 ` Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: Peng Ma @ 2019-10-18 14:28 UTC (permalink / raw)
To: Fabio Estevam
Cc: Vinod, Dan Williams, Leo Li, Krzysztof Kozłowski,
Fabio Estevam, dmaengine, linux-kernel
Hi Fabio,
Thanks for your comments.
Do you mean I explain "Our platforms" here or in patch?
Best Regards,
Peng
>-----Original Message-----
>From: Fabio Estevam <festevam@gmail.com>
>Sent: 2019年10月18日 22:25
>To: Peng Ma <peng.ma@nxp.com>
>Cc: Vinod <vkoul@kernel.org>; Dan Williams <dan.j.williams@intel.com>; Leo
>Li <leoyang.li@nxp.com>; Krzysztof Kozłowski <k.kozlowski.k@gmail.com>;
>Fabio Estevam <fabio.estevam@nxp.com>; dmaengine@vger.kernel.org;
>linux-kernel <linux-kernel@vger.kernel.org>
>Subject: [EXT] Re: [PATCH] dmaengine: fsl-edma: Add eDMA support for QorIQ
>LS1028A platform
>
>Caution: EXT Email
>
>Hi Peng,
>
>On Fri, Oct 18, 2019 at 7:08 AM Peng Ma <peng.ma@nxp.com> wrote:
>>
>> Our platforms with below registers(CHCFG0 - CHCFG15) of eDMA as follows:
>
>Please be more specific: what does "Our platforms" mean?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [EXT] Re: [PATCH] dmaengine: fsl-edma: Add eDMA support for QorIQ LS1028A platform
2019-10-18 14:28 ` [EXT] " Peng Ma
@ 2019-10-18 14:40 ` Fabio Estevam
2019-10-18 14:42 ` Peng Ma
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2019-10-18 14:40 UTC (permalink / raw)
To: Peng Ma
Cc: Vinod, Dan Williams, Leo Li, Krzysztof Kozłowski,
Fabio Estevam, dmaengine, linux-kernel
Hi Peng,
On Fri, Oct 18, 2019 at 11:28 AM Peng Ma <peng.ma@nxp.com> wrote:
>
> Hi Fabio,
>
> Thanks for your comments.
> Do you mean I explain "Our platforms" here or in patch?
It would be better to send a v2 with an improved commit log, which
explains what "Our platforms" mean.
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [EXT] Re: [PATCH] dmaengine: fsl-edma: Add eDMA support for QorIQ LS1028A platform
2019-10-18 14:40 ` Fabio Estevam
@ 2019-10-18 14:42 ` Peng Ma
0 siblings, 0 replies; 5+ messages in thread
From: Peng Ma @ 2019-10-18 14:42 UTC (permalink / raw)
To: Fabio Estevam
Cc: Vinod, Dan Williams, Leo Li, Krzysztof Kozłowski,
Fabio Estevam, dmaengine, linux-kernel
Hi Fabio,
>-----Original Message-----
>From: Fabio Estevam <festevam@gmail.com>
>Sent: 2019年10月18日 22:40
>To: Peng Ma <peng.ma@nxp.com>
>Cc: Vinod <vkoul@kernel.org>; Dan Williams <dan.j.williams@intel.com>; Leo
>Li <leoyang.li@nxp.com>; Krzysztof Kozłowski <k.kozlowski.k@gmail.com>;
>Fabio Estevam <fabio.estevam@nxp.com>; dmaengine@vger.kernel.org;
>linux-kernel <linux-kernel@vger.kernel.org>
>Subject: Re: [EXT] Re: [PATCH] dmaengine: fsl-edma: Add eDMA support for
>QorIQ LS1028A platform
>
>Caution: EXT Email
>
>Hi Peng,
>
>On Fri, Oct 18, 2019 at 11:28 AM Peng Ma <peng.ma@nxp.com> wrote:
>>
>> Hi Fabio,
>>
>> Thanks for your comments.
>> Do you mean I explain "Our platforms" here or in patch?
>
>It would be better to send a v2 with an improved commit log, which explains
>what "Our platforms" mean.
>
>Thanks
[Peng Ma] God it ,thanks.
Best Regards,
Peng
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-18 14:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-17 7:09 [PATCH] dmaengine: fsl-edma: Add eDMA support for QorIQ LS1028A platform Peng Ma
2019-10-18 14:25 ` Fabio Estevam
2019-10-18 14:28 ` [EXT] " Peng Ma
2019-10-18 14:40 ` Fabio Estevam
2019-10-18 14:42 ` Peng Ma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).