From: Dan Williams <dan.j.williams@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Dave Jiang <dave.jiang@intel.com>,
dmaengine@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] dmaengine: ioat: depends on !UML
Date: Mon, 9 Aug 2021 10:24:13 -0700 [thread overview]
Message-ID: <CAPcyv4i0p-DaPA7YTid4XsUJUpq+L-c1kDNArb=0XXnFkXz-iw@mail.gmail.com> (raw)
In-Reply-To: <20210809112409.a3a0974874d2.I2ffe3d11ed37f735da2f39884a74c953b258b995@changeid>
On Mon, Aug 9, 2021 at 2:25 AM Johannes Berg <johannes@sipsolutions.net> wrote:
>
> From: Johannes Berg <johannes.berg@intel.com>
>
> Now that UML has PCI support, this driver must depend also on
> !UML since it pokes at X86_64 architecture internals that don't
> exist on ARCH=um.
>
Do you really need to disable compilation of the whole driver just
because an arch level helper does not exist on UML builds? Isn't there
already a check for enqcmds on x86_64 to make sure the CPU is
sufficiently feature enabled?
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> drivers/dma/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 39b5b46e880f..dc155f75926d 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -315,7 +315,7 @@ config INTEL_IDXD_PERFMON
>
> config INTEL_IOATDMA
> tristate "Intel I/OAT DMA support"
> - depends on PCI && X86_64
> + depends on PCI && X86_64 && !UML
> select DMA_ENGINE
> select DMA_ENGINE_RAID
> select DCA
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-08-09 17:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 9:24 [PATCH] dmaengine: ioat: depends on !UML Johannes Berg
2021-08-09 16:02 ` Dave Jiang
2021-08-09 17:24 ` Dan Williams [this message]
2021-08-09 17:26 ` Johannes Berg
2021-08-25 13:31 ` Dan Williams
2021-08-25 13:33 ` Johannes Berg
2021-08-25 13:36 ` Dan Williams
2021-08-25 13:41 ` Johannes Berg
2021-08-25 13:53 ` Dan Williams
2021-08-25 11:31 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4i0p-DaPA7YTid4XsUJUpq+L-c1kDNArb=0XXnFkXz-iw@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).