dmaengine.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Radhey Shyam Pandey <radheys@xilinx.com>
To: Baokun Li <libaokun1@huawei.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Vinod Koul <vkoul@kernel.org>, Michal Simek <michals@xilinx.com>,
	Shravya Kumbham <shravyak@xilinx.com>,
	Matthew Murrian <matthew.murrian@goctsi.com>,
	Romain Perier <romain.perier@gmail.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Allen Pais <allen.lkml@gmail.com>
Cc: "weiyongjun1@huawei.com" <weiyongjun1@huawei.com>,
	"yuehaibing@huawei.com" <yuehaibing@huawei.com>,
	"yangjihong1@huawei.com" <yangjihong1@huawei.com>,
	"yukuai3@huawei.com" <yukuai3@huawei.com>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>, Hulk Robot <hulkci@huawei.com>
Subject: RE: [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead of list_del/list_add_tail
Date: Tue, 8 Jun 2021 13:16:56 +0000	[thread overview]
Message-ID: <CH2PR02MB6523048911423F5583772FE9C7379@CH2PR02MB6523.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20210608030905.2818831-1-libaokun1@huawei.com>

> -----Original Message-----
> From: Baokun Li <libaokun1@huawei.com>
> Sent: Tuesday, June 8, 2021 8:39 AM
> To: linux-kernel@vger.kernel.org; Vinod Koul <vkoul@kernel.org>; Michal
> Simek <michals@xilinx.com>; Radhey Shyam Pandey <radheys@xilinx.com>;
> Shravya Kumbham <shravyak@xilinx.com>; Matthew Murrian
> <matthew.murrian@goctsi.com>; Romain Perier
> <romain.perier@gmail.com>; Lars-Peter Clausen <lars@metafoo.de>;
> Krzysztof Kozlowski <krzk@kernel.org>; Allen Pais <allen.lkml@gmail.com>
> Cc: weiyongjun1@huawei.com; yuehaibing@huawei.com;
> yangjihong1@huawei.com; yukuai3@huawei.com; libaokun1@huawei.com;
> dmaengine@vger.kernel.org; linux-arm-kernel@lists.infradead.org; kernel-
> janitors@vger.kernel.org; Hulk Robot <hulkci@huawei.com>
> Subject: [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead of
> list_del/list_add_tail
> 
> Using list_move_tail() instead of list_del() + list_add_tail().
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Thanks!
> ---
>  drivers/dma/xilinx/xilinx_dma.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
> index 75c0b8e904e5..77022ef05ac5 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -1411,8 +1411,7 @@ static void xilinx_vdma_start_transfer(struct
> xilinx_dma_chan *chan)
> 
>  	chan->desc_submitcount++;
>  	chan->desc_pendingcount--;
> -	list_del(&desc->node);
> -	list_add_tail(&desc->node, &chan->active_list);
> +	list_move_tail(&desc->node, &chan->active_list);
>  	if (chan->desc_submitcount == chan->num_frms)
>  		chan->desc_submitcount = 0;
> 


  reply	other threads:[~2021-06-08 13:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08  3:09 Baokun Li
2021-06-08 13:16 ` Radhey Shyam Pandey [this message]
2021-07-28  6:35 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH2PR02MB6523048911423F5583772FE9C7379@CH2PR02MB6523.namprd02.prod.outlook.com \
    --to=radheys@xilinx.com \
    --cc=allen.lkml@gmail.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=hulkci@huawei.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=lars@metafoo.de \
    --cc=libaokun1@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.murrian@goctsi.com \
    --cc=michals@xilinx.com \
    --cc=romain.perier@gmail.com \
    --cc=shravyak@xilinx.com \
    --cc=vkoul@kernel.org \
    --cc=weiyongjun1@huawei.com \
    --cc=yangjihong1@huawei.com \
    --cc=yuehaibing@huawei.com \
    --cc=yukuai3@huawei.com \
    --subject='RE: [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead of list_del/list_add_tail' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).